chore(cli): add fmt to ready task#178
Merged
Merged
Conversation
This was referenced Sep 22, 2025
Member
Author
fengmk2
marked this pull request as ready for review
September 22, 2025 04:42
fengmk2
force-pushed
the
09-22-chore_cli_add_fmt_to_ready_command
branch
from
September 22, 2025 04:43
36fce8f to
6dd88ea
Compare
fengmk2
force-pushed
the
09-22-chore_cli_temporarily_add_vite_to_allow_any_peerdeps
branch
from
September 22, 2025 04:43
fc70993 to
8bb4b9f
Compare
fengmk2
commented
Sep 22, 2025
fengmk2
force-pushed
the
09-22-chore_cli_add_fmt_to_ready_command
branch
from
September 22, 2025 04:46
6dd88ea to
ea1eb64
Compare
wan9chi
approved these changes
Sep 22, 2025
fengmk2
force-pushed
the
09-22-chore_cli_temporarily_add_vite_to_allow_any_peerdeps
branch
2 times, most recently
from
September 22, 2025 07:22
e63a92d to
9bbc43f
Compare
fengmk2
force-pushed
the
09-22-chore_cli_add_fmt_to_ready_command
branch
from
September 22, 2025 07:22
ea1eb64 to
76f6ca7
Compare
fengmk2
changed the base branch from
09-22-chore_cli_temporarily_add_vite_to_allow_any_peerdeps
to
graphite-base/178
September 22, 2025 07:28
fengmk2
force-pushed
the
09-22-chore_cli_add_fmt_to_ready_command
branch
from
September 22, 2025 07:29
76f6ca7 to
217eb4a
Compare
fengmk2
force-pushed
the
graphite-base/178
branch
from
September 22, 2025 07:29
9bbc43f to
8eb6a0e
Compare
fengmk2
force-pushed
the
09-22-chore_cli_add_fmt_to_ready_command
branch
from
September 22, 2025 07:30
217eb4a to
fa255c6
Compare
fengmk2
force-pushed
the
09-22-chore_cli_add_fmt_to_ready_command
branch
from
September 22, 2025 07:38
fa255c6 to
4f84dd1
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the fmt command to the "ready" task in CLI templates and project generation scripts to ensure code formatting is included in the readiness checks.
- Adds
vite fmtto the beginning of ready scripts in both monorepo and singlerepo templates - Updates the regex pattern in
replaceUnstableOutputto handle@symbols for package version matching - Adds test coverage for the new
@symbol handling in version patterns
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/tools/src/utils.ts | Updates regex to include @ symbol for matching package versions with @ prefix |
| packages/tools/src/tests/utils.spec.ts | Adds test cases for @ symbol version patterns |
| packages/tools/src/tests/snapshots/utils.spec.ts.snap | Updates snapshots to reflect new test cases |
| packages/global/templates/monorepo/package.json | Adds vite fmt to the ready script |
| packages/global/src/new.ts | Adds vite fmt to the ready script in generated projects |
| packages/global/snap-tests/new-singlerepo/steps.json | Adds command to verify package.json content |
| packages/global/snap-tests/new-singlerepo/snap.txt | Updates snapshots with new ready script content |
| packages/global/snap-tests/new-monorepo/steps.json | Adds command to verify package.json content |
| packages/global/snap-tests/new-monorepo/snap.txt | Updates snapshots with new ready script content |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
Author
This was referenced Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.