Skip to content

chore(cli): add fmt to ready task#178

Merged
fengmk2 merged 1 commit into
mainfrom
09-22-chore_cli_add_fmt_to_ready_command
Sep 22, 2025
Merged

chore(cli): add fmt to ready task#178
fengmk2 merged 1 commit into
mainfrom
09-22-chore_cli_add_fmt_to_ready_command

Conversation

@fengmk2

@fengmk2 fengmk2 commented Sep 22, 2025

Copy link
Copy Markdown
Member

No description provided.

@fengmk2 fengmk2 self-assigned this Sep 22, 2025
@fengmk2
fengmk2 marked this pull request as ready for review September 22, 2025 04:42
@fengmk2
fengmk2 force-pushed the 09-22-chore_cli_add_fmt_to_ready_command branch from 36fce8f to 6dd88ea Compare September 22, 2025 04:43
@fengmk2
fengmk2 force-pushed the 09-22-chore_cli_temporarily_add_vite_to_allow_any_peerdeps branch from fc70993 to 8bb4b9f Compare September 22, 2025 04:43
Comment thread packages/global/snap-tests/new-monorepo/snap.txt Outdated
@fengmk2
fengmk2 force-pushed the 09-22-chore_cli_temporarily_add_vite_to_allow_any_peerdeps branch 2 times, most recently from e63a92d to 9bbc43f Compare September 22, 2025 07:22
@fengmk2
fengmk2 force-pushed the 09-22-chore_cli_add_fmt_to_ready_command branch from ea1eb64 to 76f6ca7 Compare September 22, 2025 07:22
@fengmk2
fengmk2 changed the base branch from 09-22-chore_cli_temporarily_add_vite_to_allow_any_peerdeps to graphite-base/178 September 22, 2025 07:28
@fengmk2
fengmk2 force-pushed the 09-22-chore_cli_add_fmt_to_ready_command branch from 76f6ca7 to 217eb4a Compare September 22, 2025 07:29
@graphite-app
graphite-app Bot changed the base branch from graphite-base/178 to main September 22, 2025 07:30
@fengmk2
fengmk2 force-pushed the 09-22-chore_cli_add_fmt_to_ready_command branch from 217eb4a to fa255c6 Compare September 22, 2025 07:30
Copilot AI review requested due to automatic review settings September 22, 2025 07:38
@fengmk2
fengmk2 force-pushed the 09-22-chore_cli_add_fmt_to_ready_command branch from fa255c6 to 4f84dd1 Compare September 22, 2025 07:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the fmt command to the "ready" task in CLI templates and project generation scripts to ensure code formatting is included in the readiness checks.

  • Adds vite fmt to the beginning of ready scripts in both monorepo and singlerepo templates
  • Updates the regex pattern in replaceUnstableOutput to handle @ symbols for package version matching
  • Adds test coverage for the new @ symbol handling in version patterns

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/tools/src/utils.ts Updates regex to include @ symbol for matching package versions with @ prefix
packages/tools/src/tests/utils.spec.ts Adds test cases for @ symbol version patterns
packages/tools/src/tests/snapshots/utils.spec.ts.snap Updates snapshots to reflect new test cases
packages/global/templates/monorepo/package.json Adds vite fmt to the ready script
packages/global/src/new.ts Adds vite fmt to the ready script in generated projects
packages/global/snap-tests/new-singlerepo/steps.json Adds command to verify package.json content
packages/global/snap-tests/new-singlerepo/snap.txt Updates snapshots with new ready script content
packages/global/snap-tests/new-monorepo/steps.json Adds command to verify package.json content
packages/global/snap-tests/new-monorepo/snap.txt Updates snapshots with new ready script content

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

fengmk2 commented Sep 22, 2025

Copy link
Copy Markdown
Member Author

Merge activity

  • Sep 22, 7:38 AM UTC: Graphite rebased this pull request as part of a merge.
  • Sep 22, 7:42 AM UTC: @fengmk2 merged this pull request with Graphite.

@fengmk2
fengmk2 merged commit 57b043a into main Sep 22, 2025
8 of 9 checks passed
@fengmk2
fengmk2 deleted the 09-22-chore_cli_add_fmt_to_ready_command branch September 22, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants