Repository navigation
feat: pass the consumed nonce to NonceManager.reset - #5353
Merged
Merged
Conversation
Add an optional nonce to reset's parameters (NonceManager.ResetParameters), set to what consume returned and left out when consume threw, in transaction.send and transaction.sendSync. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@aelmanaa is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
jxom
added a commit
that referenced
this pull request
Nov 1, 2026
* feat: pass the consumed nonce to NonceManager.reset Port of #5353 to main. Add an optional nonce to reset's parameters, set to what consume returned and left out when consume threw, in sendTransaction and sendTransactionSync. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test: cover nonce release without spies Rewrite the reset-nonce tests to use custom nonce managers instead of `vi.spyOn`, asserting the broadcast nonces: a failed send's nonce is the only one released and the next send reuses it. Document that a failed send does not prove its nonce is unused, and shorten the changeset to one sentence. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D3nmWi1KSPEvFxpccK5EDN --------- Co-authored-by: aelmanaa <aelmanaa@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5352
When
transaction.sendortransaction.sendSyncfails after the account's nonce manager has consumed a nonce, they callreset({ address, chainId }). A manager that reserves a nonce per send can't tell whichconsumethe reset follows, so it can't release just that nonce when sends overlap. The issue has the details and a reproduction.This adds an optional
noncetoreset's parameters (NonceManager.ResetParameters): whatconsumereturned, left out whenconsumethrew. Existing managers keep working, and the built-in ones ignore it. Areset(parameters: NonceManager.Parameters)implementation is still assignable.Alternatives: a separate
release(nonce)method adds API surface, and a per-send handle returned fromconsumeis a breaking change.Tests:
send.test.tsandsendSync.test.tsrecord theresetarguments whenconsumethrows (nononce) and when the broadcast fails (the consumed nonce). The broadcast-failure tests fail without the change. Docs (nonce-manager.mdx) and a changeset are included.This targets
v3.mainhas the same pattern; I can port it there in a separate PR if you want it.