Repository navigation
Conversation
Port of wevm#5353 to main. Add an optional nonce to reset's parameters, set to what consume returned and left out when consume threw, in sendTransaction and sendTransactionSync. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 05b61c1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@aelmanaa is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
Thanks @aelmanaa! Superseded by #5373, which keeps your commit (rebased onto Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5352
Ports #5353 (merged into
v3) tomain.When
sendTransactionorsendTransactionSyncfails after the account's nonce manager has consumed a nonce, it callsreset({ address, chainId }). A manager that reserves a nonce per send can't tell whichconsumethe reset follows, so when sends overlap it can't release only that nonce. The issue has details and a reproduction.As on
v3,reset's parameters get an optionalnonce. It holds the valueconsumereturned, and it is omitted whenconsumethrew. Existing managers keep working, andcreateNonceManagerignores the new field. Aresettyped with only{ address, chainId }is still assignable toNonceManager.Differences from #5353:
mainhas noNonceManagernamespace, so the new parameter type is not exported.src/utils/nonceManager.test.ts, next to the existing reset tests from fix: resetnonceManagerafter failed sends #4634, and use acustomtransport. They record theresetarguments whenconsumethrows (nononce) and when the broadcast fails (the consumed nonce). The broadcast-failure tests fail without the change.createNonceManagerpage.A changeset is included.