Repository navigation
Bump Laya: source 8a6e1328, model 7b928d82 - #317
Merged
Merged
Conversation
|
Docs7 for 1bit-monster/engine
Commit |
PR Reviewer Guide 🔍(Review updated until commit 1576942)Here are some key observations to aid the review process:
|
|
Persistent review updated to latest commit efcb4aa |
bong-water-water-bong
force-pushed
the
bump-laya/8a6e1328-7b928d82
branch
from
October 5, 2026 21:27
efcb4aa to
7444a6f
Compare
|
Persistent review updated to latest commit 7444a6f |
bong-water-water-bong
force-pushed
the
bump-laya/8a6e1328-7b928d82
branch
from
October 5, 2026 21:45
7444a6f to
1576942
Compare
|
Persistent review updated to latest commit 1576942 |
bong-water-water-bong
added a commit
that referenced
this pull request
Oct 28, 2026
One line: `third_party/laya` `7a77439b0923` -> `b9fe351ce81e`. `config/laya.json` already pins model revision `7b928d828b7b` (unchanged since #317), so this is the source-only half of a bump — the sixth in a row (#439, #452, #459, #511, #538, #568) and the model the router scores is untouched. Nothing in the tree reads or compiles the submodule: `grep -rn third_party/laya` matches only `.github/workflows/bump-laya.yml`, the router builds engine-local `laya/` (`CMakeLists.txt:334`) and the optional fast scorer builds `third_party/ggmlc` (`cmake/laya-ggml.cmake:24`), so the bump-laya workflow's 'run scripts/fetch-laya.sh and the Laya tests' step has no code path to exercise and its HF fetch was deliberately not run while the measurement pass owns this box. Risk: a stale provenance reference only — worst case whoever next diffs the submodule against NandhaKishorM/laya main sees one more commit than the record, revertible by moving the one gitlink back.
bong-water-water-bong
added a commit
that referenced
this pull request
Oct 29, 2026
…ump-laya.yml keeps them docs/laya.md's "The pin" table names bump-laya.yml as the thing that keeps both rows current, but bump-laya.yml only moves third_party/laya and config/laya.json -- it never writes the doc. So both rows had rotted: - Source: said `6d942c92`; the gitlink has been `b9fe351c` since #611 and is `fe9a6c35` here. - Checkpoints: said revision `55cf4c4e`; config/laya.json has been `7b928d82` since #317 (37cf390). docs/laya.md was last edited in #488. Set both to what this branch actually pins, so the doc and the gitlinks agree: git ls-tree HEAD third_party/laya -> fe9a6c35023a7d94102e7feaaeaae8857d9d1b07 config/laya.json revision -> 7b928d828b7b0e022f929d9bd2e44165aa270148 The durable fix is for bump-laya.yml to rewrite these two rows as it bumps, so they cannot drift again. I cannot make that change here: pushing a file under .github/workflows needs a token with the `workflow` scope and this one has only gist/read:org/repo -- ! [remote rejected] tmp/scope-probe -> tmp/scope-probe (refusing to allow an OAuth App to create or update workflow `.github/workflows/bump-laya.yml` without `workflow` scope)
bong-water-water-bong
added a commit
that referenced
this pull request
Oct 29, 2026
* Bump Laya: source fe9a6c35023a, model 7b928d828b7b * Laya: record this bump's pins in docs/laya.md, where the table says bump-laya.yml keeps them docs/laya.md's "The pin" table names bump-laya.yml as the thing that keeps both rows current, but bump-laya.yml only moves third_party/laya and config/laya.json -- it never writes the doc. So both rows had rotted: - Source: said `6d942c92`; the gitlink has been `b9fe351c` since #611 and is `fe9a6c35` here. - Checkpoints: said revision `55cf4c4e`; config/laya.json has been `7b928d82` since #317 (37cf390). docs/laya.md was last edited in #488. Set both to what this branch actually pins, so the doc and the gitlinks agree: git ls-tree HEAD third_party/laya -> fe9a6c35023a7d94102e7feaaeaae8857d9d1b07 config/laya.json revision -> 7b928d828b7b0e022f929d9bd2e44165aa270148 The durable fix is for bump-laya.yml to rewrite these two rows as it bumps, so they cannot drift again. I cannot make that change here: pushing a file under .github/workflows needs a token with the `workflow` scope and this one has only gist/read:org/repo -- ! [remote rejected] tmp/scope-probe -> tmp/scope-probe (refusing to allow an OAuth App to create or update workflow `.github/workflows/bump-laya.yml` without `workflow` scope) --------- Co-authored-by: laya-bump <laya-bump@users.noreply.github.com> Co-authored-by: bong-water-water-bong <bong-water-water-bong@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
third_party/laya:
4aa6761be817->8a6e1328cce2(NandhaKishorM/laya main). config/laya.json revision:55cf4c4ebb4e->7b928d828b7b(convaiinnovations/laya).Before merging: scripts/fetch-laya.sh
(verifies every file) and the Laya tests.