Repository navigation
Bump Laya: source ca5045a3, model 7b928d82 - #439
Merged
Merged
Conversation
PR Reviewer Guide 🔍(Review updated until commit 46a0a37)Here are some key observations to aid the review process:
|
|
Persistent review updated to latest commit 46a0a37 |
bong-water-water-bong
added a commit
that referenced
this pull request
Oct 18, 2026
…awn_worker, census, #433) (#446) * docs: the 2026-10-17/18 merges (HRX pins, DwarfStar, PM router and spawn_worker, census, #433) The docs still described the pre-2026-10-18 line. - README status: HRX pinned to AMD e3e6a976 + llama.cpp 8d9ce2c1a with the measured gate numbers; DwarfStar pinned to 5b013dc1bb75 (1BP v5) and its hardware check; the PM gains --pm-router laya and --pm-spawn-url; the census numbers of 2026-10-17. - docs/PORTING.md: the HRX pin (step 2), the Laya source/revision bump (step 4), the 2026-10-17 census (step 5). - docs/registry.md: the 2026-10-17 census table, against registry/census.json, and the current unmapped list. - docs/hrx.md: the engine#433 finding next to the other HRX0 known issues (no abort in 60 fresh loads; the 458-token prompt cannot come from this model template). - docs/dwarfstar.md: what the 2026-10-17 pin was checked on, and that serve cannot set ds4 expert cache size. - .github/workflows/bump-hrx.yml: the loom-jit trap is now described as the step that guards it, with #441 as the validated hand move and #422 still open. Facts from merged PRs #441, #429, #438, #439, #434, #436 and the hardware comments on #441 (TPIN) and #429 (TDS4). * docs/hrx.md: the LoomC-symbol guard, which is the loom-jit trap, and #441 as the validated hand move The workflow comment that described the trap cannot be pushed with this token (no workflow scope), so the fact lives where the pin process is documented: docs/hrx.md, next to the hold. --------- Co-authored-by: pi-zayap2 <bcloud@localhost>
bong-water-water-bong
added a commit
that referenced
this pull request
Oct 28, 2026
One line: `third_party/laya` `7a77439b0923` -> `b9fe351ce81e`. `config/laya.json` already pins model revision `7b928d828b7b` (unchanged since #317), so this is the source-only half of a bump — the sixth in a row (#439, #452, #459, #511, #538, #568) and the model the router scores is untouched. Nothing in the tree reads or compiles the submodule: `grep -rn third_party/laya` matches only `.github/workflows/bump-laya.yml`, the router builds engine-local `laya/` (`CMakeLists.txt:334`) and the optional fast scorer builds `third_party/ggmlc` (`cmake/laya-ggml.cmake:24`), so the bump-laya workflow's 'run scripts/fetch-laya.sh and the Laya tests' step has no code path to exercise and its HF fetch was deliberately not run while the measurement pass owns this box. Risk: a stale provenance reference only — worst case whoever next diffs the submodule against NandhaKishorM/laya main sees one more commit than the record, revertible by moving the one gitlink back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
third_party/laya:
4ac226d5ee88->ca5045a3f1fa(NandhaKishorM/laya main). config/laya.json revision:7b928d828b7b->7b928d828b7b(convaiinnovations/laya).Before merging: scripts/fetch-laya.sh
(verifies every file) and the Laya tests.