Repository navigation
Bump Laya: source d74e8be4, model 7b928d82 - #452
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
|
Laya pin check on ryzen (CPU only): Method: both commits checked out as detached worktrees of NandhaKishorM/laya, every Result: 101 test files exist at both commits, 104 at the new one (added
Every failure is an environment gap or a test that needs the full three-checkpoint model root, not a code difference:
Nothing new fails. The engine-side dependency is clean too: the PR touches only PR-READY per the pin-bump rule: no new test failure against the old pin. |
One line: `third_party/laya` `7a77439b0923` -> `b9fe351ce81e`. `config/laya.json` already pins model revision `7b928d828b7b` (unchanged since #317), so this is the source-only half of a bump — the sixth in a row (#439, #452, #459, #511, #538, #568) and the model the router scores is untouched. Nothing in the tree reads or compiles the submodule: `grep -rn third_party/laya` matches only `.github/workflows/bump-laya.yml`, the router builds engine-local `laya/` (`CMakeLists.txt:334`) and the optional fast scorer builds `third_party/ggmlc` (`cmake/laya-ggml.cmake:24`), so the bump-laya workflow's 'run scripts/fetch-laya.sh and the Laya tests' step has no code path to exercise and its HF fetch was deliberately not run while the measurement pass owns this box. Risk: a stale provenance reference only — worst case whoever next diffs the submodule against NandhaKishorM/laya main sees one more commit than the record, revertible by moving the one gitlink back.
third_party/laya:
ca5045a3f1fa->d74e8be46ef5(NandhaKishorM/laya main). config/laya.json revision:7b928d828b7b->7b928d828b7b(convaiinnovations/laya).Before merging: scripts/fetch-laya.sh
(verifies every file) and the Laya tests.