perf(web): keep react-virtualized out of the entry chunk

[dylanjeffers]

Replaces #14566, which GitHub closed when a force-push (rebasing off the now-merged #14565) orphaned the head SHA it had recorded. Same branch, same content — now a clean 6-file diff against main.

2 of 4 in a stack reducing the web entry chunk. #14565 is merged; this is next.

What

react-virtualized is ~638 KB of source and was landing in the entry chunk for every visitor through two unrelated edges, neither of which needs it at first paint.

1. FilterButton imported it statically

It only renders VirtualizedOptionsList behind the opt-in virtualized prop — 3 call sites in the whole web app. Split into its own module, loaded on demand behind a Suspense boundary. The menu only renders while open, so the import starts when a virtualized filter menu is actually opened.

FilterButton is reachable from the eager app shell via PaymentMethod, which is why this landed in the entry chunk rather than a lazy page.

Note the as typeof import(...) on the lazy const: React.lazy erases the component's <Value extends string> generic, so it would otherwise resolve to the string instantiation and lose type safety at call sites.

2. A five-line predicate

TransactionDetailsContent imported isChangePositive — a function that checks two enum values — from AudioTransactionsTable. That module imports components/table, which imports react-virtualized. Because the TransactionDetails modal is registered eagerly in registerNiceModals, the entire virtualized table came along for this:

export const isChangePositive = (tx: TransactionDetails) => {
  return (
    tx.transactionType === TransactionType.PURCHASE ||
    tx.method === TransactionMethod.RECEIVE
  )
}

Moved to its own module, re-exported from the table for backwards compatibility.

Verification

react-virtualized confirmed absent from the entry chunk via sourcemap attribution. Web tests pass (152), typecheck and lint clean.

🤖 Generated with Claude Code

[changeset-bot]

⚠️ No Changeset found

Latest commit: e7eb45c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR