Skip to content

Fix wallet lazy-load, upload seed and track follow-ups - #14603

Merged
dylanjeffers merged 8 commits into
mainfrom
fix/review-cleanup-aug
Sep 24, 2026
Merged

dylanjeffers merged 8 commits into
mainfrom
fix/review-cleanup-aug

Conversation

@dylanjeffers

Copy link
Copy Markdown
Contributor

Follow-ups from reviewing #14561, #14562, #14567, #14568, #14569, #14570, #14571 and #14572.

Logic fixes

Comment cleanup: shortened or removed long history-style comments from these PRs, and dropped the no-track_cid claim, since api#1032 isn't merged.

Tests

  • tsc passes for web, common, harmony, mobile and sdk.
  • vitest passes: UploadTrackForm.test.ts, the new SelectPage.test.ts and trackAvailability.test.ts, FanClubDetailPage.test.tsx, ProfilePage.test.tsx.
  • eslint passes on changed files.
  • Local dev server:
    • A signed-out visitor with no persisted wallet doesn't load AppKit.
    • With a fake persisted wagmi.store, AppKit loads, the reconnect runs, and the SDK initializes (falls back to Hedgehog, no hang).
    • Importing ReownAppKitModal directly marks AppKit as loaded.
  • Not tested with a real external wallet.

🤖 Generated with Claude Code

dylanjeffers and others added 8 commits September 23, 2026 16:45
- Start wagmi reconnect when a lazily loaded config is still disconnected,
  so external-wallet users don't fall back to Hedgehog
- Fall back to Hedgehog if the AppKit chunk fails to load, and allow a retry
- Track AppKit as loaded when ReownAppKitModal is imported directly
- Disable injected-wallet discovery on the placeholder wagmi config
- Define audiusChain in one place

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The form reinitializes after each submit and re-spread the seed (genre,
remix_of, artwork, stream/download conditions) over the user's edits.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Effects that call lottieRef.current.play() ran before the ref existed and
did not re-run. Also render a sized placeholder while the chunk loads.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Also replace history when redirecting to the not-found page so Back
doesn't loop.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ve copy

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Sep 23, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: e0a95cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dylanjeffers
dylanjeffers merged commit 6abbe97 into main Sep 24, 2026
24 checks passed
@dylanjeffers
dylanjeffers deleted the fix/review-cleanup-aug branch September 24, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant