Fix wallet lazy-load, upload seed and track follow-ups - #14603
Merged
Merged
Conversation
- Start wagmi reconnect when a lazily loaded config is still disconnected, so external-wallet users don't fall back to Hedgehog - Fall back to Hedgehog if the AppKit chunk fails to load, and allow a retry - Track AppKit as loaded when ReownAppKitModal is imported directly - Disable injected-wallet discovery on the placeholder wagmi config - Define audiusChain in one place Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The form reinitializes after each submit and re-spread the seed (genre, remix_of, artwork, stream/download conditions) over the user's edits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Effects that call lottieRef.current.play() ran before the ref existed and did not re-run. Also render a sized placeholder while the chunk loads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Also replace history when redirecting to the not-found page so Back doesn't loop. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ve copy Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from reviewing #14561, #14562, #14567, #14568, #14569, #14570, #14571 and #14572.
Logic fixes
disconnected, and only WagmiProvider's re-render kicks offreconnect(). If the SDK read the status first, an external-wallet user was cached with an empty Hedgehog client.getAudiusWalletClientnow starts the reconnect itself.initSdkthrew and leftinProgressstuck, so every lateraudiusSdk()call hung. It now falls back to Hedgehog, and the memoized import resets so it can be retried.ReownAppKitModaldirectly (Buy/Sell, sign-in) never marked AppKit as loaded. wagmi hooks kept reading the placeholder config, and sign-out skipped the wallet disconnect. The module now registers itself when it is evaluated.audiusChainwas defined twice; there is now one definition.initialMetadata(contest genre/remix/artwork, coin-gate conditions) on every reinitialize. Example: switching a coin-gated upload to Public, cancelling the confirm modal and continuing again brought the gate back. The seed is now applied once, when leaving the select step.lottieRef.current.play()ran before the lazy chunk loaded and never re-ran, so the play-bar loading spinner could stay frozen.LazyLottienow reports when the ref is ready (callers re-run their effect) and renders a sized placeholder while the chunk loads.Comment cleanup: shortened or removed long history-style comments from these PRs, and dropped the no-
track_cidclaim, since api#1032 isn't merged.Tests
tscpasses for web, common, harmony, mobile and sdk.UploadTrackForm.test.ts, the newSelectPage.test.tsandtrackAvailability.test.ts,FanClubDetailPage.test.tsx,ProfilePage.test.tsx.wagmi.store, AppKit loads, the reconnect runs, and the SDK initializes (falls back to Hedgehog, no hang).ReownAppKitModaldirectly marks AppKit as loaded.🤖 Generated with Claude Code