fix(track): render unavailable tracks as a 404 instead of a custom tombstone - #14572
Merged
Merged
Conversation
…mbstone #14570 gave tracks whose owner is no longer active - a self deactivation, or an account delisted by the trusted notifier - a bespoke "Track Unavailable" page. Per Ray's feedback on the original report, these should look like any other missing page instead. The API already returns 404 for these tracks specifically so they can't be told apart from one that never existed (api#1023). Making the web page a real 404 finishes that: the client reuses the existing `navigate(NOT_FOUND_PAGE)` path that a failed track fetch already takes, and SSR renders a not-found skeleton with 404 meta tags. The render-time guard stays, returning null rather than the tombstone. The redirect fires from an effect, which runs after the first paint, so without it the track's title and artwork would flash on screen before the redirect landed. Removes the now-unused UnavailableTrackPage, and moves its server twin to not-found-page/ServerNotFound with the 404 copy. Mobile (React Native) and the embed player keep their existing treatment: neither has a distinct 404 screen to route to, so their unavailable state already is the not-found equivalent. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
dylanjeffers
added a commit
that referenced
this pull request
Sep 24, 2026
Follow-ups from reviewing #14561, #14562, #14567, #14568, #14569, #14570, #14571 and #14572. **Logic fixes** - **Wallet auth, reconnect race (#14567):** a lazily loaded wagmi config starts out `disconnected`, and only WagmiProvider's re-render kicks off `reconnect()`. If the SDK read the status first, an external-wallet user was cached with an empty Hedgehog client. `getAudiusWalletClient` now starts the reconnect itself. - **Wallet auth, failed chunk load (#14567):** if the AppKit chunk failed to load, `initSdk` threw and left `inProgress` stuck, so every later `audiusSdk()` call hung. It now falls back to Hedgehog, and the memoized import resets so it can be retried. - **Direct AppKit imports (#14567):** importing `ReownAppKitModal` directly (Buy/Sell, sign-in) never marked AppKit as loaded. wagmi hooks kept reading the placeholder config, and sign-out skipped the wallet disconnect. The module now registers itself when it is evaluated. - **Placeholder wagmi config (#14567):** it silently reconnected any injected wallet the site had been authorized for, because injected-wallet discovery was on and there was no storage. Discovery is now off and it has no connectors. - **Duplicate chain definition (#14567):** `audiusChain` was defined twice; there is now one definition. - **Upload seed (#14561):** the upload form re-applied `initialMetadata` (contest genre/remix/artwork, coin-gate conditions) on every reinitialize. Example: switching a coin-gated upload to Public, cancelling the confirm modal and continuing again brought the gate back. The seed is now applied once, when leaving the select step. - **Lazy Lottie playback (#14568):** effects that call `lottieRef.current.play()` ran before the lazy chunk loaded and never re-ran, so the play-bar loading spinner could stay frozen. `LazyLottie` now reports when the ref is ready (callers re-run their effect) and renders a sized placeholder while the chunk loads. - **Unavailable tracks (#14570/#14572):** owners are exempt from the non-streamable redirect, so an artist can reach their own track once the API also flags no-audio tracks (api#1032). The redirect to 404 now replaces history, so Back doesn't loop. - **Empty-feed suggestions (#14562):** mobile web now uses the personalized follow suggestions, and the native empty feed switches its copy when suggestions are personalized. **Comment cleanup:** shortened or removed long history-style comments from these PRs, and dropped the no-`track_cid` claim, since api#1032 isn't merged. **Tests** - `tsc` passes for web, common, harmony, mobile and sdk. - vitest passes: `UploadTrackForm.test.ts`, the new `SelectPage.test.ts` and `trackAvailability.test.ts`, `FanClubDetailPage.test.tsx`, `ProfilePage.test.tsx`. - eslint passes on changed files. - Local dev server: - A signed-out visitor with no persisted wallet doesn't load AppKit. - With a fake persisted `wagmi.store`, AppKit loads, the reconnect runs, and the SDK initializes (falls back to Hedgehog, no hang). - Importing `ReownAppKitModal` directly marks AppKit as loaded. - Not tested with a real external wallet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #14570, per Ray's feedback in the #eng thread on the original report:
#14570 gave tracks whose owner is no longer active — a self deactivation, or an account delisted by the trusted notifier — a bespoke "Track Unavailable" page. This makes them a plain 404 instead.
That's also the more consistent answer. AudiusProject/api#1023 deliberately returns 404 rather than 403 for these tracks so they can't be told apart from a track that never existed; the web page was the one surface still announcing that something specific used to be there.
Change
navigate(NOT_FOUND_PAGE)path that a failed track fetch already takes, rather than importing a page component.Not Found/404 - Page not found), stillnoIndex, still no embed player.UnavailableTrackPage; moves its server twin tonot-found-page/ServerNotFoundwith the 404 copy.The render-time guard stays but returns
nullinstead of the tombstone. The redirect fires from an effect, which runs after first paint — without the guard the track's title and artwork would flash on screen before the redirect landed. That was the one thing the oldreturn <UnavailableTrackPage />got for free.Scope
Mobile (React Native) and the embed player are unchanged. Neither has a distinct 404 screen to route to, so their unavailable state already is the not-found equivalent — pointing them at a "404" would just mean different copy for the same thing.
Verification
Against prod data via the SSR dev server, using
rehoxx/just-for-tonight-wmellark-hoonds(the track from the original report):og:title=Not Found • Audius,og:description=404 - Page not found,robots: noindex, notwitter:player, no signedcidstreamURL/404with the standard 404 page; track title never appears in the rendered bodytsc --noEmitandeslintboth clean.Note
The SSR hydration payload still carries the track's
titleandorig_filename, since it's the raw API response. Pre-existing and unchanged by this PR — flagging it as a separate thing worth deciding on.🤖 Generated with Claude Code