You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-10-12] [$175] BA-Bank account row with SETUP status is active and interactive while offline #102329
Root cause (high confidence):Allow the workflows bank account row to be tapped while offline (Expensify/App#101450, merged 2026-09-21) removed the offline check from the Workflows → Payments bank account row for every bank account state. Only the locked-account unlock request works offline. An "Incomplete" (SETUP) row now opens the bank account flow, and that flow is blocked offline.
Please re-state the problem that we are trying to solve in this issue.
In Workspace → Workflows → Payments, a partly set up bank account row (with the "Incomplete" badge) can be clicked while offline. Clicking it opens an RHP that only says "You appear to be offline." The row should be disabled offline.
What is the root cause of that problem?
The row's press and disabled logic no longer looks at isOffline:
Expensify/App#101450 removed isOffline from both lines to fix the locked-account case. The locked reimburser path queues an optimistic unlock request. Every other state, including SETUP, falls through to navigateToBankAccountRoute in handleBankAccountPress. When the user exits the flow mid-way, the reimbursement account data is cleared. Reopening it offline then shows FullPageOfflineBlockingView.
What changes do you think we should make in order to solve the problem?
In WorkflowsPaymentsTab.tsx, restore the offline check for all states except the locked account pressed by the reimburser:
Add a flag that is true when isOffline is true and the account is not (isBusinessBankAccountLocked and isUserReimburser). Declare it before line 166.
Add that flag to canInteractWithBankAccountRow (line 166) and to disabled (line 255).
The "Finish" button uses isActionDisabled={!canInteractWithBankAccountRow} (line 320). It will be disabled offline with no extra change.
Add a UI test: SETUP account, offline, the row and "Finish" are disabled and do not navigate. The existing tests/ui/WorkspaceWorkflowsLockedBankAccountTest.tsx should still pass.
This matches the "Add bank account" row in the same file, which is already inert offline (line 167).
What alternative solutions did you explore? (Optional)
Make ReimbursementAccountPage usable offline. This is a bigger change, and the flow needs server data.
Investigation details
The "Incomplete" badge comes from getBankAccountConnectionStatus for BANK_ACCOUNT.STATE.SETUP (BankAccountUtils.ts:72-80). Non-USD PENDING accounts get the same badge.
The PR diff removed !isOffline from canInteractWithBankAccountRow and isOffline || from disabled. Its own regression steps said SETUP, OPEN, and PENDING offline behavior should stay unchanged.
The issue was reported on v9.4.94-0, after that PR was deployed.
Open question: the fix also disables OPEN and VERIFYING rows offline. That matches behavior before Expensify/App#101450, and their press also lands on the offline-blocked page.
I did not reproduce this in the browser. The conclusion is based on the code and the PR diff.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/102329) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
changed the title [-]BA-Bank account row with SETUP status is active and interactive while offline[/-][+][$175] BA-Bank account row with SETUP status is active and interactive while offline[/+]on Sep 25, 2026
Please re-state the problem that we are trying to solve in this issue.
In Workspace > Workflows > Payments, a bank account row in SETUP status (displaying the "Incomplete" badge) remains active and interactive while offline. Clicking the row or the "Finish" action opens the Reimbursement Account RHP, which immediately blocks the user with the "You appear to be offline. This feature requires an active internet connection" offline blocking view.
What is the root cause of that problem?
In PR #101450 ("Allow the workflows bank account row to be tapped while offline"), !isOffline was removed unconditionally from WorkflowsPaymentsTab.tsx:
While removing the offline guard was intended to allow the locked bank account unlock flow (which operates optimistically via pressLockedBankAccount and navigates to Concierge chat), all other bank account states (including SETUP, OPEN, and VERIFYING) fall through to navigateToBankAccountRoute (lines 236–239).
Because the bank account onboarding / editing flow requires a live network connection, ReimbursementAccountPage.tsx mounts FullPageOfflineBlockingView. As a result, the user is permitted to click an interactive row offline only to immediately hit a blocking screen.
What changes do you think we should make in order to solve the problem?
In src/pages/workspace/workflows/tabs/WorkflowsPaymentsTab.tsx:
Define a helper condition indicating whether offline interaction is supported for the current bank account state (specifically, only when the business bank account is locked and the current user is the authorized reimburser):
Since the action button (e.g., "Finish" for SETUP status at line 320) already uses:
isActionDisabled={!canInteractWithBankAccountRow}
it will naturally become disabled when offline for non-locked accounts with no additional changes.
Add Unit Tests in tests/ui/WorkspaceWorkflowsPaymentsTest.tsx / WorkspaceWorkflowsLockedBankAccountTest.tsx:
Verify that when isOffline === true and the bank account is in SETUP status, the row has disabled: true, interactive: false, and pressing it does not trigger navigation.
Verify that when isOffline === true and the bank account is locked with isUserReimburser === true, the row remains interactive and correctly initiates the unlock flow.
What alternative solutions did you explore? (Optional)
Making ReimbursementAccountPage functional offline: Unfeasible because bank account setup involves third-party Plaid/Plaid-OAuth and Onfido identity verification, which strictly require active network communication. Disabling the entry row offline correctly matches user expectations and aligns with the adjacent "Add bank account" row (isAddBankAccountInert = isOffline || !canWritePayments).
Please re-state the problem that we are trying to solve in this issue.
In Workspace > Workflows > Payments, when a bank account is partially set up (displaying the "Incomplete" badge), clicking on the row while offline opens an RHP that fails with "You appear to be offline. This feature requires an active internet connection." The bank account row should be disabled/inert while offline.
What is the root cause of that problem?
In PR #101450, !isOffline was removed from WorkflowsPaymentsTab.tsx:
The intention of PR #101450 was to allow the reimburser to initiate an unlock request on a locked bank account while offline (state === CONST.BANK_ACCOUNT.STATE.LOCKED && isUserReimburser).
However, by removing !isOffline unconditionally across all bank account states, partially set up bank accounts (SETUP), open accounts, and pending accounts became interactive while offline. When clicked, they route to navigateToBankAccountRoute (ReimbursementAccountPage), which does not support offline setup and renders FullPageOfflineBlockingView.
What changes do you think we should make in order to solve the problem?
In src/pages/workspace/workflows/tabs/WorkflowsPaymentsTab.tsx:
Restore the offline check for all bank account states except when the account is locked and the user is the reimburser:
Because the "Finish" action button in ConnectionStatusMessage uses isActionDisabled={!canInteractWithBankAccountRow} (line 320), it will also be disabled while offline without requiring any redundant changes.
What alternative solutions did you explore? (Optional)
Check offline state inside handleBankAccountPress and prevent navigation, but disabling the row UI (disabled: true, interactive: false) correctly matches user expectations and aligns with how the adjacent Add bank account row behaves (isAddBankAccountInert = isOffline || !canWritePayments).
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: N/A. Because this isn't a regression from previous PRs. It looks like a gap that emerged while implementing several features, a case we missed considering among them
Link to the comment on the Issue: N/A
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Test:
Precondition: You are a workspace admin, and the workspace has a partly added bank account. To set this up, go to Workspace > Workflows > Payments, start adding a bank account, and exit the flow before you finish.
Go to Workspace > Workflows > Payments.
Verify the bank account row shows the "Incomplete" badge and a "Finish" button.
Go offline.
Verify the bank account row can't be pressed and the "Finish" button looks disabled.
Press the bank account row. Verify nothing opens, and you don't see "You appear to be offline. This feature requires an active internet connection."
Activity
applause-bot commentedon Sep 25, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/f07549ae13a0e49fa5a697e661edaf6b7f134b19260118f406fe7c59591b26b5
MelvinBot commentedon Sep 25, 2026
Proposal
Root cause (high confidence): Allow the workflows bank account row to be tapped while offline (
Expensify/App#101450, merged 2026-09-21) removed the offline check from the Workflows → Payments bank account row for every bank account state. Only the locked-account unlock request works offline. An "Incomplete" (SETUP) row now opens the bank account flow, and that flow is blocked offline.Please re-state the problem that we are trying to solve in this issue.
In Workspace → Workflows → Payments, a partly set up bank account row (with the "Incomplete" badge) can be clicked while offline. Clicking it opens an RHP that only says "You appear to be offline." The row should be disabled offline.
What is the root cause of that problem?
The row's press and disabled logic no longer looks at
isOffline:WorkflowsPaymentsTab.tsx:166:canInteractWithBankAccountRowchecks onlycanWritePaymentsand pending delete.WorkflowsPaymentsTab.tsx:255:disabledhas the same checks.Expensify/App#101450removedisOfflinefrom both lines to fix the locked-account case. The locked reimburser path queues an optimistic unlock request. Every other state, including SETUP, falls through tonavigateToBankAccountRouteinhandleBankAccountPress. When the user exits the flow mid-way, the reimbursement account data is cleared. Reopening it offline then showsFullPageOfflineBlockingView.What changes do you think we should make in order to solve the problem?
In
WorkflowsPaymentsTab.tsx, restore the offline check for all states except the locked account pressed by the reimburser:isOfflineis true and the account is not (isBusinessBankAccountLockedandisUserReimburser). Declare it before line 166.canInteractWithBankAccountRow(line 166) and todisabled(line 255).isActionDisabled={!canInteractWithBankAccountRow}(line 320). It will be disabled offline with no extra change.tests/ui/WorkspaceWorkflowsLockedBankAccountTest.tsxshould still pass.This matches the "Add bank account" row in the same file, which is already inert offline (line 167).
What alternative solutions did you explore? (Optional)
Expensify/App#101450. This would reopen [Due for payment 2026-10-01] [Exploratory] Wallet - Locked bank account isn't tapped on the workflow payments page while offline.ReimbursementAccountPageusable offline. This is a bigger change, and the flow needs server data.Investigation details
getBankAccountConnectionStatusforBANK_ACCOUNT.STATE.SETUP(BankAccountUtils.ts:72-80). Non-USD PENDING accounts get the same badge.!isOfflinefromcanInteractWithBankAccountRowandisOffline ||fromdisabled. Its own regression steps said SETUP, OPEN, and PENDING offline behavior should stay unchanged.Expensify/App#101450, and their press also lands on the offline-blocked page.Related issue: [Due for payment 2026-10-01] [Exploratory] Wallet - Locked bank account isn't tapped on the workflow payments page while offline. Its fix introduced this regression.
Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/102329)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
view run
melvin-bot commentedon Sep 25, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (
External)[-]BA-Bank account row with SETUP status is active and interactive while offline[/-][+][$175] BA-Bank account row with SETUP status is active and interactive while offline[/+]melvin-bot commentedon Sep 25, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022103540758661258223
Mateidslx commentedon Sep 25, 2026
Contributor details
Your Expensify account email: matei64200@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01b6f7f3d5061f49d9
Proposal
Please re-state the problem that we are trying to solve in this issue.
In Workspace > Workflows > Payments, a bank account row in
SETUPstatus (displaying the "Incomplete" badge) remains active and interactive while offline. Clicking the row or the "Finish" action opens the Reimbursement Account RHP, which immediately blocks the user with the "You appear to be offline. This feature requires an active internet connection" offline blocking view.What is the root cause of that problem?
In PR #101450 ("Allow the workflows bank account row to be tapped while offline"),
!isOfflinewas removed unconditionally fromWorkflowsPaymentsTab.tsx:While removing the offline guard was intended to allow the locked bank account unlock flow (which operates optimistically via
pressLockedBankAccountand navigates to Concierge chat), all other bank account states (includingSETUP,OPEN, andVERIFYING) fall through tonavigateToBankAccountRoute(lines 236–239).Because the bank account onboarding / editing flow requires a live network connection,
ReimbursementAccountPage.tsxmountsFullPageOfflineBlockingView. As a result, the user is permitted to click an interactive row offline only to immediately hit a blocking screen.What changes do you think we should make in order to solve the problem?
In
src/pages/workspace/workflows/tabs/WorkflowsPaymentsTab.tsx:Define a helper condition indicating whether offline interaction is supported for the current bank account state (specifically, only when the business bank account is locked and the current user is the authorized reimburser):
Use
canInteractWithBankAccountRowandisBankAccountRowDisabledfor thebankAccountMenuItemProps(lines 255–257):Since the action button (e.g., "Finish" for
SETUPstatus at line 320) already uses:it will naturally become disabled when offline for non-locked accounts with no additional changes.
Add Unit Tests in
tests/ui/WorkspaceWorkflowsPaymentsTest.tsx/WorkspaceWorkflowsLockedBankAccountTest.tsx:isOffline === trueand the bank account is inSETUPstatus, the row hasdisabled: true,interactive: false, and pressing it does not trigger navigation.isOffline === trueand the bank account is locked withisUserReimburser === true, the row remains interactive and correctly initiates the unlock flow.What alternative solutions did you explore? (Optional)
ReimbursementAccountPagefunctional offline: Unfeasible because bank account setup involves third-party Plaid/Plaid-OAuth and Onfido identity verification, which strictly require active network communication. Disabling the entry row offline correctly matches user expectations and aligns with the adjacent "Add bank account" row (isAddBankAccountInert = isOffline || !canWritePayments).melvin-bot commentedon Sep 25, 2026
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
fix(workflows): disable non-locked bank account row while offline (Ex…
ashusatyarthi-wq commentedon Sep 25, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
In Workspace > Workflows > Payments, when a bank account is partially set up (displaying the "Incomplete" badge), clicking on the row while offline opens an RHP that fails with "You appear to be offline. This feature requires an active internet connection." The bank account row should be disabled/inert while offline.
What is the root cause of that problem?
In PR #101450,
!isOfflinewas removed fromWorkflowsPaymentsTab.tsx:The intention of PR #101450 was to allow the reimburser to initiate an unlock request on a locked bank account while offline (
state === CONST.BANK_ACCOUNT.STATE.LOCKED && isUserReimburser).However, by removing
!isOfflineunconditionally across all bank account states, partially set up bank accounts (SETUP), open accounts, and pending accounts became interactive while offline. When clicked, they route tonavigateToBankAccountRoute(ReimbursementAccountPage), which does not support offline setup and rendersFullPageOfflineBlockingView.What changes do you think we should make in order to solve the problem?
In
src/pages/workspace/workflows/tabs/WorkflowsPaymentsTab.tsx:Restore the offline check for all bank account states except when the account is locked and the user is the reimburser:
And update
bankAccountMenuItemProps:Because the "Finish" action button in
ConnectionStatusMessageusesisActionDisabled={!canInteractWithBankAccountRow}(line 320), it will also be disabled while offline without requiring any redundant changes.What alternative solutions did you explore? (Optional)
Check offline state inside
handleBankAccountPressand prevent navigation, but disabling the row UI (disabled: true,interactive: false) correctly matches user expectations and aligns with how the adjacentAdd bank accountrow behaves (isAddBankAccountInert = isOffline || !canWritePayments).Verified Branch & Pre-tested Commit:
The implementation has been staged and verified on:
ashusatyarthi-wq/App:fix/offline-incomplete-ba-102329(Commitbad5518).ashusatyarthi-wq commentedon Sep 25, 2026
Contributor details
Your Expensify account email: ashusatyarthi@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~010e53044b5828fe60
20 remaining items
DylanDylann commentedon Oct 6, 2026
Contributor+ Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: N/A. Because this isn't a regression from previous PRs. It looks like a gap that emerged while implementing several features, a case we missed considering among them
Link to the comment on the Issue: N/A
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Test:
Precondition: You are a workspace admin, and the workspace has a partly added bank account. To set this up, go to Workspace > Workflows > Payments, start adding a bank account, and exit the flow before you finish.
Do we agree 👍 or 👎
melvin-bot commentedon Oct 11, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Oct 11, 2026
Payment Summary
Resolving PRs:
Disable the workspace bank account row offline unless the reimburser is unlocking a locked account #102839
Reviewer: @DylanDylann owed $175 via NewDot
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Oct 14, 2026
Payment Summary
Contributor+: @DylanDylann due $175 via NewDot
quinthar commentedon Oct 27, 2026
Approved $175 to @DylanDylann