Skip to content

[Due for payment 2026-10-12] [$175] BA-Bank account row with SETUP status is active and interactive while offline #102329

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: v9.4.94-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/75702438/folder/57527100/41236743/1798266868?sort=%2Bidentifier
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Windows 10 / Chrome
App Component: Other

Action Performed:

Precondition: Have partially added a BA

  1. Begin the process of adding a bank account but exit in the middle of it
  2. Disable the internet connection in the device
  3. Click on 'Bank account' with Incomplete badge button in workspace settings

Expected Result:

Verify you see the button inactive

Actual Result:

RHP is opened and shows "You appear to be offline.This feature requires an active internet connection."

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7269486_1790352770663.bandicam_2026-09-25_10-55-55-020_.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7269486

Upwork Automation - Do Not Edit
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 25, 2026
  2. applause-bot commented on Sep 25, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/f07549ae13a0e49fa5a697e661edaf6b7f134b19260118f406fe7c59591b26b5

  3. MelvinBot commented on Sep 25, 2026

    @MelvinBot
    Contributor

    Proposal

    Root cause (high confidence): Allow the workflows bank account row to be tapped while offline (Expensify/App#101450, merged 2026-09-21) removed the offline check from the Workflows → Payments bank account row for every bank account state. Only the locked-account unlock request works offline. An "Incomplete" (SETUP) row now opens the bank account flow, and that flow is blocked offline.

    Please re-state the problem that we are trying to solve in this issue.

    In Workspace → Workflows → Payments, a partly set up bank account row (with the "Incomplete" badge) can be clicked while offline. Clicking it opens an RHP that only says "You appear to be offline." The row should be disabled offline.

    What is the root cause of that problem?

    The row's press and disabled logic no longer looks at isOffline:

    Expensify/App#101450 removed isOffline from both lines to fix the locked-account case. The locked reimburser path queues an optimistic unlock request. Every other state, including SETUP, falls through to navigateToBankAccountRoute in handleBankAccountPress. When the user exits the flow mid-way, the reimbursement account data is cleared. Reopening it offline then shows FullPageOfflineBlockingView.

    What changes do you think we should make in order to solve the problem?

    In WorkflowsPaymentsTab.tsx, restore the offline check for all states except the locked account pressed by the reimburser:

    1. Add a flag that is true when isOffline is true and the account is not (isBusinessBankAccountLocked and isUserReimburser). Declare it before line 166.
    2. Add that flag to canInteractWithBankAccountRow (line 166) and to disabled (line 255).
    3. The "Finish" button uses isActionDisabled={!canInteractWithBankAccountRow} (line 320). It will be disabled offline with no extra change.
    4. Add a UI test: SETUP account, offline, the row and "Finish" are disabled and do not navigate. The existing tests/ui/WorkspaceWorkflowsLockedBankAccountTest.tsx should still pass.

    This matches the "Add bank account" row in the same file, which is already inert offline (line 167).

    What alternative solutions did you explore? (Optional)

    Investigation details
    • The "Incomplete" badge comes from getBankAccountConnectionStatus for BANK_ACCOUNT.STATE.SETUP (BankAccountUtils.ts:72-80). Non-USD PENDING accounts get the same badge.
    • The PR diff removed !isOffline from canInteractWithBankAccountRow and isOffline || from disabled. Its own regression steps said SETUP, OPEN, and PENDING offline behavior should stay unchanged.
    • The issue was reported on v9.4.94-0, after that PR was deployed.
    • Open question: the fix also disables OPEN and VERIFYING rows offline. That matches behavior before Expensify/App#101450, and their press also lands on the offline-blocked page.
    • I did not reproduce this in the browser. The conclusion is based on the code and the PR diff.

    Related issue: [Due for payment 2026-10-01] [Exploratory] Wallet - Locked bank account isn't tapped on the workflow payments page while offline. Its fix introduced this regression.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/102329) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.


    view run

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 25, 2026
  5. melvin-bot commented on Sep 25, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

  6. changed the title [-]BA-Bank account row with SETUP status is active and interactive while offline[/-] [+][$175] BA-Bank account row with SETUP status is active and interactive while offline[/+] on Sep 25, 2026
  7. melvin-bot commented on Sep 25, 2026

    @melvin-bot
  8. Mateidslx commented on Sep 25, 2026

    @Mateidslx

    Contributor details
    Your Expensify account email: matei64200@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~01b6f7f3d5061f49d9

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    In Workspace > Workflows > Payments, a bank account row in SETUP status (displaying the "Incomplete" badge) remains active and interactive while offline. Clicking the row or the "Finish" action opens the Reimbursement Account RHP, which immediately blocks the user with the "You appear to be offline. This feature requires an active internet connection" offline blocking view.

    What is the root cause of that problem?

    In PR #101450 ("Allow the workflows bank account row to be tapped while offline"), !isOffline was removed unconditionally from WorkflowsPaymentsTab.tsx:

    • Line 166:
      const canInteractWithBankAccountRow = canWritePayments && !isBankAccountPendingDelete;
    • Lines 255–257:
      disabled: !canWritePayments || isBankAccountPendingDelete,
      shouldShowRightIcon: canWritePayments && !isBankAccountPendingDelete,
      interactive: canWritePayments && !isBankAccountPendingDelete,

    While removing the offline guard was intended to allow the locked bank account unlock flow (which operates optimistically via pressLockedBankAccount and navigates to Concierge chat), all other bank account states (including SETUP, OPEN, and VERIFYING) fall through to navigateToBankAccountRoute (lines 236–239).

    Because the bank account onboarding / editing flow requires a live network connection, ReimbursementAccountPage.tsx mounts FullPageOfflineBlockingView. As a result, the user is permitted to click an interactive row offline only to immediately hit a blocking screen.

    What changes do you think we should make in order to solve the problem?

    In src/pages/workspace/workflows/tabs/WorkflowsPaymentsTab.tsx:

    1. Define a helper condition indicating whether offline interaction is supported for the current bank account state (specifically, only when the business bank account is locked and the current user is the authorized reimburser):

      const canInteractOffline = isBusinessBankAccountLocked && isUserReimburser;
      const isBankAccountRowDisabled = !canWritePayments || isBankAccountPendingDelete || (isOffline && !canInteractOffline);
      const canInteractWithBankAccountRow = !isBankAccountRowDisabled;
    2. Use canInteractWithBankAccountRow and isBankAccountRowDisabled for the bankAccountMenuItemProps (lines 255–257):

      -    disabled: !canWritePayments || isBankAccountPendingDelete,
      -    shouldShowRightIcon: canWritePayments && !isBankAccountPendingDelete,
      -    interactive: canWritePayments && !isBankAccountPendingDelete,
      +    disabled: isBankAccountRowDisabled,
      +    shouldShowRightIcon: canInteractWithBankAccountRow,
      +    interactive: canInteractWithBankAccountRow,
    3. Since the action button (e.g., "Finish" for SETUP status at line 320) already uses:

      isActionDisabled={!canInteractWithBankAccountRow}

      it will naturally become disabled when offline for non-locked accounts with no additional changes.

    4. Add Unit Tests in tests/ui/WorkspaceWorkflowsPaymentsTest.tsx / WorkspaceWorkflowsLockedBankAccountTest.tsx:

      • Verify that when isOffline === true and the bank account is in SETUP status, the row has disabled: true, interactive: false, and pressing it does not trigger navigation.
      • Verify that when isOffline === true and the bank account is locked with isUserReimburser === true, the row remains interactive and correctly initiates the unlock flow.

    What alternative solutions did you explore? (Optional)

    • Making ReimbursementAccountPage functional offline: Unfeasible because bank account setup involves third-party Plaid/Plaid-OAuth and Onfido identity verification, which strictly require active network communication. Disabling the entry row offline correctly matches user expectations and aligns with the adjacent "Add bank account" row (isAddBankAccountInert = isOffline || !canWritePayments).
  9. melvin-bot commented on Sep 25, 2026

    @melvin-bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  10. ashusatyarthi-wq commented on Sep 25, 2026

    @ashusatyarthi-wq

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    In Workspace > Workflows > Payments, when a bank account is partially set up (displaying the "Incomplete" badge), clicking on the row while offline opens an RHP that fails with "You appear to be offline. This feature requires an active internet connection." The bank account row should be disabled/inert while offline.


    What is the root cause of that problem?

    In PR #101450, !isOffline was removed from WorkflowsPaymentsTab.tsx:

    const canInteractWithBankAccountRow = canWritePayments && !isBankAccountPendingDelete;
    ...
    disabled: !canWritePayments || isBankAccountPendingDelete,
    shouldShowRightIcon: canWritePayments && !isBankAccountPendingDelete,
    interactive: canWritePayments && !isBankAccountPendingDelete,

    The intention of PR #101450 was to allow the reimburser to initiate an unlock request on a locked bank account while offline (state === CONST.BANK_ACCOUNT.STATE.LOCKED && isUserReimburser).

    However, by removing !isOffline unconditionally across all bank account states, partially set up bank accounts (SETUP), open accounts, and pending accounts became interactive while offline. When clicked, they route to navigateToBankAccountRoute (ReimbursementAccountPage), which does not support offline setup and renders FullPageOfflineBlockingView.


    What changes do you think we should make in order to solve the problem?

    In src/pages/workspace/workflows/tabs/WorkflowsPaymentsTab.tsx:
    Restore the offline check for all bank account states except when the account is locked and the user is the reimburser:

    const isBankAccountInert = !canWritePayments || isBankAccountPendingDelete || (isOffline && !(isBusinessBankAccountLocked && isUserReimburser));
    const canInteractWithBankAccountRow = !isBankAccountInert;

    And update bankAccountMenuItemProps:

    disabled: isBankAccountInert,
    shouldShowRightIcon: !isBankAccountInert,
    interactive: !isBankAccountInert,

    Because the "Finish" action button in ConnectionStatusMessage uses isActionDisabled={!canInteractWithBankAccountRow} (line 320), it will also be disabled while offline without requiring any redundant changes.


    What alternative solutions did you explore? (Optional)

    Check offline state inside handleBankAccountPress and prevent navigation, but disabling the row UI (disabled: true, interactive: false) correctly matches user expectations and aligns with how the adjacent Add bank account row behaves (isAddBankAccountInert = isOffline || !canWritePayments).


    Verified Branch & Pre-tested Commit:

    The implementation has been staged and verified on:
    ashusatyarthi-wq/App:fix/offline-incomplete-ba-102329 (Commit bad5518).

  11. ashusatyarthi-wq commented on Sep 25, 2026

    @ashusatyarthi-wq

    Contributor details
    Your Expensify account email: ashusatyarthi@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~010e53044b5828fe60

  12. 20 remaining items

  13. DylanDylann commented on Oct 6, 2026

    @DylanDylann
    Contributor

    Contributor+ Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR: N/A. Because this isn't a regression from previous PRs. It looks like a gap that emerged while implementing several features, a case we missed considering among them
      Link to the comment on the Issue: N/A

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Test:

    Precondition: You are a workspace admin, and the workspace has a partly added bank account. To set this up, go to Workspace > Workflows > Payments, start adding a bank account, and exit the flow before you finish.

    1. Go to Workspace > Workflows > Payments.
    2. Verify the bank account row shows the "Incomplete" badge and a "Finish" button.
    3. Go offline.
    4. Verify the bank account row can't be pressed and the "Finish" button looks disabled.
    5. Press the bank account row. Verify nothing opens, and you don't see "You appear to be offline. This feature requires an active internet connection."
    6. The Finish button is disabled
    7. Press "Finish". Verify nothing opens.

    Do we agree 👍 or 👎

  14. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Oct 6, 2026
  15. melvin-bot commented on Oct 11, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  16. melvin-bot commented on Oct 11, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  17. mallenexpensify commented on Oct 14, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @DylanDylann due $175 via NewDot

  18. quinthar commented on Oct 27, 2026

    @quinthar
    Contributor

    Approved $175 to @DylanDylann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions