Repository navigation
Closed
Labels
MonthlyKSv2KSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Description
Release Version: 1.2.38-6
Compare Changes: production...staging
This release contains changes from the following pull requests:
- fix composer hidden while loading messages #12505
- Refactor
payIOU#12739 - Fix: Offline default avatar doesn't update after connecting to the internet #12808
- Fix border radii #13214
- Reduce the room name length const #13325
- Update presentation of Card Menu Items #13342
- Update picker items #13375
- [No QA] Add new checklist item to use ScrollView in new page components #13388
- fix: minor restyle password protection pdf form #13390
- Fix copy and paste text inconsistent on mWeb #13396
- Improve performance of optionslist #13398
- navigate to workspaces page on back button press #13402
- [Hold for payment 2022-12-20] [$1000] Add created to MarkAsUnread and ReadNewestAction #13404
- Fix failed to load PDF error color and translation #13409
- Fix incorporation date error #13420
- Higher initial number to render #13425
- Remove
/from placeholder #13441 - fix "Upload photo" popup menu not hiding #13448
- Remove extra flex from style #13475
- Add tooltip for currency picker button #13476
- Revert "fix composer hidden while loading messages" #13482
- Stop displaying Closed Account message when the user starts typing #13519
- Check hasOutstandingIOU in money requests #13522
- Flatten styles to avoid crash #13525
- fix button position #13530
- Report can be a {}, improve check for emptyness/falsey #13531
- fix error message style issue on OfflineWithFeedback #13535
Deploy Blockers:
- [HOLD for payment 2022-12-22][$1000] Workspace - general settings -
SaveButton is not at the bottom #13488 - [HOLD on regression test ] Workspace - Crash when removing a user offline in Manage members #13508
- [HOLD for payment 2022-12-22]Chat - The text of the error message is not centered #13510
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.
cc @Expensify/applauseleads
Metadata
Metadata
Assignees
Labels
MonthlyKSv2KSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Activity
OSBotify commentedon Dec 10, 2022
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.38-0 🚀
mvtglobally commentedon Dec 12, 2022
@chiragsalian @francoisl Regression is completed
Deploy Blockers
#13508
#13506
#13509
#13510
#13511
PRs
PR #13396 is failing #13507. Repro in PROD checking off
Last PR pending #12808. We are validating and I will update in a bit
chiragsalian commentedon Dec 12, 2022
Awesome, thank you. We'll tackle the deploy blockers shortly.
mvtglobally commentedon Dec 13, 2022
Checking off #12808.
mvtglobally commentedon Dec 13, 2022
@chiragsalian I am seeing new App versions released, but this page checklist is not updated.
Do you have a list of PRs we are good to retest now?
mvtglobally commentedon Dec 13, 2022
@chiragsalian the following CPs are PASS. not sure why they are not added to checklist
#13519
#13531
#13522
chiragsalian commentedon Dec 13, 2022
Awesome thank you, i was just about to post. I'm going through the list now too.
mvtglobally commentedon Dec 13, 2022
Let me know if any other CPs need to be checked
chiragsalian commentedon Dec 13, 2022
Yes can you test #13535
chiragsalian commentedon Dec 13, 2022
Making a list of deploy blockers for myself to track,
SaveButton is not at the bottom #13488 (QA is testing PR)chiragsalian commentedon Dec 13, 2022
Can you also test #13530
OSBotify commentedon Dec 13, 2022
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.2.38-6🚀mvtglobally commentedon Dec 13, 2022
@chiragsalian
#13530 is Pass
#13535 is seems pass too, but we just want to clarify Desktop stuff #13535 (comment)
chiragsalian commentedon Dec 13, 2022
Checking comment, meanwhile this CP is also ready to be tested - #13525
chiragsalian commentedon Dec 13, 2022
I replied to your #13535 (comment).
OSBotify commentedon Dec 13, 2022
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.38-6 has been deployed to staging 🎉
chiragsalian commentedon Dec 13, 2022
@mvtglobally, any update wrt testing #13525, or when can we expect it to be done? Asking cause its the last blocker and then we can do a deploy here.
mvtglobally commentedon Dec 13, 2022
@chiragsalian
It took some time to get the build.
Its pass on all platforms, but we have this clarification. It doesnt seem PR related and we are digging through known issues Avatar image become grey for a moment when switching between pages
13525.iOS.mp4
chiragsalian commentedon Dec 13, 2022
As discussed on slack the issue mentioned above is occurring only on andoird. Could you create a follow up GH issue for that @mvtglobally?
chiragsalian commentedon Dec 13, 2022