Skip to content

Deploy Checklist: New Expensify 2022-12-09 #13498

Closed

Description

@francoisl

Release Version: 1.2.38-6
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

Activity

  1. OSBotify commented on Dec 10, 2022

    @OSBotify
    Contributor

    🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.38-0 🚀

  2. mvtglobally commented on Dec 12, 2022

    @mvtglobally

    @chiragsalian @francoisl Regression is completed

    Deploy Blockers
    #13508
    #13506
    #13509
    #13510
    #13511

    PRs
    PR #13396 is failing #13507. Repro in PROD checking off
    Last PR pending #12808. We are validating and I will update in a bit

  3. chiragsalian commented on Dec 12, 2022

    @chiragsalian
    Contributor

    Awesome, thank you. We'll tackle the deploy blockers shortly.

  4. mvtglobally commented on Dec 13, 2022

    @mvtglobally

    Checking off #12808.

  5. mvtglobally commented on Dec 13, 2022

    @mvtglobally

    @chiragsalian I am seeing new App versions released, but this page checklist is not updated.
    Do you have a list of PRs we are good to retest now?

  6. mvtglobally commented on Dec 13, 2022

    @mvtglobally

    @chiragsalian the following CPs are PASS. not sure why they are not added to checklist
    #13519
    #13531
    #13522

  7. chiragsalian commented on Dec 13, 2022

    @chiragsalian
    Contributor

    Awesome thank you, i was just about to post. I'm going through the list now too.

  8. mvtglobally commented on Dec 13, 2022

    @mvtglobally

    Let me know if any other CPs need to be checked

  9. chiragsalian commented on Dec 13, 2022

    @chiragsalian
    Contributor

    Yes can you test #13535

  10. deleted a comment from melvin-bot on Dec 13, 2022
  11. chiragsalian commented on Dec 13, 2022

    @chiragsalian
    Contributor

    Can you also test #13530

  12. OSBotify commented on Dec 13, 2022

    @OSBotify
    Contributor

    👏 Heads up @Expensify/applauseleads 👏
    A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.38-6 🚀

  13. mvtglobally commented on Dec 13, 2022

    @mvtglobally

    @chiragsalian
    #13530 is Pass
    #13535 is seems pass too, but we just want to clarify Desktop stuff #13535 (comment)

  14. chiragsalian commented on Dec 13, 2022

    @chiragsalian
    Contributor

    Checking comment, meanwhile this CP is also ready to be tested - #13525

  15. chiragsalian commented on Dec 13, 2022

    @chiragsalian
    Contributor

    I replied to your #13535 (comment).

  16. OSBotify commented on Dec 13, 2022

    @OSBotify
    Contributor

    🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.38-6 has been deployed to staging 🎉

  17. chiragsalian commented on Dec 13, 2022

    @chiragsalian
    Contributor

    @mvtglobally, any update wrt testing #13525, or when can we expect it to be done? Asking cause its the last blocker and then we can do a deploy here.

  18. mvtglobally commented on Dec 13, 2022

    @mvtglobally

    @chiragsalian
    It took some time to get the build.
    Its pass on all platforms, but we have this clarification. It doesnt seem PR related and we are digging through known issues Avatar image become grey for a moment when switching between pages

    13525.iOS.mp4
  19. chiragsalian commented on Dec 13, 2022

    @chiragsalian
    Contributor

    As discussed on slack the issue mentioned above is occurring only on andoird. Could you create a follow up GH issue for that @mvtglobally?

  20. chiragsalian commented on Dec 13, 2022

    @chiragsalian
    Contributor

    :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions