Repository navigation
Closed
Labels
MonthlyKSv2KSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Description
Release Version: 1.4.16-5
Compare Changes: production...staging
This release contains changes from the following pull requests:
- [TS Migration] Migrate 'withReportAndReportActionOrNotFound.js' HOC to TypeScript #29996
- Subscribe transactions in report preview #32469
- Ideal nav LHP #32473
- Android-BA-Tapping connect online with plaid shows 2 spin circles loading #32641
- [TS migration] Migrate 'AnchorForCommentsOnly' component to TypeScript #32670
- Create Cancel Payment command #32674
- fix older safari launch app issue #33238
- Fix: focusing on item by tab key does not work #33265
- Hide add receipt placeholder if the user isn't allowed add a receipt #33273
- test: add support for transitionEnd event in unit tests #33285
- Fix: no space between 3 dots and admin #33293
- fix: Settings - Focus shifts to first digit on shortcut & back. #33366
- Update Admin-Card-Settings-and-Features.md #33382
- [HelpDot documentation] How-to guide and update documentation #33407
- Update Expensify-Playbook-For-Small-To-Medium-Sized-Businesses.md #33463
- [CP Staging] Revert "fix: treat certain US numbers as invalid" #33496
- [CP Staging] Revert "Create Cancel Payment command" #33569
Deploy Blockers:
- [$500] BA - Unable to connect bank account. Validation page appears at the end of connection flow. #33488
- [HOLD for payment 2024-01-26] [HOLD for payment 2024-01-25] Cancel payment - Message for cancelation is not copied and "owes" message is copied as "paid" #33507
- Cancel payment - IOU preview and report title display "Canceled" when canceled payment is repaid #33508
- [HOLD for payment 2024-01-26] [HOLD for payment 2024-01-25] Cancel payment - IOU is still marked as paid when payment is canceled unless report is revisited #33509
- [HOLD for payment 2024-01-25] [HOLD for payment 2024-01-03] Expense - Expense preview with a manual and ongoing scan does not show "x request, y scanning" #33512
- [$125] Cancel payment - "Cancel payment" in three-dot menu is not translated to Spanish #33513
- [HOLD for payment 2024-01-26] [HOLD for payment 2024-01-25] Cancel payment-Add receipt and Delete request options are present after canceling Send money payment #33517
- Cancel payment - "Auth CancelReimbursement" error shows up when cancelling payment with Expensify #33540
- [$500] IOU - All of the IOU chats disappear when I do the same IOU and turn the connection on #33543
- [$500] [MEDIUM] LHN - Green dot(IOU) disappears from WS conversation in LHN when going offline-online #33544
- [$500] mWeb/Safari - Workspace - Expensify site is visible while doing the Plaid bank account steps #33556
- Workspace - Sensitive information is visible when deleting a workspace and creating a new #33557
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Metadata
Metadata
Assignees
Labels
MonthlyKSv2KSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Activity
OSBotify commentedon Dec 22, 2023
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.16-3 🚀
rlinoz commentedon Dec 22, 2023
#33512 is fixed here in this PR #33516
Asked for CP here
kavimuru commentedon Dec 22, 2023
Regression is 60% progress.
#29996 failing with #33518 reproduced in PROD checking it off
#32473 failing with #33511, it is reverted #33406 - OK to check it off?
#32641 failing with #32298, not fixed in Desktop - Ok to check it off?
kavimuru commentedon Dec 23, 2023
Regression is just 1% left.
#32674 failing with #33540
kavimuru commentedon Dec 24, 2023
Regression is completed.
#33238 failing with #33551 repro in PROD - checking it off
Unchecked PRs:
#32473 failing with #33511, it is reverted #33406 - OK to check it off?
#32641 failing with #32298, not fixed in Desktop - Ok to check it off?
#32674 failing with #33540
Open Blockers:
#33507
#33509
#33512
#33517
#33540
#33543
#33544
#33556
#33557
mountiny commentedon Dec 25, 2023
Checking #32473 off as it was reverted
#32641 checking off, desktop not a blocker, noted on the relevant GH
mountiny commentedon Dec 25, 2023
Reverting #32674 to fix bunch of the deploy blockers
mountiny commentedon Dec 25, 2023
#33544 demoted happening in prod too
mountiny commentedon Dec 25, 2023
#33543 demoted as happening in prod and edge case
mountiny commentedon Dec 25, 2023
Checking of the last blocker #33512 as it has been fixed in main but I dont think its major enough to require a CP.
All deploy blockers are checked off and we only need to CP the straight revert and then we can deploy
mountiny commentedon Dec 26, 2023