Skip to content

Deploy Checklist: New Expensify 2023-12-22 #33480

Closed

Description

@github-actions

Release Version: 1.4.16-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

Activity

  1. OSBotify commented on Dec 22, 2023

    @OSBotify
    Contributor

    🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.16-3 🚀

  2. rlinoz commented on Dec 22, 2023

    @rlinoz
    Contributor

    #33512 is fixed here in this PR #33516

    Asked for CP here

  3. kavimuru commented on Dec 22, 2023

    @kavimuru

    Regression is 60% progress.

    #29996 failing with #33518 reproduced in PROD checking it off
    #32473 failing with #33511, it is reverted #33406 - OK to check it off?
    #32641 failing with #32298, not fixed in Desktop - Ok to check it off?

  4. kavimuru commented on Dec 23, 2023

    @kavimuru

    Regression is just 1% left.
    #32674 failing with #33540

  5. kavimuru commented on Dec 24, 2023

    @kavimuru

    Regression is completed.

    #33238 failing with #33551 repro in PROD - checking it off

    Unchecked PRs:
    #32473 failing with #33511, it is reverted #33406 - OK to check it off?
    #32641 failing with #32298, not fixed in Desktop - Ok to check it off?
    #32674 failing with #33540

    Open Blockers:
    #33507
    #33509
    #33512
    #33517
    #33540
    #33543
    #33544
    #33556
    #33557

  6. mountiny commented on Dec 25, 2023

    @mountiny
    Contributor

    Checking #32473 off as it was reverted

    #32641 checking off, desktop not a blocker, noted on the relevant GH

  7. mountiny commented on Dec 25, 2023

    @mountiny
    Contributor

    Reverting #32674 to fix bunch of the deploy blockers

  8. mountiny commented on Dec 25, 2023

    @mountiny
    Contributor

    #33544 demoted happening in prod too

  9. mountiny commented on Dec 25, 2023

    @mountiny
    Contributor

    #33543 demoted as happening in prod and edge case

  10. mountiny commented on Dec 25, 2023

    @mountiny
    Contributor

    Checking of the last blocker #33512 as it has been fixed in main but I dont think its major enough to require a CP.

    All deploy blockers are checked off and we only need to CP the straight revert and then we can deploy

  11. self-assigned this
    on Dec 25, 2023
  12. mountiny commented on Dec 26, 2023

    @mountiny
    Contributor

    :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions