You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-08-29] [Due for payment 2025-08-22] [Due for payment 2025-08-19] [Due for payment 2025-08-15] [$500] Add a reimbursable toggle on the expense form in New Expensify #58588
I HAVE UPDATED THIS OP TO ACCOUNT FOR ALL THE PLANNING DISCUSSIONS THAT TOOK PLACE ON THE ISSUE, THIS IS ALL YOU NEED TO READ FOR YOUR PROPOSAL:
Add reimbursable toggle on the expense form, similar to how the Billable toggle displays when enabled.
The placement for this toggle should be after all expense fields but before the billable toggle, so:
- Expense fields
- Reimbursable toggle
- Billable toggle
The Reimbursable toggle should be enabled by default if no credit cards are connected (more details below)
- An imported card transaction is non-reimbursable and cannot be changed, so the toggle should not be displayed at all on card transactions (like OldDot).
- The toggle should only be displayed on expenses you create to submit to a workspace, as it's a workspace feature. (e.g don't show it on expenses you submit to a friend in a DM).
- The toggle should abide by the same permission logic as the date and amount fields when it comes to editing, which I believe is as follows:
- Submitter: can't edit the toggle on processing reports after first level approval.
- Non-admin manager: can't edit the toggle after they've approved (i.e no longer the report's managerID)
- Admins: can't edit the toggle if it's on a report in the approved, reimbursed or closed state.
Then for cross-platform consistency we'll want to include the following instructions:
If Default reimbursable is set via OldDot, show the toggle enabled by default on expense creation.
If Default non-reimbursable is set via OldDot, show the toggle disabled by default on expense creation.
If Always non-reimbursable is set via OldDot, don't show the toggle at all and create the cash expense as non-reimbursable.
If Always reimbursable is set via OldDot, don't show the toggle at all and create the cash expense as reimbursable.
cc @Expensify/design in case you have any additional input you want to share.
changed the title [-]Add a non-reimbursable toggle on the expense form in New Expensify[/-][+][$250] Add a non-reimbursable toggle on the expense form in New Expensify[/+]on Mar 18, 2025
Approve the report and verify that the expense no longer has the reimbursable toggle
@getusha is that right? Why would the reimbursable toggle "disappear" on a cash expense that's marked as non-reimbursable? 🤔 I would think it's there, but set to non-reimbursable given the steps you executed before it.
Additionally, some of these steps are pretty sloppy tbh.
Imported company card expense
Go to Workspace Settings > Domains > [Domain Name] > Company Cards.
Import a company card expense
Verify that the expense defaults to non-reimbursable
Mark all the expenses on a report as non-reimbursable, verify that
Verify that the Pay button disappears for the payer side
Verify that the system message updates to: No further action required
I think we can tighten this one up, and it doesn't quite make sense to me:
Add a card feed in NewDot not OldDot, seems unnecessary
I don't know why in step 4 you're instructing to mark expenses as non-reimbursable, they should be set like that already. Suggested edit:
You mean "next steps" not "system message" for step 7, but I think it's redundant unless you give a lot more instructions for the workspace setup and state of the report they're on, so I'll omit that.
Editing that to:
Imported company card expense
Go to Workspaces > [Click a workspace] > Company Cards > Add a card feed.
Import some company card expense
Verify that the expense defaults to non-reimbursable
Verify the reimbursable toggle doesn't appear on the imported card transactions
Undo close
Disable approval and delayed submissions.
Create an expense with reimbursable disabled.
Click more -> Undo close.
Verify that The reimbursable toggle is enabled.
The button is called "Retract" in NewDot now, please make sure to check your steps to be accurate with production.
What I think you're testing (locked for editing in the closed state) isn't super clear.
Editing that to:
Retract
Disable approval and delayed submissions.
Create an expense
On the confirmation screen disable the reimbursable toggle > Confirm
After creation, verify the reimbursable toggle is locked for editing.
Click More -> Retract.
Verify the reimbursable toggle is no longer locked for editing.
Control workspace
Go to the workspace settings > Rules
Verify there is reimbursable settings under Rules - "Cash expense default"
Update the default option to non-reimbursable
Verify that the expense form is defaulted to non-reimbursable
Update the default option to always reimbursable
Verify that the expense form updated to always reimbursable
Update the default option to always non-reimbursable
Verify that the expense form has been updated to never reimbursable
Per the OP:
If Always non-reimbursable is set via OldDot, don't show the toggle at all and create the cash expense as non-reimbursable.
If Always reimbursable is set via OldDot, don't show the toggle at all and create the cash expense as reimbursable.
Your steps don't actually test for those. For example, what does it mean to a tester to "verify that the expense form has been updated to never reimbursable"?
Editing that one to:
Control workspace
Go to the workspace settings > Rules
Verify there is reimbursable settings under Rules - "Cash expense default"
Update the default option to non-reimbursable
Verify that the toggle on the expense form is defaulted to non-reimbursable
Update the default option to always reimbursable
Verify that there isn't a toggle on the expense form and the expense is created as a reimbursable expense
Update the default option to always non-reimbursable
Verify that there isn't a toggle on the expense form and the expense is created as a non-reimbursable expense
No workspace
Create an expense outside of a workspace
Verify that we don't display the reimbursable toggle
Create an expense outside of a workspace and select to submit to yourself
Verify that reimbursable toggle should not appear for p2p expense on the confirmation page.
In the Self-DM select categorize it or share with my accountant
Verify that the reimbursable toggle is visible
[Collect workspace] Verify that reimbursable is enabled by default
Again, just not very clear:
"outside of a workspace" where? DM? SelfDM? Mars? 😅
Some steps seem repetitive
"Categorize it" isn't on prod for customers at large anymore
I'll edit this one to focus on the P2P stuff, as unreported expenses in the selfDM is coming elsewhere to facilitate using coding of the default workspace.
No workspace
Go to global create > create expense
Enter an amount
Choose an individual
Verify that we don't display the reimbursable toggle on the confirmation screen
Confirm and create the expense
Go to the DM > click into the expense
Verify that we don't display the reimbursable toggle on the expense form
Activity
melvin-bot commentedon Mar 18, 2025
Current assignee @flaviadefaria is eligible for the NewFeature assigner, not assigning anyone new.
melvin-bot commentedon Mar 18, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021902042013735835234
[-]Add a non-reimbursable toggle on the expense form in New Expensify[/-][+][$250] Add a non-reimbursable toggle on the expense form in New Expensify[/+]melvin-bot commentedon Mar 18, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (
External)186 remaining items
trjExpensify commentedon Oct 6, 2025
@getusha where are you at with that?
getusha commentedon Oct 7, 2025
I will post today!
getusha commentedon Oct 8, 2025
Regression Test Proposal
Collect workspace
+> Create expensenon-reimbursableand is not payable from the payer sidechanged the expense to "non-reimbursable" (previously "reimbursable")Imported company card expense
No further action requiredUndo close
Control workspace
No workspace
Do we agree 👍 or 👎
trjExpensify commentedon Oct 13, 2025
@getusha is that right? Why would the reimbursable toggle "disappear" on a cash expense that's marked as non-reimbursable? 🤔 I would think it's there, but set to non-reimbursable given the steps you executed before it.
Additionally, some of these steps are pretty sloppy tbh.
I think we can tighten this one up, and it doesn't quite make sense to me:
Editing that to:
Editing that to:
Per the OP:
Always non-reimbursableis set via OldDot, don't show the toggle at all and create the cash expense as non-reimbursable.Always reimbursableis set via OldDot, don't show the toggle at all and create the cash expense as reimbursable.Your steps don't actually test for those. For example, what does it mean to a tester to "verify that the expense form has been updated to never reimbursable"?
Editing that one to:
Again, just not very clear:
I'll edit this one to focus on the P2P stuff, as unreported expenses in the selfDM is coming elsewhere to facilitate using coding of the default workspace.
No workspace
trjExpensify commentedon Oct 13, 2025
Payment summary as follows:
trjExpensify commentedon Oct 13, 2025
Closing!
getusha commentedon Oct 14, 2025
Thanks for all the updates and feedback! I copied the steps since QA had already tested them, I should've verified and made them clearer.
twisterdotcom commentedon Oct 16, 2025
@getusha has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
Zapier Logs
Run ID: 00040eee-6de7-aeba-88ca-0da6fa639f11