Skip to content

[Due for payment 2025-08-29] [Due for payment 2025-08-22] [Due for payment 2025-08-19] [Due for payment 2025-08-15] [$500] Add a reimbursable toggle on the expense form in New Expensify #58588

Closed

Description

@flaviadefaria

I HAVE UPDATED THIS OP TO ACCOUNT FOR ALL THE PLANNING DISCUSSIONS THAT TOOK PLACE ON THE ISSUE, THIS IS ALL YOU NEED TO READ FOR YOUR PROPOSAL:


  • Add reimbursable toggle on the expense form, similar to how the Billable toggle displays when enabled.
Image
  • The placement for this toggle should be after all expense fields but before the billable toggle, so:
    - Expense fields
    - Reimbursable toggle
    - Billable toggle

  • The Reimbursable toggle should be enabled by default if no credit cards are connected (more details below)
    - An imported card transaction is non-reimbursable and cannot be changed, so the toggle should not be displayed at all on card transactions (like OldDot).
    - The toggle should only be displayed on expenses you create to submit to a workspace, as it's a workspace feature. (e.g don't show it on expenses you submit to a friend in a DM).
    - The toggle should abide by the same permission logic as the date and amount fields when it comes to editing, which I believe is as follows:
    - Submitter: can't edit the toggle on processing reports after first level approval.
    - Non-admin manager: can't edit the toggle after they've approved (i.e no longer the report's managerID)
    - Admins: can't edit the toggle if it's on a report in the approved, reimbursed or closed state.

Then for cross-platform consistency we'll want to include the following instructions:

  1. If Default reimbursable is set via OldDot, show the toggle enabled by default on expense creation.
  2. If Default non-reimbursable is set via OldDot, show the toggle disabled by default on expense creation.
  3. If Always non-reimbursable is set via OldDot, don't show the toggle at all and create the cash expense as non-reimbursable.
  4. If Always reimbursable is set via OldDot, don't show the toggle at all and create the cash expense as reimbursable.

cc @Expensify/design in case you have any additional input you want to share.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021902042013735835234
  • Upwork Job ID: 1902042013735835234
  • Last Price Increase: 2025-06-23
  • Automatic offers:
    • daledah | Contributor | 106681987
Issue OwnerCurrent Issue Owner: @flaviadefaria

Adding here the list of issues that need to be fixed with a new PR:

Issue Frontend/Backend Status
No toggle for reimbursement when sharing expense with accountant Frontend 🔴 Not started
Reimbursable toggle is enabled in invoice thread when it is disabled on confirm page Frontend 🔴 Not started
Reimbursable toggle is shown for p2p expense when creating expense from iou report Frontend 🔴 Not started
Reimbursable is enabled in transaction thread when it is disabled on confirmation page Frontend - Perhaps bug is unique due to offline mode 🔴 Not started
Reimbursable toggle is disabled for new members by default Potentially Backend - To investigate 🔴 Not started
Pay button does not disappear after disabling Reimbursable in offline mode Frontend 🔴 Not started
Reimbursable toggle is disabled when it is enabled on confirm page when categorizing expense Potentially Frontend issue with optimistic updates - To investigate 🔴 Not started
"Waiting for you to pay expense" still seen after disabling "Reimbursable" option Frontend - Similar to issue 4 above 🔴 Not started

Keys:
🔴 Not started
🟡 In Progress
🟢 Completed

Activity

  1. melvin-bot commented on Mar 18, 2025

    @melvin-bot

    Current assignee @flaviadefaria is eligible for the NewFeature assigner, not assigning anyone new.

  2. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed on Mar 18, 2025
  3. melvin-bot commented on Mar 18, 2025

    @melvin-bot
  4. changed the title [-]Add a non-reimbursable toggle on the expense form in New Expensify[/-] [+][$250] Add a non-reimbursable toggle on the expense form in New Expensify[/+] on Mar 18, 2025
  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 18, 2025
  6. melvin-bot commented on Mar 18, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

  7. 186 remaining items

  8. trjExpensify commented on Oct 6, 2025

    @trjExpensify
    Contributor

    @getusha where are you at with that?

  9. getusha commented on Oct 7, 2025

    @getusha
    Contributor

    I will post today!

  10. getusha commented on Oct 8, 2025

    @getusha
    Contributor

    Regression Test Proposal

    Collect workspace

    1. Navigate to the policy expense chat
    2. + > Create expense
    3. The expense should display the reimbursable toggle above the report name in the expense form
    4. Verify that the expense defaults to reimbursable enabled
    5. Update the reimbursable toggle in the Details Confirmation page
    6. Verify the expense switches to non-reimbursable and is not payable from the payer side
    7. Verify the expense continues to display as non-reimbursable also in the expense preview page
    8. Edit an open expense to switch the reimbursable status
    9. Verify that the expense preview page from the payer side updates following the new change
    10. Verify a new system message appears when the toggle is updated e.g. changed the expense to "non-reimbursable" (previously "reimbursable")
    11. Approve the report and verify that:
    12. Verify that the expense no longer has the reimbursable toggle

    Imported company card expense

    1. Go to Workspace Settings > Domains > [Domain Name] > Company Cards.
    2. Import a company card expense
    3. Verify that The expense defaults to non-reimbursable
    4. Mark all the expenses on a report as non-reimbursable, verify that
    5. Verify that the Pay button disappears for the payer side
    6. Verify that the system message updates to: No further action required

    Undo close

    1. Disable approval and delayed submissions.
    2. Create an expense with reimbursable disabled.
    3. Click more -> Undo close.
    4. Verify that The reimbursable toggle is enabled.

    Control workspace

    1. Go to the workspace settings > Rules
    2. Verify there is reimbursable settings under Rules - "Cash expense default"
    3. Update the default option to non-reimbursable
    4. Verify that the expense form is defaulted to non-reimbursable
    5. Update the default option to always reimbursable
    6. Verify that the expense form updated to always reimbursable
    7. Update the default option to always non-reimbursable
    8. Verify that the expense form has been updated to never reimbursable

    No workspace

    1. Create an expense outside of a workspace
    2. Verify that we don't display the reimbursable toggle
    3. Create an expense outside of a workspace and select to submit to yourself
    4. Verify that reimbursable toggle should not appear for p2p expense on the confirmation page.
    5. In the Self-DM select categorize it or share with my accountant
    6. Verify that the reimbursable toggle is visible
    7. [Collect workspace] Verify that reimbursable is enabled by default

    Do we agree 👍 or 👎

  11. trjExpensify commented on Oct 13, 2025

    @trjExpensify
    Contributor
    1. Approve the report and verify that the expense no longer has the reimbursable toggle

    @getusha is that right? Why would the reimbursable toggle "disappear" on a cash expense that's marked as non-reimbursable? 🤔 I would think it's there, but set to non-reimbursable given the steps you executed before it.

    Additionally, some of these steps are pretty sloppy tbh.

    Imported company card expense

    1. Go to Workspace Settings > Domains > [Domain Name] > Company Cards.
    2. Import a company card expense
    3. Verify that the expense defaults to non-reimbursable
    4. Mark all the expenses on a report as non-reimbursable, verify that
    5. Verify that the Pay button disappears for the payer side
    6. Verify that the system message updates to: No further action required

    I think we can tighten this one up, and it doesn't quite make sense to me:

    1. Add a card feed in NewDot not OldDot, seems unnecessary
    2. I don't know why in step 4 you're instructing to mark expenses as non-reimbursable, they should be set like that already. Suggested edit:
    3. You mean "next steps" not "system message" for step 7, but I think it's redundant unless you give a lot more instructions for the workspace setup and state of the report they're on, so I'll omit that.

    Editing that to:

    Imported company card expense

    1. Go to Workspaces > [Click a workspace] > Company Cards > Add a card feed.
    2. Import some company card expense
    3. Verify that the expense defaults to non-reimbursable
    4. Verify the reimbursable toggle doesn't appear on the imported card transactions

    Undo close

    1. Disable approval and delayed submissions.
    2. Create an expense with reimbursable disabled.
    3. Click more -> Undo close.
    4. Verify that The reimbursable toggle is enabled.
    1. The button is called "Retract" in NewDot now, please make sure to check your steps to be accurate with production.
    2. What I think you're testing (locked for editing in the closed state) isn't super clear.

    Editing that to:

    Retract

    1. Disable approval and delayed submissions.
    2. Create an expense
    3. On the confirmation screen disable the reimbursable toggle > Confirm
    4. After creation, verify the reimbursable toggle is locked for editing.
    5. Click More -> Retract.
    6. Verify the reimbursable toggle is no longer locked for editing.

    Control workspace

    1. Go to the workspace settings > Rules
    2. Verify there is reimbursable settings under Rules - "Cash expense default"
    3. Update the default option to non-reimbursable
    4. Verify that the expense form is defaulted to non-reimbursable
    5. Update the default option to always reimbursable
    6. Verify that the expense form updated to always reimbursable
    7. Update the default option to always non-reimbursable
    8. Verify that the expense form has been updated to never reimbursable

    Per the OP:

    • If Always non-reimbursable is set via OldDot, don't show the toggle at all and create the cash expense as non-reimbursable.
    • If Always reimbursable is set via OldDot, don't show the toggle at all and create the cash expense as reimbursable.

    Your steps don't actually test for those. For example, what does it mean to a tester to "verify that the expense form has been updated to never reimbursable"?

    Editing that one to:

    Control workspace

    1. Go to the workspace settings > Rules
    2. Verify there is reimbursable settings under Rules - "Cash expense default"
    3. Update the default option to non-reimbursable
    4. Verify that the toggle on the expense form is defaulted to non-reimbursable
    5. Update the default option to always reimbursable
    6. Verify that there isn't a toggle on the expense form and the expense is created as a reimbursable expense
    7. Update the default option to always non-reimbursable
    8. Verify that there isn't a toggle on the expense form and the expense is created as a non-reimbursable expense

    No workspace

    1. Create an expense outside of a workspace
    2. Verify that we don't display the reimbursable toggle
    3. Create an expense outside of a workspace and select to submit to yourself
    4. Verify that reimbursable toggle should not appear for p2p expense on the confirmation page.
    5. In the Self-DM select categorize it or share with my accountant
    6. Verify that the reimbursable toggle is visible
    7. [Collect workspace] Verify that reimbursable is enabled by default

    Again, just not very clear:

    • "outside of a workspace" where? DM? SelfDM? Mars? 😅
    • Some steps seem repetitive
    • "Categorize it" isn't on prod for customers at large anymore

    I'll edit this one to focus on the P2P stuff, as unreported expenses in the selfDM is coming elsewhere to facilitate using coding of the default workspace.

    No workspace

    1. Go to global create > create expense
    2. Enter an amount
    3. Choose an individual
    4. Verify that we don't display the reimbursable toggle on the confirmation screen
    5. Confirm and create the expense
    6. Go to the DM > click into the expense
    7. Verify that we don't display the reimbursable toggle on the expense form
  12. trjExpensify commented on Oct 13, 2025

    @trjExpensify
    Contributor

    Payment summary as follows:

  13. trjExpensify commented on Oct 13, 2025

    @trjExpensify
    Contributor

    Closing!

  14. getusha commented on Oct 14, 2025

    @getusha
    Contributor

    Additionally, some of these steps are pretty sloppy tbh.

    Thanks for all the updates and feedback! I copied the steps since QA had already tested them, I should've verified and made them clearer.

  15. twisterdotcom commented on Oct 16, 2025

    @twisterdotcom
    Contributor

    @getusha has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-6de7-aeba-88ca-0da6fa639f11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.ReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions