You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD https://github.com/Expensify/App/issues/60214] [$250] Expense - Submit button on expense preview shows 0.00 after categorizing expense #60081
Version Number: 9.1.26-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+sd3480@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.3 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Log in with Expensifail account.
Have a workspace with "Delay submissions" and "Add approvals" enabled.
Have self DM. (please try Create an unreported expense on OD to trigger self DM in ND).
Go to staging.new.expensify.com
Go to self DM.
Track an expense in self DM.
Click Categorize it.
Select a category, enter merchant and submit the expense.
Expected Result:
Submit button on expense preview will not show 0.00 after categorizing expense.
Actual Result:
Submit button on expense preview shows 0.00 after categorizing expense.
What changes do you think we should make in order to solve the problem?
Follow the ReportPreview by not showing the amount.
OR
Return empty string if the amount is 0.
OR
When submitting, I think it makes sense to show even the non reimbursable amount. So, just like here, where we only exclude non-reimbursable for pay action when calculating the non-held amount, we can do the same for getSettlementAmount.
changed the title [-]Expense - Submit button on expense preview shows 0.00 after categorizing expense[/-][+][$250] Expense - Submit button on expense preview shows 0.00 after categorizing expense[/+]on Apr 11, 2025
The amount is 0 because it's a track expense, so the reimbursable spend is 0.
Hi @bernhardoj could you help me understand it? I think it's probably a BE issue, when we categorize a track expense, it should set nonReimbursableTotal of iouReport to 0, shouldn't it?
This issue has not been updated in over 15 days. @hoangzinh, @maddylewis eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Activity
melvin-bot commentedon Apr 11, 2025
Triggered auto assignment to @maddylewis (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.bernhardoj commentedon Apr 11, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Submit button shows 0 when using table report view.
What is the root cause of that problem?
We always show the amount of the report.
App/src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx
Lines 632 to 636 in bee2cb5
The amount is 0 because it's a track expense, so the reimbursable spend is 0.
App/src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx
Lines 254 to 255 in bee2cb5
If we compare it with ReportPreview, we never show the amount for the submit button.
App/src/components/ReportActionItem/ReportPreview.tsx
Lines 665 to 668 in bee2cb5
What changes do you think we should make in order to solve the problem?
Follow the ReportPreview by not showing the amount.
OR
Return empty string if the amount is 0.
OR
When submitting, I think it makes sense to show even the non reimbursable amount. So, just like here, where we only exclude non-reimbursable for pay action when calculating the non-held amount, we can do the same for
getSettlementAmount.App/src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx
Line 156 in bee2cb5
or just use
fullAmountWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
If we go with the 2nd solution, we can render
MoneyRequestReportPreviewContentand make sure the amount doesn't show if it's 0.[-]Expense - Submit button on expense preview shows 0.00 after categorizing expense[/-][+][$250] Expense - Submit button on expense preview shows 0.00 after categorizing expense[/+]melvin-bot commentedon Apr 11, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021910683588619929607
melvin-bot commentedon Apr 11, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (
External)hoangzinh commentedon Apr 15, 2025
Thanks for posting the proposal @bernhardoj. I will try to review it today or tomorrow.
hoangzinh commentedon Apr 16, 2025
Hi @bernhardoj could you help me understand it? I think it's probably a BE issue, when we categorize a track expense, it should set
nonReimbursableTotalof iouReport to 0, shouldn't it?bernhardoj commentedon Apr 17, 2025
If we categorize a track expense of $5, the
nonReimbursableTotalwould be -500 because track expense is not reimbursable. The total is also -500.hoangzinh commentedon Apr 17, 2025
@bernhardoj I see. I asked experts on Slack, awaiting their thoughts
1 remaining item
mountiny commentedon Apr 17, 2025
Putting this on hold for more general issue that should solve this #60214
melvin-bot commentedon Apr 24, 2025
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon May 19, 2025
This issue has not been updated in over 15 days. @hoangzinh, @maddylewis eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
maddylewis commentedon Jul 8, 2025
this issue was closed/merged awhile back #60214 / closing.