Skip to content

Deploy Checklist: New Expensify 2022-05-24 #9151

Closed

Description

@OSBotify

Release Version: 1.1.66-1
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

Activity

  1. self-assigned this
    on May 24, 2022
  2. mvtglobally commented on May 24, 2022

    @mvtglobally

    @Julesssss , its been a while and IOS build still not available. Can you check if it is looking ok?

  3. OSBotify commented on May 24, 2022

    @OSBotify
    ContributorAuthor

    🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.66-1 🚀

  4. mvtglobally commented on May 25, 2022

    @mvtglobally

    @Julesssss Regression is completed

    Deploy blockers logged
    #9159
    #9161
    #9166

    PR #8980 is failing due to #9158. Pls double check if it needs to be a blocker as experiences between PROD and Staging differs.
    PR #9138 is failing due to #9159

    Issues logged
    #9157
    #9158
    #9162
    #9164

  5. Julesssss commented on May 25, 2022

    @Julesssss
    Contributor

    Checked off 9159 which we believe should be expected after changes in other PRs.

  6. Julesssss commented on May 25, 2022

    @Julesssss
    Contributor

    Commented on 9161 as I have a feeling this is expected.

  7. Julesssss commented on May 25, 2022

    @Julesssss
    Contributor

    Additionally, I think 9166 has the same explanation as 9159 and is expected. But I'll await a second opinion before removing the label.

  8. mvtglobally commented on May 25, 2022

    @mvtglobally

    @Julesssss, thanks for update. Hopefully we can have a new deploy today. Let us know if anything needs to be re-tested

  9. Julesssss commented on May 25, 2022

    @Julesssss
    Contributor

    After looking into 9158 it seems to be a regression, but this has been on prod for a few weeks now -- so is unrelated to this checklist. I've posted here and here to ensure we figure out a fix.

  10. Julesssss commented on May 25, 2022

    @Julesssss
    Contributor

    Checking of 9161 and 9166 and as discussed in the issues and in Slack.

  11. Julesssss commented on May 25, 2022

    @Julesssss
    Contributor

    Also checked off 9146 as there is no QA to be performed.

  12. Julesssss commented on May 25, 2022

    @Julesssss
    Contributor

    Checking off 9138 as the tests pass and we deemed the linked issue to not be a deployBlocker.

  13. Julesssss commented on May 25, 2022

    @Julesssss
    Contributor

    After looking into 9158 it seems to be a regression, but this has been on prod for a few weeks now -- so is unrelated to this checklist. I've posted here and here to ensure we figure out a fix.

    Just to clarify. I was mistaken here. THIS is the PR which I believe introduced the issue so I've made it a deployBlocker.

  14. chiragsalian commented on May 25, 2022

    @chiragsalian
    Contributor
  15. chiragsalian commented on May 25, 2022

    @chiragsalian
    Contributor

    :shipit:

  16. SumitDiyora commented on May 27, 2022

    @SumitDiyora

    Checked all PRs on Production / Staging and created accessibility issues for all PRs where accessibility issues were found.
    The non-applicable PRs are - #9136, #9146
    Logged Issues - #8403, #8401, #8400, #8413, #8402, #8388, #8387, #8579, #8624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions