Skip to content

[Payment due @Krishna2323] Add NetSuite split exports by posting period toggle - #101934

Merged
yuwenmemon merged 3 commits into
Expensify:mainfrom
ShridharGoel:netsuite-split-exports-toggle
Sep 25, 2026
Merged

yuwenmemon merged 3 commits into
Expensify:mainfrom
ShridharGoel:netsuite-split-exports-toggle

Conversation

@ShridharGoel

@ShridharGoel ShridharGoel commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

This adds the "Split exports by posting period" toggle on the NetSuite export configuration page, part of cross-period expense exporting release 1. The toggle saves through the new UpdateNetSuiteSplitExportsByPostingPeriod command. The two toggles stay coupled in both directions, as the mocks require: split cannot be turned on while "Export to next open period" is off (the split toggle is locked), and "Export to next open period" cannot be turned off while split is on (it shows a lock and helper text). The same dependency is also enforced server-side, so the UI lock is a convenience, not the only guard.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/675926
PROPOSAL:

Tests

  1. Open a workspace connected to NetSuite and go to Accounting > NetSuite > Export.
  2. Verify that the "Split exports by posting period" is off by default.
  3. Turn off "Export to next open period".
  4. Verify the "Split exports by posting period" toggle below it is locked off and shows the helper text "Enable export to next open period to enable split non-reimbursable exports by period in NetSuite"
  5. Turn on "Export to next open period".
  6. Verify the split toggle is now enabled, the helper text is gone, and the toggle can be turned on.
  7. Turn on "Split exports by posting period".
  8. Verify "Export to next open period" is now locked on and shows the helper text "To disable export to next open period, first disable split non-reimbursable exports by period."
  9. Turn off "Split exports by posting period" and verify "Export to next open period" can be turned off again.

  1. Set "Split exports by posting period" to true.
  2. Create manual expenses across 2–3 months - when creating each expense, set the date and toggle Reimbursable off.
  3. Submit and approve the report.
  4. Export: open the report → More (⋮) → Export → NetSuite.
  5. Verify on NetSuite: one Vendor Bill per month, each dated in its month, external IDs like VBNR__202608

  1. Set "Split exports by posting period" to true.
  2. On a NetSuite-connected workspace with non-reimbursable expenses exporting as Expense Reports, create manual expenses across 2–3 months - when creating each expense, set the date and toggle Reimbursable off.
  3. Submit and approve the report.
  4. Export: open the report → More (⋮) → Export → NetSuite.
  5. Verify on NetSuite: one Expense Report per month, each dated in its month, external IDs like EXPNR_202608
  • Verify that no errors appear in the JS console

Offline tests

  1. Go offline and toggle "Split exports by posting period".
  2. Verify the toggle updates right away with a pending (greyed) state, and syncs when back online.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari
Screen.Recording.2026-09-20.at.4.42.54.PM.mov
Screen.Recording.2026-09-21.at.7.48.33.AM.mov

@melvin-bot

melvin-bot Bot commented Sep 22, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

@codecov

codecov Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 94.06% <ø> (+0.84%) ⬆️
src/libs/API/types.ts 100.00% <ø> (ø)
src/pages/workspace/accounting/utils.tsx 48.83% <ø> (+35.15%) ⬆️
src/libs/actions/connections/NetSuiteCommands.ts 16.06% <0.00%> (-0.27%) ⬇️
...etsuite/export/NetSuiteExportConfigurationPage.tsx 0.00% <0.00%> (ø)
... and 426 files with indirect coverage changes

@ShridharGoel
ShridharGoel marked this pull request as ready for review September 23, 2026 20:31
@ShridharGoel
ShridharGoel requested review from a team as code owners September 23, 2026 20:31
@melvin-bot
melvin-bot Bot requested review from abdulrahuman5196 and heyjennahay and removed request for a team September 23, 2026 20:31
@melvin-bot

melvin-bot Bot commented Sep 23, 2026

Copy link
Copy Markdown

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team September 23, 2026 20:31
@ShridharGoel
ShridharGoel force-pushed the netsuite-split-exports-toggle branch from 7bcb9af to 4893320 Compare September 23, 2026 21:59
@ShridharGoel
ShridharGoel requested review from Krishna2323 and removed request for abdulrahuman5196 September 23, 2026 22:11
@Krishna2323

Krishna2323 commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
android_mWeb.mp4
Android: mWeb Chrome
android_mWeb_R.mp4
iOS: HybridApp
ios_hybrid.mp4
iOS: mWeb Safari
ios_mWeb.mp4
MacOS: Chrome / Safari
web_chrome.mp4

@Krishna2323

Copy link
Copy Markdown
Contributor

@MelvinBot review

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Reviewed the diff. The implementation follows the existing NetSuite toggle pattern closely and CI is green (only Check independent approval fails, which is expected). Two things I'd change before merge, plus a copy nit.


1. The two-way lock can trap an admin with no way out 🔴

The locks are symmetric with no escape hatch:

So the state exportToNextOpenPeriod: false + splitExportsByPostingPeriod: true locks both switches permanently. This page is the only surface for either setting, so there is no way to recover from the UI.

How the app reaches that state

Starting from both on:

  1. Toggle split off → optimistic split: false, request queued.
  2. That unlocks "Export to next open period", so toggle it off → optimistic export: false.
  3. The split request fails (500, timeout, backend rejection). updateNetSuiteOnyxData restores oldSettingValue, so split goes back to true (NetSuiteCommands.ts:132) while the export request succeeded as false.

Result: export: false, split: true → both locked. Same thing happens if the pair ever drifts out of sync from any other source.

One-line fix — keep the lock, but always let the user turn split off:

-            disabled: !config?.exportToNextOpenPeriod,
-            showLockIcon: !config?.exportToNextOpenPeriod,
+            disabled: !config?.exportToNextOpenPeriod && !config?.splitExportsByPostingPeriod,
+            showLockIcon: !config?.exportToNextOpenPeriod && !config?.splitExportsByPostingPeriod,

This still matches the mocks (split is locked off when export is off) but breaks the deadlock.

2. splitExportsByPostingPeriod is missing from subscribedExportSettings 🟡

accounting/utils.tsx:301 lists EXPORT_TO_NEXT_OPEN_PERIOD but not the new key. That list drives the RBR indicator and the offline pending state on the Accounting page's "Export" row (PolicyAccountingPage.tsx:671).

Without it, a failed split update shows an error on the Export sub-page but no red dot on Accounting, and the Export row won't grey out while the change is pending offline. Add CONST.NETSUITE_CONFIG.SPLIT_EXPORTS_BY_POSTING_PERIOD next to the existing entry.

3. Copy nits 🟢

The helper text names the setting differently from the toggle label:

  • Label: "Split exports by posting period"
  • Helper: "…split non-reimbursable exports by period…"

Also splitExportsByPostingPeriodSubtitle says "Enable … to enable …" and is the only one of the two new strings without a trailing period. Suggested:

exportToNextOpenPeriodLockedSubtitle: 'To disable export to next open period, first disable split exports by posting period.',
splitExportsByPostingPeriodSubtitle: 'Enable export to next open period to split exports by posting period in NetSuite.',

Ignore if this is verbatim from Figma. If you do change en.ts, the other 11 locale files need regenerating too.


Minor / non-blocking

  • No unit tests in the diff, though the author checklist box is checked. The toggle-coupling rules are cheap pure logic to cover, and there's no existing test for exportToNextOpenPeriod to regress against.
  • ToggleSettingOptionRow supports disabledText, which renders a tooltip over the locked switch. The subtitle covers it on web, but a tooltip is the pattern used in TravelBillingContinuousReconciliationSection.tsx:75 — optional.
  • Question: does this need a beta gate until the corresponding backend change is live everywhere? The toggle is currently visible to every NetSuite-connected workspace.

I didn't run this in the app — verifying it needs a live NetSuite-connected workspace, which the test account doesn't have.


view run

@Krishna2323

Copy link
Copy Markdown
Contributor

@ShridharGoel could you please check the points raised by Melvin above? I tried reproducing the two-way lock trap but wasn't able to. However, I think since the fix is safe and simple, we should do it.

@ShridharGoel

Copy link
Copy Markdown
Contributor Author

@Krishna2323 Doesn't the proposed fix change the logic? Below is the requirement:

Screenshot 2026-09-25 at 1 56 18 AM

@Krishna2323

Copy link
Copy Markdown
Contributor

@ShridharGoel The fix only changes the unreachable “split ON + next-open-period OFF” state, so admins can turn split off from there. The other three valid states behave exactly as before, and split still can't be enabled while next-open-period is off.

@ShridharGoel

Copy link
Copy Markdown
Contributor Author

Updated

@ShridharGoel

Copy link
Copy Markdown
Contributor Author

@MelvinBot review

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Re-reviewed at fbf176f. Both issues from my last review are fixed, and I found no new problems. This looks good to merge from a code point of view.

How each toggle state behaves now
Next open period Split "Export to next open period" "Split exports"
On Off Editable Editable
On On Locked, shows helper text Editable
Off Off Editable Locked, shows helper text
Off On (bad state) Locked, helper text says to turn off split Editable, so the admin can recover

The first three rows match the requirement you shared. The fourth row only happens if the two settings get out of sync, and the admin can now fix it from the page. Optimistic rollbacks in updateNetSuiteOnyxData can't cause a new deadlock.

Two small items remain from last time. Neither blocks merge:

  • The diff has no unit tests, but the "I added unit tests" box is checked. Add tests or uncheck the box.
  • Should this toggle sit behind a beta until the backend command is live everywhere? Right now every NetSuite-connected workspace sees it.

I didn't test this in the app, because the test account has no NetSuite-connected workspace.


view run

@ShridharGoel

Copy link
Copy Markdown
Contributor Author

@Krishna2323 Can you review when possible?

@Krishna2323 Krishna2323 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@melvin-bot melvin-bot Bot changed the title Add NetSuite split exports by posting period toggle [Payment due @Krishna2323] Add NetSuite split exports by posting period toggle Sep 25, 2026
@melvin-bot

melvin-bot Bot commented Sep 25, 2026

Copy link
Copy Markdown

🎯 @Krishna2323, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/675926.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

@heyjennahay

Copy link
Copy Markdown
Contributor

@kortneywynn @HaleyJacobson FYI

@heyjennahay heyjennahay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Product change LGTM 👍

@yuwenmemon
yuwenmemon merged commit 59f919f into Expensify:main Sep 25, 2026
38 of 40 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.4.95-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

Yes, the help site needs an update. This PR adds a new Split exports by posting period toggle, and the NetSuite configuration article didn't mention it.

I opened the draft PR Docs updates for E/A#101934 Add NetSuite Split exports by posting period toggle. It updates docs/articles/new-expensify/connections/netsuite/Configure-Netsuite.md with these changes:

  • Adds Split exports by posting period to the export settings list, and explains that it depends on Export to next open period.
  • Fixes the capitalization of Export to next open period to match the UI.
  • Adds three FAQs: how the split works, why Export to next open period can't be turned off, and why Split exports by posting period can't be turned on.
Verification note

I checked the labels against src/languages/en.ts on main. I couldn't check them in the live UI: the test session couldn't sign in, and the test account has no NetSuite connection.

@ShridharGoel, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

@IuliiaHerets

Copy link
Copy Markdown

Hi @ShridharGoel. Please help me find the Vendor Bills per month and Expense Reports per month in NetSuite.

сс @yuwenmemon @heyjennahay @Krishna2323

@Julesssss

Copy link
Copy Markdown
Contributor

Sorry @ShridharGoel @yuwenmemon, we weren't able to help verify the test steps above and it was the last thing blocking App deploy so I reverted it here.

Please add additional steps to help with testing for the next round.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.95-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

@melvin-bot

melvin-bot Bot commented Sep 30, 2026

Copy link
Copy Markdown

🤖 Payment issue created: #102593

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants