Repository navigation
[Payment due @Krishna2323] Add NetSuite split exports by posting period toggle - #101934
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
7bcb9af to
4893320
Compare
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid_mWeb.mp4Android: mWeb Chromeandroid_mWeb_R.mp4iOS: HybridAppios_hybrid.mp4iOS: mWeb Safariios_mWeb.mp4MacOS: Chrome / Safariweb_chrome.mp4 |
|
@MelvinBot review |
|
🤖 Reviewed the diff. The implementation follows the existing NetSuite toggle pattern closely and CI is green (only 1. The two-way lock can trap an admin with no way out 🔴The locks are symmetric with no escape hatch:
So the state How the app reaches that stateStarting from both on:
Result: One-line fix — keep the lock, but always let the user turn split off: - disabled: !config?.exportToNextOpenPeriod,
- showLockIcon: !config?.exportToNextOpenPeriod,
+ disabled: !config?.exportToNextOpenPeriod && !config?.splitExportsByPostingPeriod,
+ showLockIcon: !config?.exportToNextOpenPeriod && !config?.splitExportsByPostingPeriod,This still matches the mocks (split is locked off when export is off) but breaks the deadlock. 2.
|
|
@ShridharGoel could you please check the points raised by Melvin above? I tried reproducing the two-way lock trap but wasn't able to. However, I think since the fix is safe and simple, we should do it. |
|
@Krishna2323 Doesn't the proposed fix change the logic? Below is the requirement:
|
|
@ShridharGoel The fix only changes the unreachable “split ON + next-open-period OFF” state, so admins can turn split off from there. The other three valid states behave exactly as before, and split still can't be enabled while next-open-period is off. |
|
Updated |
|
@MelvinBot review |
|
🤖 Re-reviewed at
How each toggle state behaves now
The first three rows match the requirement you shared. The fourth row only happens if the two settings get out of sync, and the admin can now fix it from the page. Optimistic rollbacks in Two small items remain from last time. Neither blocks merge:
I didn't test this in the app, because the test account has no NetSuite-connected workspace. |
|
@Krishna2323 Can you review when possible? |
|
🎯 @Krishna2323, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
heyjennahay
left a comment
There was a problem hiding this comment.
Product change LGTM 👍
|
🚧 yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.4.95-0 🚀
|
|
Yes, the help site needs an update. This PR adds a new Split exports by posting period toggle, and the NetSuite configuration article didn't mention it. I opened the draft PR Docs updates for E/A#101934 Add NetSuite Split exports by posting period toggle. It updates
Verification noteI checked the labels against @ShridharGoel, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
Hi @ShridharGoel. Please help me find the Vendor Bills per month and Expense Reports per month in NetSuite. |
|
Sorry @ShridharGoel @yuwenmemon, we weren't able to help verify the test steps above and it was the last thing blocking App deploy so I reverted it here. Please add additional steps to help with testing for the next round. |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.95-4 🚀
|
|
🤖 Payment issue created: #102593 |

Explanation of Change
This adds the "Split exports by posting period" toggle on the NetSuite export configuration page, part of cross-period expense exporting release 1. The toggle saves through the new
UpdateNetSuiteSplitExportsByPostingPeriodcommand. The two toggles stay coupled in both directions, as the mocks require: split cannot be turned on while "Export to next open period" is off (the split toggle is locked), and "Export to next open period" cannot be turned off while split is on (it shows a lock and helper text). The same dependency is also enforced server-side, so the UI lock is a convenience, not the only guard.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/675926
PROPOSAL:
Tests
Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Screen.Recording.2026-09-20.at.4.42.54.PM.mov
Screen.Recording.2026-09-21.at.7.48.33.AM.mov