Repository navigation
Add NetSuite split exports by posting period toggle - #102605
yuwenmemon merged 3 commits into
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
Already reviewed by @Krishna2323 here |
|
@ShridharGoel please fix the CI failures |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid_mWeb.mp4Android: mWeb Chromeandroid_mWeb_R.mp4iOS: HybridAppios_hybrid.mp4iOS: mWeb Safariios_mWeb.mp4MacOS: Chrome / Safariweb_chrome.mp4 |
|
CI failures are on main |
…e-split-exports-toggle
…-netsuite-split-exports-toggle
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
🚧 yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.5.2-0 🚀
|
|
No help site update is needed. Docs updates for E/A#101934 Add NetSuite Split exports by posting period toggle already documents this toggle and its lock behavior in Configure-Netsuite.md:79. This PR re-adds the same UI change as [Payment due |
|
@yuwenmemon @Julesssss @ShridharGoel bandicam.2026-10-05.16-01-17-724.mp4
|
|
@MelvinBot Insvetigate why |
|
The test workspace probably has no NetSuite Default vendor selected. This PR likely isn't the cause. NetSuite needs a default vendor to create a Vendor Bill for company card expenses, and the PR's QA steps never say to pick one. How to unblock QA:
About "Vendors" in More features: It isn't supposed to appear for NetSuite. That toggle is for vendor matching with QBO, Sage Intacct, Rillet, DualEntry, and, behind a beta, Xero and Business Central. NetSuite is left out on purpose. The NetSuite default vendor lives in the export settings above. Suggested PR update: In the "Vendor Bills export test", add a step after step 1: "Select a Default vendor." Investigation details
Not verified: I couldn't read the backend code or the logs. So I haven't confirmed that this workspace's default vendor is empty, or whether the split-by-period export finds the vendor differently. To rule out the PR, export the same report with Split exports by posting period turned off. If the same error appears, the cause is the workspace setup. If the export still fails after you pick a default vendor, an internal engineer needs to check the backend. Next Steps: Reply with |
|
@m-natarajan Can you set the default vendor in the workspace settings? |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.5.2-4 🚀
Bundle Size Analysis (Sentry): |

Explanation of Change
Recreates #101934 (reverted in #102588 to unblock deploy while verifying QA test steps).
Adds the "Split exports by posting period" toggle on the NetSuite export configuration page, part of cross-period expense exporting release 1. The toggle saves through
UpdateNetSuiteSplitExportsByPostingPeriod. The toggles stay coupled bidirectionally: split cannot be turned on while "Export to next open period" is off (locked with subtitle), and "Export to next open period" cannot be turned off while split is on (locked with subtitle).Fixed Issues
$ https://github.com/Expensify/Expensify/issues/675926
PROPOSAL:
Tests
Vendor Bills export test:
bill: <reportID>).VBNR_<reportID>_YYYYMM).Expense Reports export test:
exp: <reportID>).EXPNR_<reportID>_YYYYMM).Offline tests
QA Steps
Same as tests.
To find the exported transactions in NetSuite:
Vendor Bills: In NetSuite, go to Transactions > Payables > Enter Bills > List or use the top search bar:
bill: <reportID>.Expense Reports: In NetSuite, go to Transactions > Employees > Enter Expense Reports > List or use the top search bar:
exp: <reportID>.Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Screen.Recording.2026-09-20.at.4.42.54.PM.mov
Screen.Recording.2026-09-21.at.7.48.33.AM.mov