Repository navigation
Revert "[Payment due @Krishna2323] Add NetSuite split exports by posting period toggle" - #102588
Conversation
…ing period toggle"
|
@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e7c887bb56
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@Julesssss what about failing eslint? |
Not introduced here, on a file that we didn't touch. occuring for all new App PRs: https://expensify.slack.com/archives/C01GTK53T8Q/p1790723563533089?thread_ts=1790721508.424879&cid=C01GTK53T8Q |
|
🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
…t-exports-toggle Revert "[Payment due @Krishna2323] Add NetSuite split exports by posting period toggle" (cherry picked from commit 248682b) (cherry-picked to staging by Julesssss)
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
@Julesssss looks like this was merged without a test passing. These checks had not passed on e7c887b when it was merged:
Please add a note explaining why this was done and remove the |
|
Not emergency: #102588 (comment) |
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.4.95-4 🚀
|
|
No help site update is needed. This PR reverts the NetSuite Split exports by posting period toggle, and no article in Heads-up: the docs PR for the original feature, Docs updates for E/A#101934 Add NetSuite Split exports by posting period toggle, is still open. Hold or close it so it doesn't merge while the feature is reverted. |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.95-4 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.4.96-0 🚀
|
|
No help site update is needed. This PR reverts the NetSuite Split exports by posting period toggle, and no article in The docs PR for the original feature, Docs updates for E/A#101934 Add NetSuite Split exports by posting period toggle, is still open. Hold or close it so it doesn't merge while the feature is reverted. |
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.4.99-0 🚀
|
|
No help site update is needed. This PR reverts the Split exports by posting period toggle, and no merged help article on There is still an open draft docs PR for the original feature: Docs updates for E/A#101934 Add NetSuite Split exports by posting period toggle. Hold or close it until the feature relands. If it merges now, it will describe a setting that no longer exists. |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.99-2 🚀
Bundle Size Analysis (Sentry): |
Reverts #101934 as test steps cannot be fully confirmed. It's the only thing blocking the deploy and this unblocks us.