Skip to content

Revert "[Payment due @Krishna2323] Add NetSuite split exports by posting period toggle" - #102588

Merged
Julesssss merged 1 commit into
mainfrom
revert-101934-netsuite-split-exports-toggle
Sep 30, 2026
Merged

Julesssss merged 1 commit into
mainfrom
revert-101934-netsuite-split-exports-toggle

Conversation

@Julesssss

@Julesssss Julesssss commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Reverts #101934 as test steps cannot be fully confirmed. It's the only thing blocking the deploy and this unblocks us.

@Julesssss
Julesssss requested review from a team as code owners September 30, 2026 00:13
@melvin-bot
melvin-bot Bot requested review from carlosmiceli and joekaufmanexpensify and removed request for a team September 30, 2026 00:13
@melvin-bot

melvin-bot Bot commented Sep 30, 2026

Copy link
Copy Markdown

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e7c887bb56

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@carlosmiceli

Copy link
Copy Markdown
Contributor

@Julesssss what about failing eslint?

@Julesssss

Copy link
Copy Markdown
Contributor Author

ESLint check / ESLint check (pull_request)Failing after 8m

Not introduced here, on a file that we didn't touch.

occuring for all new App PRs: https://expensify.slack.com/archives/C01GTK53T8Q/p1790723563533089?thread_ts=1790721508.424879&cid=C01GTK53T8Q

@Julesssss
Julesssss merged commit 248682b into main Sep 30, 2026
46 of 52 checks passed
@Julesssss
Julesssss deleted the revert-101934-netsuite-split-exports-toggle branch September 30, 2026 00:27
@github-actions

Copy link
Copy Markdown
Contributor

🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify pushed a commit that referenced this pull request Sep 30, 2026
…t-exports-toggle

Revert "[Payment due @Krishna2323] Add NetSuite split exports by posting period toggle"

(cherry picked from commit 248682b)

(cherry-picked to staging by Julesssss)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Sep 30, 2026
@melvin-bot melvin-bot Bot added the Emergency label Sep 30, 2026
@melvin-bot

melvin-bot Bot commented Sep 30, 2026

Copy link
Copy Markdown

@Julesssss looks like this was merged without a test passing. These checks had not passed on e7c887b when it was merged:

Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@Julesssss

Copy link
Copy Markdown
Contributor Author

Not emergency: #102588 (comment)

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.4.95-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update is needed. This PR reverts the NetSuite Split exports by posting period toggle, and no article in docs/articles on main mentions that toggle, so nothing published is now wrong.

Heads-up: the docs PR for the original feature, Docs updates for E/A#101934 Add NetSuite Split exports by posting period toggle, is still open. Hold or close it so it doesn't merge while the feature is reverted.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.95-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.4.96-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update is needed. This PR reverts the NetSuite Split exports by posting period toggle, and no article in docs/articles on main mentions that toggle, so nothing published is now wrong.

The docs PR for the original feature, Docs updates for E/A#101934 Add NetSuite Split exports by posting period toggle, is still open. Hold or close it so it doesn't merge while the feature is reverted.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.4.99-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update is needed. This PR reverts the Split exports by posting period toggle, and no merged help article on main mentions that toggle.

There is still an open draft docs PR for the original feature: Docs updates for E/A#101934 Add NetSuite Split exports by posting period toggle. Hold or close it until the feature relands. If it merges now, it will describe a setting that no longer exists.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.99-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants