Skip to content

[CP Staging] Revert "[Payment due @truph01] Add natural language filter entry point to Spend page" - #102203

Merged
lakchote merged 1 commit into
mainfrom
revert-94217-marcaaron-nl-filters-ui
Sep 24, 2026
Merged

lakchote merged 1 commit into
mainfrom
revert-94217-marcaaron-nl-filters-ui

Conversation

@stitesExpensify

@stitesExpensify stitesExpensify commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Reverts #94217

Fixed Issues

$ #102201
$ #102200
$ #102193
$ #102192
$ #102190
$ #102187
$ #102186
$ #102174
$ #102204

@stitesExpensify
stitesExpensify requested review from a team as code owners September 24, 2026 14:56
@melvin-bot
melvin-bot Bot requested review from heyjennahay and removed request for a team September 24, 2026 14:56
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-24T15:07:12.930167Z bc7a8fd PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@melvin-bot

melvin-bot Bot commented Sep 24, 2026

Copy link
Copy Markdown

@AndrewGable Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@lakchote lakchote changed the title Revert "[Payment due @truph01] Add natural language filter entry point to Spend page" [CP Staging] Revert "[Payment due @truph01] Add natural language filter entry point to Spend page" Sep 24, 2026
@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/ROUTES.ts 30.40% <ø> (ø)
src/SCREENS.ts 100.00% <ø> (ø)
...lterDropdowns/SearchAdvancedFiltersPopup/index.tsx 98.14% <100.00%> (+2.25%) ⬆️
src/libs/API/types.ts 100.00% <ø> (ø)
...gation/AppNavigator/ModalStackNavigators/index.tsx 7.67% <ø> (+<0.01%) ⬆️
...avigation/linkingConfig/RELATIONS/SEARCH_TO_RHP.ts 100.00% <ø> (ø)
src/libs/Navigation/linkingConfig/config.ts 62.50% <ø> (ø)
src/libs/actions/Search.ts 58.62% <ø> (+1.04%) ⬆️
...hAdvancedFiltersPage/SearchAdvancedFiltersBase.tsx 0.00% <ø> (ø)
src/styles/index.ts 63.28% <ø> (ø)
... and 1 more
... and 12 files with indirect coverage changes

@lakchote lakchote left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lakchote
lakchote merged commit 29681b3 into main Sep 24, 2026
50 of 51 checks passed
@lakchote
lakchote deleted the revert-94217-marcaaron-nl-filters-ui branch September 24, 2026 15:05
@github-actions

Copy link
Copy Markdown
Contributor

🚧 lakchote has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify pushed a commit that referenced this pull request Sep 24, 2026
…ilters-ui

[CP Staging] Revert "[Payment due @truph01] Add natural language filter entry point to Spend page"

(cherry picked from commit 29681b3)

(cherry-picked to staging by lakchote)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Sep 24, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@os-botify

os-botify Bot commented Sep 24, 2026

Copy link
Copy Markdown

🔁 Filed a Staging retest request for deploy blockers #102201, #102200, #102193, #102192, #102190, #102187, #102186, #102174, #102204 after this PR was cherry-picked to staging.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.4.93-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

MelvinBot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

No help site changes are required for this revert — but the pending docs PR for the original feature should be closed.

This PR reverts [Payment due truph01] Add natural language filter entry point to Spend page, removing the Describe your search entry point from the Spend page Filters popup. Nothing currently published under docs/articles documents that feature, so there is nothing to delete or amend and I did not open a docs PR.

The one thing that does need action: Docs updates for E/A#94217 document Describe your search on Spend page (Expensify/App#102158) is still open as a draft. It adds a new article, Describe-Your-Search-on-the-Spend-Page.md, plus cross-links in Getting-Started-with-the-Spend-Page.md and Use-Search-Operators-to-Filter-and-Analyze.md. Merging it now would publish help content for a feature that no longer exists. It should be closed, or held until the feature re-lands.

How I verified this

Help site scan: no match for Describe your search, the Your search input label, or the plain-English description copy anywhere in docs/. The filters section of docs/articles/new-expensify/reports-and-expenses/Getting-Started-with-the-Spend-Page.md:159-180 describes only the Type-based filter flow, which this revert does not touch.

Copy removed by this revert (search.describeSearch in all 11 locale files): Describe your search, Your search, the Use plain English to describe what you're looking for… helper text, and Apply. None of these strings appear in the help site.

Live UI check (web): on the Spend page I opened the Filters popup and confirmed no Describe your search entry is present. The left column lists Type, Status, From, To, Expense type, Date, Amount, Currency, Merchant, Description, and so on — matching what the help site already documents.

Spend page Filters popup with no Describe your search entry

@stitesExpensify, there is no new help site PR to mark Ready for review — this revert needs no docs changes. Please confirm that, and confirm whether Docs updates for E/A#94217 document Describe your search on Spend page should be closed now that the feature is reverted.


view run · view recording

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.4.93-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.4.94-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site changes are required for this PR, so I did not create a docs PR.

This PR reverts the Describe your search entry point on the Spend page. No article under App/docs/articles on main mentions that feature, so nothing there needs to be removed.

The feature is only documented in an unmerged draft: Docs updates for E/A#94217 document Describe your search on Spend page. Keep that PR in draft, and don't merge it, until the re-PR ships: [HOLD Web-Expensify/pull/56459] Add natural language filter entry point to Spend page (re-PR with deploy blocker fixes).

What I checked
  • The revert removes the describeSearch strings (Describe your search, Your search, Apply), the SearchNLFilterPage, and the filter entry point in SearchAdvancedFiltersPopup and SearchAdvancedFiltersBase.
  • I searched docs/articles on origin/main for "Describe your search", "natural language", and related phrases. The only matches are about the MCP server, Concierge, and Agent Rules. None are about Spend page filters.

@stitesExpensify, no help site PR was needed for this revert, so there's nothing to mark Ready for review. Please keep the existing docs draft linked above on hold until the re-PR merges.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.94-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants