Repository navigation
Fix: Add avatar details to the Lounge Access Page - #26687
Conversation
|
@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@shawnborton Plz confirm the new change by checking the Screenshots in the PR details. |
|
It seems like that top lounge illustration isn't as tall as it could be, though I'm not sure if that is related to anything you did here. In our mocks, we have it at 240px tall. So ignoring that, I think it looks pretty good to me. cc @Expensify/design for a second opinion too. |
| }, | ||
| })(LoungeAccessPage); | ||
| export default compose( | ||
| withLocalize, |
There was a problem hiding this comment.
Please use the useLocalize hook instead.
| /** Current user details, which will hold whether or not they have Lounge Access */ | ||
| user: userPropTypes, | ||
|
|
||
| ...withLocalizePropTypes, |
There was a problem hiding this comment.
Also remove these prop types after switching to useLocalize hook
roryabraham
left a comment
There was a problem hiding this comment.
thanks for making that change
Reviewer Checklist
Screenshots/Videos |
Santhosh-Sellavel
left a comment
There was a problem hiding this comment.
LGTM, thanks for the early review @roryabraham!
@thienlnam I'll let you decide whether this should be on merge freeze or not?
|
Going to put this on hold for the merge freeze! |
roryabraham
left a comment
There was a problem hiding this comment.
can you also pull main, merge it into this branch, and retest?
| ]; | ||
|
|
||
| function LoungeAccessPage({user}) { | ||
| function LoungeAccessPage(props) { |
There was a problem hiding this comment.
NAB for now but let's generally try to stick with using props destructuring. This will be required when we migrate to TypeScript
Done and seems fine. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.69-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.69-2 🚀
|
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.70-0 🚀
|
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.70-8 🚀
|







Details
#24381
Fixed Issues
$ #24381
PROPOSAL: #24381 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android