Skip to content

feat(server): Resolve built-in agent persona routes - #78

Merged
Jacksondr5 merged 1 commit into
feature/agent-persona-catalogfrom
feature/agent-persona-routing
Sep 14, 2026
Merged

Jacksondr5 merged 1 commit into
feature/agent-persona-catalogfrom
feature/agent-persona-routing

Conversation

@bryantderosier

@bryantderosier bryantderosier commented Sep 3, 2026 •

Copy link
Copy Markdown
Collaborator

What does this implement or fix?

Resolves each persona's ordered primary and fallback model targets against environment provider snapshots with typed rejection reasons and no implicit third fallback.

This is PR 3 of 10 in GitHub stack pingdotgg#120. It targets feature/agent-persona-catalog and depends on #76.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (clean-up or code structure improvement without changing behavior)
  • Documentation update

How has this been tested?

vp test run apps/server/src/j5/agents/agentPersonaRouting.test.ts — 5 tests passed.

The combined local integration suite also passed 350 tests across 17 files, scoped typechecks for server, web, mobile, contracts, and client runtime, and lint for 54 changed TypeScript files.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Screenshots or GIFs (Optional)

Not applicable.

Merge order

This PR is part of GitHub stack pingdotgg#120. Merge from bottom to top:

#75 -> #76 -> #78 -> #79 -> #80 -> #81 -> #83 -> #82 -> #85 -> #118

Stack rebuilt 2026-09-09 (stack pingdotgg#120): #84 and #86 were dropped, and fork-boundary refactors moved the persona RPCs, guards, and client wiring into J5-owned files. Review threads were preserved.

Generated with GPT-5 using the Codex desktop app.

@bryantderosier bryantderosier self-assigned this Sep 3, 2026
@coderabbitai

coderabbitai Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 37a4a176-040b-4292-b3a5-4ce81316dc4c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 effective changed lines (test files excluded in mixed PRs). labels Sep 3, 2026
@bryantderosier bryantderosier changed the title feat(server): DIGENG-0000 - Resolve built-in agent persona routes feat(server): Resolve built-in agent persona routes Sep 3, 2026
@bryantderosier
bryantderosier force-pushed the feature/agent-persona-routing branch from 11384ff to cdeea47 Compare September 3, 2026 16:18
@bryantderosier
bryantderosier force-pushed the feature/agent-persona-routing branch from cdeea47 to c3d346e Compare September 8, 2026 14:32
@bryantderosier
bryantderosier force-pushed the feature/agent-persona-routing branch from c3d346e to 5e07c26 Compare September 8, 2026 14:53
@bryantderosier
bryantderosier force-pushed the feature/agent-persona-routing branch from 5e07c26 to 68c2a95 Compare September 9, 2026 12:52
@bryantderosier
bryantderosier removed this pull request from stack #89 September 9, 2026 13:01
@bryantderosier
bryantderosier added this pull request to stack #120 September 9, 2026 13:02
@bryantderosier
bryantderosier force-pushed the feature/agent-persona-routing branch from 68c2a95 to 4457278 Compare September 11, 2026 17:35
@bryantderosier
bryantderosier force-pushed the feature/agent-persona-routing branch from 4457278 to 0cecb2e Compare September 14, 2026 12:07
@Jacksondr5
Jacksondr5 merged commit 06e31b2 into j5/main Sep 14, 2026
19 checks passed
@Jacksondr5
Jacksondr5 deleted the feature/agent-persona-routing branch September 14, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants