Repository navigation
feat(agents): manage portable libraries and imported definitions - #82
Merged
Jacksondr5 merged 7 commits intoSep 14, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This was referenced Sep 3, 2026
bryantderosier
force-pushed
the
feature/agent-persona-catalog-rpc
branch
from
September 3, 2026 18:45
b876e66 to
6ff8bbc
Compare
bryantderosier
changed the base branch from
feature/agent-persona-integrity
to
feature/builder-agent-prompt
September 3, 2026 18:46
bryantderosier
force-pushed
the
feature/agent-persona-catalog-rpc
branch
from
September 8, 2026 14:32
6ff8bbc to
ce1f581
Compare
bryantderosier
force-pushed
the
feature/agent-persona-catalog-rpc
branch
from
September 8, 2026 14:53
ce1f581 to
12eed0e
Compare
3 of 4 tasks
bryantderosier
force-pushed
the
feature/agent-persona-catalog-rpc
branch
from
September 9, 2026 12:52
12eed0e to
d90cc0c
Compare
bryantderosier
removed this pull request from stack #89
September 9, 2026 13:01
bryantderosier
added this pull request to stack #120
September 9, 2026 13:02
bryantderosier
force-pushed
the
feature/agent-persona-catalog-rpc
branch
from
September 9, 2026 15:58
2fe17ae to
0e5e826
Compare
bryantderosier
force-pushed
the
feature/agent-persona-catalog-rpc
branch
from
September 11, 2026 17:35
0e4b7c2 to
0fa310a
Compare
The seven library RPCs now live in packages/contracts/src/j5/agentPersona.ts as their own RpcGroup, merged into WsRpcGroup with one appended call so the existing environment-scoped WebSocket transport, remote connections, and mobile keep working unchanged. Server handlers and scope declarations move to apps/server/src/j5/agents/agentPersonaRpc.ts and are spread into the upstream handler and scope tables; client atoms and presentation helpers move under packages/client-runtime/src/j5. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
… delegates The orchestrator's thread.create validation, route-lock checks, and the launch service's persona resolution now call small J5-owned helpers in apps/server/src/j5/agents/agentPersonaOrchestration.ts; the runtime policy seam calls one J5 resolver. Behavior and error messages are unchanged. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Source folders and imports now recognize .yaml/.yml files only; JSON files are ignored in folders and rejected on import. Server-written stores and launch snapshots remain JSON, so no persisted state changes. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The launch, runtime policy, projection rebuild, contract, RPC scope, and adapter instruction cases for agent personas now live under apps/server/src/j5/agents and packages/contracts/src/j5, each with a small mirror of the upstream harness it needs. The upstream test files return to their trunk content. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The orchestrator constructs one J5 guard set next to its other services, handing over only its two error constructors and the adapter lookup; the create, route-lock, and model-mismatch sites become single calls. Runtime policy uses a J5 resolver that takes its error constructor the same way. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
bryantderosier
force-pushed
the
feature/agent-persona-catalog-rpc
branch
from
September 14, 2026 12:07
0fa310a to
c3358b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users can maintain their own environment-scoped agent library and import independent copies from JSON or YAML files. The server discovers configured source folders and persists imported definitions, enabled state, and source exclusions without changing source files or historical task snapshots.
Adds authorized catalog, import, edit, enable/disable, and remove RPCs plus shared client helpers. Duplicate imports return typed conflicts with content digests; selective confirmation replaces only approved definitions, skips rejected IDs, and detects intervening edits. Definitions and model routes are validated before launch. YAML and JSON use the same schema; imports are bounded and saved atomically.
Validation: the rebased integrated stack passed 487 focused tests across 21 files and typechecks for contracts, shared client runtime, server, web, and mobile. Tests cover YAML parsing, source discovery, conflicts, selective replacement, stale edits, persistence, permissions, disabled launches, and snapshot preservation. Changed files passed formatting and lint (existing upstream warnings remain). The dependent Settings PR includes real browser verification and screenshots.
Merge order
Part of GitHub stack
120. Merge from bottom to top:#75 → #76 → #78 → #79 → #80 → #81 → #83 → #82 → #85 → #118
Stack rebuilt 2026-09-09 (stack pingdotgg#120): #84 and #86 were dropped, and fork-boundary refactors moved the persona RPCs, guards, and client wiring into J5-owned files. Review threads were preserved.
Generated with GPT-6 using the Codex desktop app.