Skip to content

feat(agents): manage portable libraries and imported definitions - #82

Merged
Jacksondr5 merged 7 commits into
feature/builder-agent-promptfrom
feature/agent-persona-catalog-rpc
Sep 14, 2026
Merged

Jacksondr5 merged 7 commits into
feature/builder-agent-promptfrom
feature/agent-persona-catalog-rpc

Conversation

@bryantderosier

@bryantderosier bryantderosier commented Sep 3, 2026 •

Copy link
Copy Markdown
Collaborator

Users can maintain their own environment-scoped agent library and import independent copies from JSON or YAML files. The server discovers configured source folders and persists imported definitions, enabled state, and source exclusions without changing source files or historical task snapshots.

Adds authorized catalog, import, edit, enable/disable, and remove RPCs plus shared client helpers. Duplicate imports return typed conflicts with content digests; selective confirmation replaces only approved definitions, skips rejected IDs, and detects intervening edits. Definitions and model routes are validated before launch. YAML and JSON use the same schema; imports are bounded and saved atomically.

Validation: the rebased integrated stack passed 487 focused tests across 21 files and typechecks for contracts, shared client runtime, server, web, and mobile. Tests cover YAML parsing, source discovery, conflicts, selective replacement, stale edits, persistence, permissions, disabled launches, and snapshot preservation. Changed files passed formatting and lint (existing upstream warnings remain). The dependent Settings PR includes real browser verification and screenshots.

Merge order

Part of GitHub stack 120. Merge from bottom to top:

#75 → #76 → #78 → #79 → #80 → #81 → #83 → #82 → #85 → #118

Stack rebuilt 2026-09-09 (stack pingdotgg#120): #84 and #86 were dropped, and fork-boundary refactors moved the persona RPCs, guards, and client wiring into J5-owned files. Review threads were preserved.

Generated with GPT-6 using the Codex desktop app.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 07dd40c0-210a-4d97-a903-07ebbb472906

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 effective changed lines (test files excluded in mixed PRs). labels Sep 3, 2026
@bryantderosier
bryantderosier force-pushed the feature/agent-persona-catalog-rpc branch from b876e66 to 6ff8bbc Compare September 3, 2026 18:45
@bryantderosier
bryantderosier changed the base branch from feature/agent-persona-integrity to feature/builder-agent-prompt September 3, 2026 18:46
@bryantderosier bryantderosier self-assigned this Sep 3, 2026
@bryantderosier
bryantderosier force-pushed the feature/agent-persona-catalog-rpc branch from 6ff8bbc to ce1f581 Compare September 8, 2026 14:32
@github-actions github-actions Bot added size:XXL 1,000+ effective changed lines (test files excluded in mixed PRs). and removed size:L 100-499 effective changed lines (test files excluded in mixed PRs). labels Sep 8, 2026
@bryantderosier
bryantderosier force-pushed the feature/agent-persona-catalog-rpc branch from ce1f581 to 12eed0e Compare September 8, 2026 14:53
@bryantderosier bryantderosier changed the title feat(client-runtime): Expose the agent persona catalog feat(agents): manage portable libraries and imported definitions Sep 8, 2026
@bryantderosier
bryantderosier force-pushed the feature/agent-persona-catalog-rpc branch from 12eed0e to d90cc0c Compare September 9, 2026 12:52
@bryantderosier
bryantderosier removed this pull request from stack #89 September 9, 2026 13:01
@bryantderosier
bryantderosier added this pull request to stack #120 September 9, 2026 13:02
@bryantderosier
bryantderosier force-pushed the feature/agent-persona-catalog-rpc branch from 2fe17ae to 0e5e826 Compare September 9, 2026 15:58
bryantderosier and others added 7 commits September 14, 2026 08:05
The seven library RPCs now live in packages/contracts/src/j5/agentPersona.ts
as their own RpcGroup, merged into WsRpcGroup with one appended call so the
existing environment-scoped WebSocket transport, remote connections, and
mobile keep working unchanged. Server handlers and scope declarations move to
apps/server/src/j5/agents/agentPersonaRpc.ts and are spread into the upstream
handler and scope tables; client atoms and presentation helpers move under
packages/client-runtime/src/j5.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
… delegates

The orchestrator's thread.create validation, route-lock checks, and the
launch service's persona resolution now call small J5-owned helpers in
apps/server/src/j5/agents/agentPersonaOrchestration.ts; the runtime policy
seam calls one J5 resolver. Behavior and error messages are unchanged.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Source folders and imports now recognize .yaml/.yml files only; JSON files
are ignored in folders and rejected on import. Server-written stores and
launch snapshots remain JSON, so no persisted state changes.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The launch, runtime policy, projection rebuild, contract, RPC scope, and
adapter instruction cases for agent personas now live under
apps/server/src/j5/agents and packages/contracts/src/j5, each with a small
mirror of the upstream harness it needs. The upstream test files return to
their trunk content.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The orchestrator constructs one J5 guard set next to its other services,
handing over only its two error constructors and the adapter lookup; the
create, route-lock, and model-mismatch sites become single calls. Runtime
policy uses a J5 resolver that takes its error constructor the same way.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@bryantderosier
bryantderosier force-pushed the feature/agent-persona-catalog-rpc branch from 0fa310a to c3358b4 Compare September 14, 2026 12:07
@Jacksondr5
Jacksondr5 merged commit 33c3c61 into j5/main Sep 14, 2026
20 checks passed
@Jacksondr5
Jacksondr5 deleted the feature/agent-persona-catalog-rpc branch September 14, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL 1,000+ effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants