Skip to content

fix(client-runtime): Normalize runtime agent labels - #84

Closed
bryantderosier wants to merge 0 commit into
feature/agent-persona-settingsfrom
feature/agent-runtime-semantics
Closed

bryantderosier wants to merge 0 commit into
feature/agent-persona-settingsfrom
feature/agent-runtime-semantics

Conversation

@bryantderosier

@bryantderosier bryantderosier commented Sep 3, 2026 •

Copy link
Copy Markdown
Collaborator

What does this implement or fix?

Adds one shared formatter for provider-native agent paths and prefixed labels so clients can present consistent, human-readable runtime agent names. For example, /root/security_review becomes Security review, and redundant Subagent: prefixes are removed.

This is PR 10 of 12 in GitHub stack pingdotgg#89. It targets feature/agent-persona-settings and depends on #85.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

How has this been tested?

The focused remaining-stack suite passed 234 tests across 10 files, including the shared subagent runtime presentation suite.

  • Focused tests pass locally
  • Existing behavior outside this layer remains covered
  • The branch diff passes git diff --check

Screenshots or GIFs (Optional)

Not applicable to this shared client-runtime formatting layer.

Merge order

This PR is part of GitHub stack pingdotgg#89. Merge from bottom to top:

#75 -> #76 -> #78 -> #79 -> #80 -> #81 -> #83 -> #82 -> #85 -> #84 -> #86 -> #118

Generated with GPT-5 using the Codex desktop app.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: d7504e52-2dce-4edd-a41f-bb2e17752c74

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 effective changed lines (test files excluded in mixed PRs). labels Sep 3, 2026
@bryantderosier
bryantderosier force-pushed the feature/agent-runtime-semantics branch from bf77ade to 990f93e Compare September 3, 2026 18:45
@github-actions github-actions Bot added size:XXL 1,000+ effective changed lines (test files excluded in mixed PRs). and removed size:S 10-29 effective changed lines (test files excluded in mixed PRs). labels Sep 3, 2026
@bryantderosier
bryantderosier changed the base branch from j5/main to feature/agent-persona-settings September 3, 2026 18:45
@bryantderosier bryantderosier self-assigned this Sep 3, 2026
@bryantderosier bryantderosier added size:S 10-29 effective changed lines (test files excluded in mixed PRs). and removed size:XXL 1,000+ effective changed lines (test files excluded in mixed PRs). labels Sep 3, 2026
@bryantderosier
bryantderosier force-pushed the feature/agent-persona-settings branch from 0136636 to ef60657 Compare September 8, 2026 14:32
@bryantderosier
bryantderosier force-pushed the feature/agent-runtime-semantics branch from 990f93e to 15dbbc2 Compare September 8, 2026 14:32
@bryantderosier
bryantderosier force-pushed the feature/agent-persona-settings branch from ef60657 to e144154 Compare September 8, 2026 14:53
@bryantderosier
bryantderosier force-pushed the feature/agent-runtime-semantics branch from 15dbbc2 to e5f5c65 Compare September 8, 2026 14:53
@bryantderosier
bryantderosier force-pushed the feature/agent-runtime-semantics branch from e5f5c65 to 08eb597 Compare September 8, 2026 16:10
@github-actions github-actions Bot added size:L 100-499 effective changed lines (test files excluded in mixed PRs). and removed size:S 10-29 effective changed lines (test files excluded in mixed PRs). labels Sep 8, 2026
@bryantderosier
bryantderosier force-pushed the feature/agent-runtime-semantics branch from 08eb597 to 1f0700b Compare September 8, 2026 16:23
@github-actions github-actions Bot removed the size:L 100-499 effective changed lines (test files excluded in mixed PRs). label Sep 8, 2026
@github-actions github-actions Bot added size:S 10-29 effective changed lines (test files excluded in mixed PRs). size:M 30-99 effective changed lines (test files excluded in mixed PRs). and removed size:S 10-29 effective changed lines (test files excluded in mixed PRs). labels Sep 8, 2026
@bryantderosier
bryantderosier force-pushed the feature/agent-runtime-semantics branch from 1f0700b to c451b10 Compare September 8, 2026 17:39
@github-actions github-actions Bot added size:S 10-29 effective changed lines (test files excluded in mixed PRs). and removed size:M 30-99 effective changed lines (test files excluded in mixed PRs). labels Sep 8, 2026
@bryantderosier
bryantderosier force-pushed the feature/agent-persona-settings branch from e9de0a9 to 4f84fa7 Compare September 9, 2026 12:52
@bryantderosier
bryantderosier force-pushed the feature/agent-runtime-semantics branch from c451b10 to 4f84fa7 Compare September 9, 2026 12:52
@github-actions github-actions Bot added size:XS 0-9 effective changed lines (test files excluded in mixed PRs). and removed size:S 10-29 effective changed lines (test files excluded in mixed PRs). labels Sep 9, 2026
@bryantderosier
bryantderosier removed this pull request from stack #89 September 9, 2026 13:01
@bryantderosier
bryantderosier deleted the feature/agent-runtime-semantics branch September 9, 2026 13:01
@bryantderosier

Copy link
Copy Markdown
Collaborator Author

Closed: the two subagent label helpers here existed only to feed the Agents panel restyle in #86, which is dropped from this stack to keep upstream rebases clean. Neither is part of the rebuilt stack. If the restyle is wanted, both belong in a PR against pingdotgg/t3code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant