Skip to content

[None][infra] Waive 4 failed cases for main in pre-merge 64735 - #20505

Merged
achartier merged 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20261017-094205
Oct 17, 2026
Merged

achartier merged 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20261017-094205

Conversation

@trtllm-agent

@trtllm-agent trtllm-agent commented Oct 17, 2026 •

Copy link
Copy Markdown
Collaborator

Auto-generated Waive PR

Created by: TensorRT LLM CI Report (requested by @YihuiLu512)
Target branch: main
Bug(s): 6946085

Waive entries added

unittest/_torch/executor/test_pytorch_model_engine.py::test_decoder_forward_routes_compile_bypass[True-False-False] SKIP (https://nvbugs/6946085)
unittest/_torch/executor/test_pytorch_model_engine.py::test_decoder_forward_routes_compile_bypass[True-False-True] SKIP (https://nvbugs/6946085)
unittest/_torch/executor/test_pytorch_model_engine.py::test_decoder_forward_routes_compile_bypass[True-True-False] SKIP (https://nvbugs/6946085)
unittest/_torch/executor/test_pytorch_model_engine.py::test_decoder_forward_routes_compile_bypass[True-True-True] SKIP (https://nvbugs/6946085)

This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.

Dev Engineer Review

The waiver list adds four SKIP entries for test_decoder_forward_routes_compile_bypass parameter combinations. Each entry references NVBUG 6946085. No source-code changes are reported. Review findings and test results were not provided.

QA Engineer Review

tests/integration/test_lists/waives.txt adds skips for [True-False-False], [True-False-True], [True-True-False], and [True-True-True]. Test code did not change. Coverage verdict: needs follow-up because these four combinations will not run while the waivers apply. Test results were not provided.

Per-File QA Perspective

  • tests/integration/test_lists/waives.txt: Adds four skip waivers linked to NVBUG 6946085. QA should verify that the waivers cover only the intended parameter combinations and are removed when the bug is resolved.

Bug(s): 6946085
Requested by: @YihuiLu512

Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
@YihuiLu512

Copy link
Copy Markdown
Collaborator

/bot skip --comment "waive only PR"

@github-actions

Copy link
Copy Markdown

Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements.

@coderabbitai

coderabbitai Bot commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/TensorRT-LLM/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 264ace34-9f6a-4279-b50f-a9d2a7e78f37
📥 Commits

Reviewing files that changed from the base of the PR and between 20d5469 and 6566826.

📒 Files selected for processing: 1
  • tests/integration/test_lists/waives.txt

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

The integration test skip list adds four test_decoder_forward_routes_compile_bypass parameterizations. Each entry is tracked by NVBUG 6946085.

Changes

Decoder-forward test skips

Layer / File(s) Summary
Add test skip entries
tests/integration/test_lists/waives.txt
The skip list adds four test_decoder_forward_routes_compile_bypass parameterizations, each tracked by NVBUG 6946085.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested reviewers: bowenfu

Merge Risk: ⚪ Minimal · up to 65668

The waivers are limited to the four intended test cases, leaving the other configurations active. No material merge risk was identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies an infrastructure waiver for four failed cases on the main branch. It uses the required [None][infra] format and matches the pull request changes.
Description check Passed The description explains that the PR adds four SKIP waiver entries, identifies bug 6946085, lists each affected test case, and states the target branch and waiver requester. It does not include the re…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains that the PR adds four SKIP waiver entries, identifies bug 6946085, lists each affected test case, and states the target branch and waiver requester. It does not include the repository template headings or checklist, but the required change context is complete for this auto-generated waiver PR.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #78635 [ skip ] triggered by Bot. Commit: 6566826 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #78635 [ skip ] completed with state SUCCESS. Commit: 6566826
Skipping testing for commit 6566826

Link to invocation

@chenfeiz0326

Copy link
Copy Markdown
Collaborator

@YihuiLu512 Could this be merged? It's approved, and its bot skip passed (PR_Github #78635).

On main, test_decoder_forward_routes_compile_bypass[True-*] fails in CPU-Generic-x86-1 and CPU-Generic-arm-1 on every pre-merge run. It also fails in main's own post-merge run (L0_PostMerge #3024), with:

TypeError: KeyType.new() got an unexpected keyword argument 'is_first_draft'

#19867 removed that field, and the test still passes it. Until this waive lands, every PR's L0 run on main fails those two stages, including #20252 (L0 #64782, #64799).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants