Repository navigation
fix(pull-requests): match native Gitea warning status semantics - #23
Conversation
|
@coderabbitai review |
|
|
Warning Review limit reachedNext included review available in 2 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Comment |
|
@coderabbitai review Please review this PR at its exact current head in stack pingdotgg#6. Verify correctness, regressions, security boundaries, and focused coverage against its current base, and report any actionable findings with file references. |
|
|
|
Merge verdict: NO-GO (review gates incomplete). Head:
No merge performed. Resume the independent code reviews when Fable is available, obtain the missing/current CodeRabbit approval where applicable, and recheck the exact head and base before merging. |
|
@coderabbitai approve The maintainer requests formal approval for the remaining PRs. Please assess the exact current head If branch configuration prevents formal approval, please state that explicitly. Independent Codex/Fable code verdicts are being refreshed separately; this request does not authorize merging or bypassing their findings. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
echo '=== checked-out commit ==='
git rev-parse HEAD
git status --short
echo '=== pull request metadata ==='
gh pr view 23 --repo RTVision/t3code --json number,headRefOid,baseRefName,baseRefOid,mergeable,state,isDraft,title
echo '=== merge base and changed files ==='
base_oid="$(gh pr view 23 --repo RTVision/t3code --json baseRefOid --jq .baseRefOid)"
head_oid="$(git rev-parse HEAD)"
merge_base="$(git merge-base "$base_oid" "$head_oid")"
printf 'base=%s\nhead=%s\nmerge_base=%s\n' "$base_oid" "$head_oid" "$merge_base"
git diff --stat "$merge_base" "$head_oid"
git diff --name-status "$merge_base" "$head_oid"
echo '=== changed file outlines ==='
git diff --name-only "$merge_base" "$head_oid" | while IFS= read -r file; do
echo "--- $file"
ast-grep outline "$file" --items all 2>&1 || true
doneLength of output: 6752 🏁 Script executed: #!/bin/bash
set -euo pipefail
base="256fd6fe51ce3e481eaed824fa585becd6bb9e2f"
head="93580c016f2f39f79ccc96d3b8abc44d0892d249"
echo '=== complete PR patch ==='
git diff --find-renames --find-copies --unified=80 "$base" "$head" -- \
apps/server/src/pullRequest/GiteaPullRequestApi.ts \
apps/server/src/pullRequest/GiteaPullRequestApi.test.ts
echo '=== Gitea status schema and status/check mapping locations ==='
rg -n -C 12 --type ts \
'(RawCombinedStatus|RawCommitStatus|checksState|CheckState|dedupeChecks|\.state\b|warning|failure|success|pending)' \
apps/server/src/pullRequest/GiteaPullRequestApi.ts \
apps/server/src/pullRequest/pullRequestChecks.ts \
apps/server/src/pullRequest/GiteaPullRequestApi.test.ts
echo '=== Comparable provider status mappings ==='
rg -n -C 10 --type ts \
'(warning|neutral|failure|pending|success).*(Check|check|state|State)|(Check|check|state|State).*(warning|neutral|failure|pending|success)' \
apps/server/src/pullRequest \
-g '!apps/server/src/pullRequest/GiteaPullRequestApi.ts' \
-g '!apps/server/src/pullRequest/GiteaPullRequestApi.test.ts'
echo '=== Gitea commit-status API call sites ==='
rg -n -C 8 --type ts \
'statuses|commit/status|combined.*status|RawCombinedStatus' \
apps/server/srcLength of output: 133774 ⚙️ CodeRabbit configuration inspected Length of output: 5505 🏁 Script executed: #!/bin/bash
set -euo pipefail
repo="RTVision/t3code"
head="93580c016f2f39f79ccc96d3b8abc44d0892d249"
echo '=== reviews on pull request `#23` ==='
gh pr view 23 --repo "$repo" --json reviews,reviewDecision,statusCheckRollup
echo '=== check suites and check runs for requested head ==='
gh api "repos/$repo/commits/$head/check-runs" \
-H 'Accept: application/vnd.github+json' \
--paginate \
--jq '.check_runs[] | {name,status,conclusion,started_at,completed_at,details_url}'
echo '=== commit statuses for requested head ==='
gh api "repos/$repo/commits/$head/status" \
-H 'Accept: application/vnd.github+json' \
--jq '{state, statuses: [.statuses[] | {context,state,description,target_url}]}'
echo '=== relevant package scripts (inspection only) ==='
fd -a '^package\.json$' . -E node_modules -E dist -E build -x sh -c '
echo "--- $1"
jq "{name, scripts}" "$1"
' sh {}Length of output: 11220
I found no actionable correctness, regression, or security-boundary blocker. The change in I could not independently execute the test suite in this sandbox. I cannot submit a formal APPROVED review. The active configuration sets You are interacting with an AI system. |
|
Merge verdict: NO-GO. This supersedes the earlier quota-only readiness comment. Reviewed head:
Validation: 339 focused integrated PR tests plus 502 cross-provider tests passed at integration head No merge is authorized while any blocker or required approval is outstanding. Recheck the resulting head and current base after corrections or stack merges. This PR also belongs to the native Gitea stack: merging it would merge lower open members, including blocked #4/#5. Those predecessor gates must pass too. |
|
GO on the individual change — merge blocked by stack Reviewed commit: Codex and Claude Fable 5.1 both approve mapping native Gitea warning status to failure rather than neutral, preserving the host’s failing-check semantics. GitHub native-stack merging includes preceding PRs, including rejected #21. Hold this merge until the prefix is cleared. Validation by Codex: the exact #36 integration head Reviewers: Codex and Claude Fable 5.1 (Claude CLI). |
|
@coderabbitai review Please independently review the newly pushed fixes at |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
repo="RTVision/t3code"
requested_head="a1b46cd996aa147c02cf3970cf66ec416b20f384"
echo '=== checked-out commit ==='
git rev-parse HEAD
git status --short
echo '=== pull request metadata ==='
gh pr view 23 --repo "$repo" --json number,state,isDraft,title,baseRefName,baseRefOid,headRefName,headRefOid,mergeable,reviewDecision
echo '=== requested commit ==='
git cat-file -t "$requested_head"
git show -s --format='commit=%H%nparents=%P%nsubject=%s%n' "$requested_head"
base="$(gh pr view 23 --repo "$repo" --json baseRefOid --jq .baseRefOid)"
merge_base="$(git merge-base "$base" "$requested_head")"
printf 'base=%s\nrequested_head=%s\nmerge_base=%s\n' "$base" "$requested_head" "$merge_base"
echo '=== changed files against current merge base ==='
git diff --stat "$merge_base" "$requested_head"
git diff --name-status "$merge_base" "$requested_head"
echo '=== changed file outlines ==='
git diff --name-only "$merge_base" "$requested_head" | while IFS= read -r file; do
echo "--- $file"
ast-grep outline "$file" --items all 2>&1 || true
done
echo '=== patch ==='
git diff --find-renames --find-copies --unified=60 "$merge_base" "$requested_head"
echo '=== relevant test and check scripts ==='
fd -a '^package\.json$' . -E node_modules -E dist -E build -x sh -c '
echo "--- $1"
jq "{name, scripts}" "$1"
' sh {}Length of output: 17993 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo '=== duplicate regression test context with line numbers ==='
nl -ba apps/server/src/pullRequest/GiteaPullRequestApi.test.ts | sed -n '1620,1715p'
echo '=== warning-status mapping implementation ==='
rg -n -C 12 --type ts \
'(status|state).*warning|warning.*(status|state)|listChecks\s*[:=]|\blistChecks\s*\(' \
apps/server/src/pullRequest/GiteaPullRequestApi.ts \
apps/server/src/pullRequest/GiteaPullRequestApi.test.ts
echo '=== exact duplicate test-name occurrences ==='
rg -n -C 3 --type ts \
'it\.effect\("maps native warning statuses to failing checks"' \
apps/server/src/pullRequest/GiteaPullRequestApi.test.ts
echo '=== current CodeRabbit review configuration ==='
if [ -f .coderabbit.yaml ]; then
sed -n '1,240p' .coderabbit.yaml
elif [ -f .coderabbit.yml ]; then
sed -n '1,240p' .coderabbit.yml
else
echo 'No repository CodeRabbit configuration file found.'
fiLength of output: 1331 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo '=== duplicate regression test context with line numbers ==='
awk 'NR >= 1620 && NR <= 1715 { printf "%6d\t%s\n", NR, $0 }' \
apps/server/src/pullRequest/GiteaPullRequestApi.test.ts
echo '=== warning-status mapping implementation ==='
rg -n -C 12 --type ts \
'(status|state).*warning|warning.*(status|state)|listChecks\s*[:=]|\blistChecks\s*\(' \
apps/server/src/pullRequest/GiteaPullRequestApi.ts \
apps/server/src/pullRequest/GiteaPullRequestApi.test.ts
echo '=== exact duplicate test-name occurrences ==='
rg -n -C 3 --type ts \
'it\.effect\("maps native warning statuses to failing checks"' \
apps/server/src/pullRequest/GiteaPullRequestApi.test.ts
echo '=== current CodeRabbit review configuration ==='
if [ -f .coderabbit.yaml ]; then
sed -n '1,240p' .coderabbit.yaml
elif [ -f .coderabbit.yml ]; then
sed -n '1,240p' .coderabbit.yml
else
echo 'No repository CodeRabbit configuration file found.'
fiLength of output: 20381
I found one actionable issue. I cannot submit approval on this head.
The implementation still maps Gitea The active configuration enables You are interacting with an AI system. |
|
Re-review: NO-GO for merging now Reviewed head: The warning-to-failure behavior is correct and already carried in the base. CodeRabbit withholds approval because this head duplicates the identical warning-status regression test. Codex regards that duplication as cleanup rather than a product defect, but no new CodeRabbit GO has been obtained. Fable 5.1: GO; considers the duplicate test a cosmetic cleanup. CodeRabbit has withheld its GO. Remove the duplicate regression and obtain a fresh CodeRabbit decision. The inherited #9/#10/#12/#21 defects and #5 integration conflict also block the native-stack merge. Validation by Codex: 308 focused tests across 9 files passed on integration head The remaining native-stack merges must clear their predecessors and the actual target branch. CodeRabbit’s commit-specific comments are distinguished from formal GitHub review records; rate-limited requests are not approvals. |
|
GO — merged after Codex, Fable 5.1, and CodeRabbit review. Reviewed head: Warning-to-failure mapping remains intact and the duplicate identical regression test has been removed. CodeRabbit reviewed every exact head and cleared the combined integration. Its commit-specific approval is recorded in that comment; this is not a claim of a new formal GitHub APPROVED review on each PR. All three reviewers require #26 to land with #27 or later; they merged together in the dependency batch. Validation by Codex: 490 focused tests across 13 files passed on integration head Merged: |
1 participant
A Gitea warning commit status contributes to a failing native check summary, but the PR detail previously showed that check as neutral. Map warning to failure so the list and detail agree with Gitea’s native status combiner.
The 59 focused Gitea API tests, final server typecheck, and targeted lint pass, including a warning-status regression. This adds one case to the integrated stack’s 228 previously passing focused tests.
Model: GPT-6 Astra; native-source audit GPT-5.6 Luna. Harness: Codex.