Polish Share Compute settings by klopez4212 · Pull Request #3735 · block/buzz

klopez4212 · 2026-07-30T13:24:34Z

Summary

Refresh Share Compute with the shared agent-style model controls.
Reveal sharing details and advanced options only while sharing.
Remove the preview-only mesh API path.

Validation

pnpm check
pnpm test
pnpm exec playwright test tests/e2e/mesh-compute.spec.ts

Snapshots are attached in a follow-up comment.

klopez4212 · 2026-07-30T13:26:43Z

🤖 ## Screenshots

Before sharing

While sharing

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 723515b547

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e1b1eb012e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

klopez4212 · 2026-07-30T14:04:18Z

🤖 @codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 02982e4c97

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: kenny lopez <klopez4212@gmail.com>

wesbillman · 2026-08-03T16:07:47Z

Posting this review finding on Wes's behalf to help get the PR green:

Blocking: the new start-flow E2E test fails because the mesh mock does not retain the requested model.

The test selects hf://demo/SmolLM2..., starts sharing, and expects the status to show SmolLM2 135M (desktop/tests/e2e/mesh-compute.spec.ts:18-55). However, mesh_start_node updates only the mock state/mode, and the resulting status is built from mockMeshState.models[0] (desktop/src/testing/e2eBridge.ts:9651-9661, 9766-9772). That first catalog entry is Gemma, so CI consistently receives SharingGemma 4 E4B... instead.

Please have the mock retain request.modelId and expose that selected model through subsequent mesh_node_status calls. That preserves the test's intended contract: the model selected at start is reflected in status. Alternatively, the assertion would need to be narrowed to what the mock actually promises, but fixing the mock is the more useful behavior here.

This is the failure currently taking down Desktop Smoke E2E (3) and the aggregate Desktop check on head d09ab41c65c8980af6be645493d6434f42c21b35.

…ute-settings Signed-off-by: kenny lopez <klopez4212@gmail.com>

Signed-off-by: kenny lopez <klopez4212@gmail.com>

klopez4212 · 2026-08-03T16:20:51Z

🤖 Implemented locally in 946a8e6a5. The E2E bridge now records request.modelId as the active model and returns it from subsequent mesh_node_status calls, without changing the installed-model catalog. The smoke test again verifies the selected SmolLM2 135M status and passes (2 passed).

The commit is not yet pushed: the required pre-push build currently runs out of local disk space.

…ute-settings Signed-off-by: kenny lopez <klopez4212@gmail.com>

…onfig * origin/main: (76 commits) Polish Share Compute settings (#3735) fix(reactions): wrap long popover names (#3834) fix(desktop): clarify inherited agent parallelism (#4010) feat(desktop): make onboarding model defaults skippable (#3968) ci: add guarded desktop release cache prewarm (#4575) fix(mobile): recover stale relay sessions (#4372) chore(release): release Buzz Desktop version 0.5.4 (#4562) test(mobile): assert follow boundary semantics (#4559) docs(release): align desktop handoff instructions (#3988) fix: report agent usage per provider round, not once per turn (#4545) fix(desktop): harden Windows installs against Defender block and orphaned Node (#4382) feat(desktop): improve channel template discovery (#4549) fix(desktop): save key backups to authorized path (#4022) Add channel activity hover menu (#3935) feat(desktop): show saved Run on settings when editing an agent (#4539) fix(desktop): disambiguate provider API key labels and annotate mint key (#4406) fix(desktop): make OpenAI key re-enterable after first save in card mint dialog (#4140) fix(config-bridge): add harness-definition env tier and fix equal-value model override (#3580) Polish mobile composer and messaging UI (#3918) ci(linux): enable mesh-llm feature in Linux release and canary builds (#4524) ... Signed-off-by: npub1223z34hd7vtwc6qj4s7flsxkj644nlre2nthu7lrrmkumhu3xddsrx9r6w <52a228d6edf316ec6812ac3c9fc0d696ab59fc7954d77e7be31eedcddf91335b@buzz.block.builderlab.xyz> Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>

…al-agent-store * origin/main: Polish Share Compute settings (#3735) fix(reactions): wrap long popover names (#3834) fix(desktop): clarify inherited agent parallelism (#4010) feat(desktop): make onboarding model defaults skippable (#3968) ci: add guarded desktop release cache prewarm (#4575) fix(mobile): recover stale relay sessions (#4372) chore(release): release Buzz Desktop version 0.5.4 (#4562) test(mobile): assert follow boundary semantics (#4559) docs(release): align desktop handoff instructions (#3988) fix: report agent usage per provider round, not once per turn (#4545) fix(desktop): harden Windows installs against Defender block and orphaned Node (#4382) Signed-off-by: npub1mn7jgtj4w2pd0g0zeuhxsa6jy6p0rewxz4kujt98my82ahfmp72sxjexk7 <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>

…er-snapshots * origin/main: (29 commits) feat(agents): model-tuning parity in global Agent Defaults editor (#4578) Polish Share Compute settings (#3735) fix(reactions): wrap long popover names (#3834) fix(desktop): clarify inherited agent parallelism (#4010) feat(desktop): make onboarding model defaults skippable (#3968) ci: add guarded desktop release cache prewarm (#4575) fix(mobile): recover stale relay sessions (#4372) chore(release): release Buzz Desktop version 0.5.4 (#4562) test(mobile): assert follow boundary semantics (#4559) docs(release): align desktop handoff instructions (#3988) fix: report agent usage per provider round, not once per turn (#4545) fix(desktop): harden Windows installs against Defender block and orphaned Node (#4382) feat(desktop): improve channel template discovery (#4549) fix(desktop): save key backups to authorized path (#4022) Add channel activity hover menu (#3935) feat(desktop): show saved Run on settings when editing an agent (#4539) fix(desktop): disambiguate provider API key labels and annotate mint key (#4406) fix(desktop): make OpenAI key re-enterable after first save in card mint dialog (#4140) fix(config-bridge): add harness-definition env tier and fix equal-value model override (#3580) Polish mobile composer and messaging UI (#3918) ... Signed-off-by: npub1223z34hd7vtwc6qj4s7flsxkj644nlre2nthu7lrrmkumhu3xddsrx9r6w <52a228d6edf316ec6812ac3c9fc0d696ab59fc7954d77e7be31eedcddf91335b@buzz.block.builderlab.xyz> Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>

Requested by Tyler (buzz-tui df272ea1): pull main into PR #4347 as a new commit on top, no rebase, no force. Conflict-free (predicted by merge-tree d2fb4d4 before merging; realized tree verified to match). Main freight is 8 commits (651f637..ede8d22), none touching the terminal lane: * commit 'ede8d22dd5b336f146e0a6d760fd9dff78a42613': feat(mobile): bring channel menus to desktop parity (#3940) feat(agents): model-tuning parity in global Agent Defaults editor (#4578) Polish Share Compute settings (#3735) fix(reactions): wrap long popover names (#3834) fix(desktop): clarify inherited agent parallelism (#4010) feat(desktop): make onboarding model defaults skippable (#3968) ci: add guarded desktop release cache prewarm (#4575) fix(mobile): recover stale relay sessions (#4372) Co-authored-by: npub1qyvc0c5kl4gqv2fd97fsk46tu378sqgy35vc83rvgfwne90sel7s0ed67d <011987e296fd5006292d2f930b574be47c7801048d1983c46c425d3c95f0cffd@buzz.block.builderlab.xyz> Signed-off-by: npub1qyvc0c5kl4gqv2fd97fsk46tu378sqgy35vc83rvgfwne90sel7s0ed67d <011987e296fd5006292d2f930b574be47c7801048d1983c46c425d3c95f0cffd@buzz.block.builderlab.xyz>

…roll-navigation * origin/main: feat(mobile): bring channel menus to desktop parity (#3940) feat(agents): model-tuning parity in global Agent Defaults editor (#4578) Polish Share Compute settings (#3735) fix(reactions): wrap long popover names (#3834) fix(desktop): clarify inherited agent parallelism (#4010) feat(desktop): make onboarding model defaults skippable (#3968) ci: add guarded desktop release cache prewarm (#4575) fix(mobile): recover stale relay sessions (#4372) chore(release): release Buzz Desktop version 0.5.4 (#4562) test(mobile): assert follow boundary semantics (#4559) docs(release): align desktop handoff instructions (#3988) fix: report agent usage per provider round, not once per turn (#4545) fix(desktop): harden Windows installs against Defender block and orphaned Node (#4382) feat(desktop): improve channel template discovery (#4549) fix(desktop): save key backups to authorized path (#4022) Add channel activity hover menu (#3935) Signed-off-by: npub1223z34hd7vtwc6qj4s7flsxkj644nlre2nthu7lrrmkumhu3xddsrx9r6w <52a228d6edf316ec6812ac3c9fc0d696ab59fc7954d77e7be31eedcddf91335b@buzz.block.builderlab.xyz> Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>

* origin/main: (323 commits) feat(desktop): redesign the Huddle experience (block#4281) feat(mobile): bring channel menus to desktop parity (block#3940) feat(agents): model-tuning parity in global Agent Defaults editor (block#4578) Polish Share Compute settings (block#3735) fix(reactions): wrap long popover names (block#3834) fix(desktop): clarify inherited agent parallelism (block#4010) feat(desktop): make onboarding model defaults skippable (block#3968) ci: add guarded desktop release cache prewarm (block#4575) fix(mobile): recover stale relay sessions (block#4372) chore(release): release Buzz Desktop version 0.5.4 (block#4562) test(mobile): assert follow boundary semantics (block#4559) docs(release): align desktop handoff instructions (block#3988) fix: report agent usage per provider round, not once per turn (block#4545) fix(desktop): harden Windows installs against Defender block and orphaned Node (block#4382) feat(desktop): improve channel template discovery (block#4549) fix(desktop): save key backups to authorized path (block#4022) Add channel activity hover menu (block#3935) feat(desktop): show saved Run on settings when editing an agent (block#4539) fix(desktop): disambiguate provider API key labels and annotate mint key (block#4406) fix(desktop): make OpenAI key re-enterable after first save in card mint dialog (block#4140) ... Co-authored-by: npub1h39jmnd4xkwvmcx5najarhdxjkysvd9x5w7vsg6xuwpr9y62whvsmt2ghj <bc4b2dcdb5359ccde0d49f65d1dda695890634a6a3bcc82346e38232934a75d9@buzz.block.builderlab.xyz> Co-authored-by: Smarty <bc4b2dcdb5359ccde0d49f65d1dda695890634a6a3bcc82346e38232934a75d9@buzz.block.builderlab.xyz> Signed-off-by: npub1h39jmnd4xkwvmcx5najarhdxjkysvd9x5w7vsg6xuwpr9y62whvsmt2ghj <bc4b2dcdb5359ccde0d49f65d1dda695890634a6a3bcc82346e38232934a75d9@buzz.block.builderlab.xyz> # Conflicts: # crates/buzz-cli/src/commands/repos.rs

…gent-instructions * origin/main: (42 commits) feat(desktop): redesign the Huddle experience (block#4281) feat(mobile): bring channel menus to desktop parity (block#3940) feat(agents): model-tuning parity in global Agent Defaults editor (block#4578) Polish Share Compute settings (block#3735) fix(reactions): wrap long popover names (block#3834) fix(desktop): clarify inherited agent parallelism (block#4010) feat(desktop): make onboarding model defaults skippable (block#3968) ci: add guarded desktop release cache prewarm (block#4575) fix(mobile): recover stale relay sessions (block#4372) chore(release): release Buzz Desktop version 0.5.4 (block#4562) test(mobile): assert follow boundary semantics (block#4559) docs(release): align desktop handoff instructions (block#3988) fix: report agent usage per provider round, not once per turn (block#4545) fix(desktop): harden Windows installs against Defender block and orphaned Node (block#4382) feat(desktop): improve channel template discovery (block#4549) fix(desktop): save key backups to authorized path (block#4022) Add channel activity hover menu (block#3935) feat(desktop): show saved Run on settings when editing an agent (block#4539) fix(desktop): disambiguate provider API key labels and annotate mint key (block#4406) fix(desktop): make OpenAI key re-enterable after first save in card mint dialog (block#4140) ... Signed-off-by: Alex Rosenzweig <arosenzweig@squareup.com>

…theme-config * origin/main: (81 commits) feat(mobile): sync per-group channel sorting (#4231) feat(mobile): add channel scroll navigation (#4239) feat(desktop): redesign the Huddle experience (#4281) feat(mobile): bring channel menus to desktop parity (#3940) feat(agents): model-tuning parity in global Agent Defaults editor (#4578) Polish Share Compute settings (#3735) fix(reactions): wrap long popover names (#3834) fix(desktop): clarify inherited agent parallelism (#4010) feat(desktop): make onboarding model defaults skippable (#3968) ci: add guarded desktop release cache prewarm (#4575) fix(mobile): recover stale relay sessions (#4372) chore(release): release Buzz Desktop version 0.5.4 (#4562) test(mobile): assert follow boundary semantics (#4559) docs(release): align desktop handoff instructions (#3988) fix: report agent usage per provider round, not once per turn (#4545) fix(desktop): harden Windows installs against Defender block and orphaned Node (#4382) feat(desktop): improve channel template discovery (#4549) fix(desktop): save key backups to authorized path (#4022) Add channel activity hover menu (#3935) feat(desktop): show saved Run on settings when editing an agent (#4539) ... Signed-off-by: npub1223z34hd7vtwc6qj4s7flsxkj644nlre2nthu7lrrmkumhu3xddsrx9r6w <52a228d6edf316ec6812ac3c9fc0d696ab59fc7954d77e7be31eedcddf91335b@buzz.block.builderlab.xyz> Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>

Resolves two conflicts against main: AppShell.tsx: HEAD had const { activeCommunity, reinitKey } = communitiesHook for the composite workspace key; origin/main added useHuddlePresentation() destructuring from the Huddle redesign (#4281). Resolution keeps both: the composite key is required for useManagedAgentRuntimeReconciliation, and the Huddle hooks are needed for the new Huddle UI. MeshComputeSettingsCard.tsx: HEAD had the Stop using shared compute affordance plus the legacy inline model section; origin/main (#3735) replaced the inline model section with the MeshModelPicker component. Resolution keeps the Stop button block and adopts the MeshModelPicker layout, discarding the replaced inline model controls. Also corrects the false comment at runtime_commands_tests.rs:342-345 that claimed compensate_drain is covered by the desktop integration test suite. The compensation round-trip requires an AppHandle; the codebase has no tauri::test harness and no AppHandle mock. The honest coverage statement is: drain-prefix contract proven by unit test, restart path integration-only. Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>

klopez4212 added a commit that referenced this pull request Jul 30, 2026

screenshots: PR #3735

edadc8b

klopez4212 marked this pull request as ready for review July 30, 2026 13:50

klopez4212 requested a review from a team as a code owner July 30, 2026 13:50

chatgpt-codex-connector Bot reviewed Jul 30, 2026

View reviewed changes

Comment thread desktop/src/features/mesh-compute/ui/MeshComputeSettingsCard.tsx

Comment thread desktop/src/features/mesh-compute/ui/MeshComputeSettingsCard.tsx Outdated

chatgpt-codex-connector Bot reviewed Jul 30, 2026

View reviewed changes

Comment thread desktop/src/features/mesh-compute/ui/MeshComputeSettingsCard.tsx

chatgpt-codex-connector Bot reviewed Jul 30, 2026

View reviewed changes

Comment thread desktop/src/features/settings/ui/AgentDefaultsSettingsCard.tsx Outdated

klopez4212 force-pushed the kennylopez-share-compute-settings branch 2 times, most recently from 9330c27 to 0c4f56f Compare July 30, 2026 15:07

klopez4212 added 5 commits July 30, 2026 17:02

Polish Share Compute settings

9c1f8fb

Signed-off-by: kenny lopez <klopez4212@gmail.com>

test(desktop): cover share compute picker

5e4713f

Signed-off-by: kenny lopez <klopez4212@gmail.com>

fix(desktop): preserve share compute options

790cb7f

Signed-off-by: kenny lopez <klopez4212@gmail.com>

fix(desktop): preserve custom mesh model edits

7383bdb

Signed-off-by: kenny lopez <klopez4212@gmail.com>

fix(desktop): keep agent defaults editable

d09ab41

Signed-off-by: kenny lopez <klopez4212@gmail.com>

klopez4212 force-pushed the kennylopez-share-compute-settings branch from 0c4f56f to d09ab41 Compare July 30, 2026 16:03

test(desktop): select share compute model in e2e

c7b10cf

Signed-off-by: kenny lopez <klopez4212@gmail.com>

klopez4212 added 2 commits August 3, 2026 17:15

Merge remote-tracking branch 'origin/main' into kennylopez-share-comp…

b438f85

…ute-settings Signed-off-by: kenny lopez <klopez4212@gmail.com>

test(desktop): retain selected mesh model in e2e

946a8e6

Signed-off-by: kenny lopez <klopez4212@gmail.com>

Merge remote-tracking branch 'origin/main' into kennylopez-share-comp…

30f0404

…ute-settings Signed-off-by: kenny lopez <klopez4212@gmail.com>

wesbillman merged commit 027a74a into main Aug 3, 2026
49 of 50 checks passed

wesbillman deleted the kennylopez-share-compute-settings branch August 3, 2026 21:12

adrienlacombe mentioned this pull request Aug 4, 2026

[upstream-sync] Merge block/buzz into adrienlacombe/buzz (27 commits) adrienlacombe/buzz#17

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Polish Share Compute settings - #3735

Polish Share Compute settings#3735
wesbillman merged 9 commits into
mainfrom
kennylopez-share-compute-settings

klopez4212 commented Jul 30, 2026

Uh oh!

klopez4212 commented Jul 30, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

klopez4212 commented Jul 30, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

wesbillman commented Aug 3, 2026

Uh oh!

klopez4212 commented Aug 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

klopez4212 commented Jul 30, 2026

Summary

Validation

Uh oh!

klopez4212 commented Jul 30, 2026

Before sharing

While sharing

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

klopez4212 commented Jul 30, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

wesbillman commented Aug 3, 2026

Uh oh!

klopez4212 commented Aug 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants