Skip to content

fix(reactions): wrap long popover names - #3834

Merged
wesbillman merged 5 commits into
mainfrom
tho/reaction-popover-wrap
Aug 3, 2026
Merged

fix(reactions): wrap long popover names#3834
wesbillman merged 5 commits into
mainfrom
tho/reaction-popover-wrap

Conversation

@tellaho

@tellaho tellaho commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Category: fix
User Impact: Long custom emoji names now stay contained inside reaction popovers and remain fully readable.

Problem: An unbroken custom emoji name could force a reaction popover beyond its intended maximum width and overflow the message view.

Solution: Give the reaction popover a definite 288px width and allow the complete emoji name to wrap within it without truncation or ellipsis. Short names retain the same content and interaction behavior.

File changes

desktop/src/features/messages/ui/MessageReactions.tsx
Bounds the reaction popover width and allows long names to break across lines while preserving the full shortcode.

desktop/tests/e2e/reaction-names.spec.ts
Covers fixed width, full text preservation, and wrapping for the maximum supported colon-wrapped reaction name, with deterministic seeded Picsum visual fixtures and explicit image-load waits.

Reproduction Steps

  1. Open a message with a custom emoji reaction whose name is 64 characters.
  2. Hover or focus the reaction pill to open its details popover.
  3. Confirm the popover remains 288px wide and the complete name wraps within it without ellipsis.
  4. Open a short-name reaction and confirm its popover remains readable and unchanged in behavior.

Screenshots

Before After
Maximum-length name before Maximum-length name after

Short-name regression check

Short reaction name

Verification

  • pnpm test in desktop: 3,858 passed
  • Focused reaction-name E2E with seeded Picsum captures: 2 passed
  • Desktop checks and commit hooks passed

Originating Buzz channel: f2ec9671-d78e-4cde-894c-9f4c458c7f1f

npub1223z34hd7vtwc6qj4s7flsxkj644nlre2nthu7lrrmkumhu3xddsrx9r6w and others added 2 commits July 30, 2026 16:45
npub1223z34hd7vtwc6qj4s7flsxkj644nlre2nthu7lrrmkumhu3xddsrx9r6w @tellaho
fix(reactions): wrap long popover names
5ea7a24 
Co-authored-by: Taylor Ho <taylorkmho@gmail.com>
Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
npub1223z34hd7vtwc6qj4s7flsxkj644nlre2nthu7lrrmkumhu3xddsrx9r6w @tellaho
test(reactions): seed popover screenshots
f8cb907 
Co-authored-by: Taylor Ho <taylorkmho@gmail.com>
Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
@tellaho
tellaho marked this pull request as ready for review July 31, 2026 03:36
@tellaho
tellaho requested a review from a team as a code owner July 31, 2026 03:36
@block block deleted a comment from chatgpt-codex-connector Bot Jul 31, 2026
@tellaho

tellaho commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

@codex

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 31, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f8cb907e3b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/tests/e2e/reaction-names.spec.ts Outdated
npub1223z34hd7vtwc6qj4s7flsxkj644nlre2nthu7lrrmkumhu3xddsrx9r6w and others added 2 commits July 30, 2026 21:02
npub1223z34hd7vtwc6qj4s7flsxkj644nlre2nthu7lrrmkumhu3xddsrx9r6w @tellaho
test(desktop): intercept reaction avatar fixtures
84fe04a 
Co-authored-by: Taylor Ho <taylorkmho@gmail.com>
Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
npub1223z34hd7vtwc6qj4s7flsxkj644nlre2nthu7lrrmkumhu3xddsrx9r6w @tellaho
test(desktop): use neutral avatar fixture urls
a7e70e8 
Co-authored-by: Taylor Ho <taylorkmho@gmail.com>
Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
@tellaho tellaho mentioned this pull request Jul 31, 2026
Draft
@Chessing234

Chessing234 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

looks clean. can the e2e assert the popover width stays <= 288 so a future css tweak doesnt silently rebreak it?

@tellaho

tellaho commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

@Chessing234 we have that check here https://github.com/block/buzz/pull/3834/changes#diff-9e16b38bbb858e716142e360a6cdfedd3efefdf3347b5bd0b48473f52c00abcfR190 thank

wesbillman
wesbillman previously approved these changes Aug 3, 2026
View reviewed changes
npub1223z34hd7vtwc6qj4s7flsxkj644nlre2nthu7lrrmkumhu3xddsrx9r6w @tellaho
test(desktop): inline reaction avatar fixtures
88d2445 
Co-authored-by: Taylor Ho <taylorkmho@gmail.com>
Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
@wesbillman
wesbillman merged commit 7981597 into main Aug 3, 2026
27 checks passed
@wesbillman
wesbillman deleted the tho/reaction-popover-wrap branch August 3, 2026 21:09
tellaho added a commit that referenced this pull request Aug 3, 2026
npub1223z34hd7vtwc6qj4s7flsxkj644nlre2nthu7lrrmkumhu3xddsrx9r6w @tellaho
Merge remote-tracking branch 'origin/main' into tho/community-theme-c…
154b776 
…onfig

* origin/main: (76 commits)
  Polish Share Compute settings (#3735)
  fix(reactions): wrap long popover names (#3834)
  fix(desktop): clarify inherited agent parallelism (#4010)
  feat(desktop): make onboarding model defaults skippable (#3968)
  ci: add guarded desktop release cache prewarm (#4575)
  fix(mobile): recover stale relay sessions (#4372)
  chore(release): release Buzz Desktop version 0.5.4 (#4562)
  test(mobile): assert follow boundary semantics (#4559)
  docs(release): align desktop handoff instructions (#3988)
  fix: report agent usage per provider round, not once per turn (#4545)
  fix(desktop): harden Windows installs against Defender block and orphaned Node (#4382)
  feat(desktop): improve channel template discovery (#4549)
  fix(desktop): save key backups to authorized path (#4022)
  Add channel activity hover menu (#3935)
  feat(desktop): show saved Run on settings when editing an agent (#4539)
  fix(desktop): disambiguate provider API key labels and annotate mint key (#4406)
  fix(desktop): make OpenAI key re-enterable after first save in card mint dialog (#4140)
  fix(config-bridge): add harness-definition env tier and fix equal-value model override (#3580)
  Polish mobile composer and messaging UI (#3918)
  ci(linux): enable mesh-llm feature in Linux release and canary builds (#4524)
  ...

Signed-off-by: npub1223z34hd7vtwc6qj4s7flsxkj644nlre2nthu7lrrmkumhu3xddsrx9r6w <52a228d6edf316ec6812ac3c9fc0d696ab59fc7954d77e7be31eedcddf91335b@buzz.block.builderlab.xyz>
Co-authored-by: Taylor Ho <taylorkmho@gmail.com>
Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
wpfleger96 pushed a commit that referenced this pull request Aug 3, 2026
npub1mn7jgtj4w2pd0g0zeuhxsa6jy6p0rewxz4kujt98my82ahfmp72sxjexk7
Merge remote-tracking branch 'origin/main' into duncan/b1-transaction…
6b03cba 
…al-agent-store

* origin/main:
  Polish Share Compute settings (#3735)
  fix(reactions): wrap long popover names (#3834)
  fix(desktop): clarify inherited agent parallelism (#4010)
  feat(desktop): make onboarding model defaults skippable (#3968)
  ci: add guarded desktop release cache prewarm (#4575)
  fix(mobile): recover stale relay sessions (#4372)
  chore(release): release Buzz Desktop version 0.5.4 (#4562)
  test(mobile): assert follow boundary semantics (#4559)
  docs(release): align desktop handoff instructions (#3988)
  fix: report agent usage per provider round, not once per turn (#4545)
  fix(desktop): harden Windows installs against Defender block and orphaned Node (#4382)

Signed-off-by: npub1mn7jgtj4w2pd0g0zeuhxsa6jy6p0rewxz4kujt98my82ahfmp72sxjexk7 <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>
tellaho added a commit that referenced this pull request Aug 3, 2026
npub1223z34hd7vtwc6qj4s7flsxkj644nlre2nthu7lrrmkumhu3xddsrx9r6w @tellaho
Merge remote-tracking branch 'origin/main' into tho/link-preview-send…
ec97f6a 
…er-snapshots

* origin/main: (29 commits)
  feat(agents): model-tuning parity in global Agent Defaults editor (#4578)
  Polish Share Compute settings (#3735)
  fix(reactions): wrap long popover names (#3834)
  fix(desktop): clarify inherited agent parallelism (#4010)
  feat(desktop): make onboarding model defaults skippable (#3968)
  ci: add guarded desktop release cache prewarm (#4575)
  fix(mobile): recover stale relay sessions (#4372)
  chore(release): release Buzz Desktop version 0.5.4 (#4562)
  test(mobile): assert follow boundary semantics (#4559)
  docs(release): align desktop handoff instructions (#3988)
  fix: report agent usage per provider round, not once per turn (#4545)
  fix(desktop): harden Windows installs against Defender block and orphaned Node (#4382)
  feat(desktop): improve channel template discovery (#4549)
  fix(desktop): save key backups to authorized path (#4022)
  Add channel activity hover menu (#3935)
  feat(desktop): show saved Run on settings when editing an agent (#4539)
  fix(desktop): disambiguate provider API key labels and annotate mint key (#4406)
  fix(desktop): make OpenAI key re-enterable after first save in card mint dialog (#4140)
  fix(config-bridge): add harness-definition env tier and fix equal-value model override (#3580)
  Polish mobile composer and messaging UI (#3918)
  ...

Signed-off-by: npub1223z34hd7vtwc6qj4s7flsxkj644nlre2nthu7lrrmkumhu3xddsrx9r6w <52a228d6edf316ec6812ac3c9fc0d696ab59fc7954d77e7be31eedcddf91335b@buzz.block.builderlab.xyz>
Co-authored-by: Taylor Ho <taylorkmho@gmail.com>
Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
tlongwell-block pushed a commit that referenced this pull request Aug 3, 2026
npub1qyvc0c5kl4gqv2fd97fsk46tu378sqgy35vc83rvgfwne90sel7s0ed67d
Merge origin/main (ede8d22) into max/tui-renderer
c1e1ea2 
Requested by Tyler (buzz-tui df272ea1): pull main into PR #4347 as a new
commit on top, no rebase, no force. Conflict-free (predicted by merge-tree
d2fb4d4 before merging; realized tree verified to match). Main freight is
8 commits (651f637..ede8d22), none touching the terminal lane:

* commit 'ede8d22dd5b336f146e0a6d760fd9dff78a42613':
  feat(mobile): bring channel menus to desktop parity (#3940)
  feat(agents): model-tuning parity in global Agent Defaults editor (#4578)
  Polish Share Compute settings (#3735)
  fix(reactions): wrap long popover names (#3834)
  fix(desktop): clarify inherited agent parallelism (#4010)
  feat(desktop): make onboarding model defaults skippable (#3968)
  ci: add guarded desktop release cache prewarm (#4575)
  fix(mobile): recover stale relay sessions (#4372)

Co-authored-by: npub1qyvc0c5kl4gqv2fd97fsk46tu378sqgy35vc83rvgfwne90sel7s0ed67d <011987e296fd5006292d2f930b574be47c7801048d1983c46c425d3c95f0cffd@buzz.block.builderlab.xyz>
Signed-off-by: npub1qyvc0c5kl4gqv2fd97fsk46tu378sqgy35vc83rvgfwne90sel7s0ed67d <011987e296fd5006292d2f930b574be47c7801048d1983c46c425d3c95f0cffd@buzz.block.builderlab.xyz>
tellaho added a commit that referenced this pull request Aug 3, 2026
npub1223z34hd7vtwc6qj4s7flsxkj644nlre2nthu7lrrmkumhu3xddsrx9r6w @tellaho
Merge remote-tracking branch 'origin/main' into tho/mobile-channel-sc…
8578c1b 
…roll-navigation

* origin/main:
  feat(mobile): bring channel menus to desktop parity (#3940)
  feat(agents): model-tuning parity in global Agent Defaults editor (#4578)
  Polish Share Compute settings (#3735)
  fix(reactions): wrap long popover names (#3834)
  fix(desktop): clarify inherited agent parallelism (#4010)
  feat(desktop): make onboarding model defaults skippable (#3968)
  ci: add guarded desktop release cache prewarm (#4575)
  fix(mobile): recover stale relay sessions (#4372)
  chore(release): release Buzz Desktop version 0.5.4 (#4562)
  test(mobile): assert follow boundary semantics (#4559)
  docs(release): align desktop handoff instructions (#3988)
  fix: report agent usage per provider round, not once per turn (#4545)
  fix(desktop): harden Windows installs against Defender block and orphaned Node (#4382)
  feat(desktop): improve channel template discovery (#4549)
  fix(desktop): save key backups to authorized path (#4022)
  Add channel activity hover menu (#3935)

Signed-off-by: npub1223z34hd7vtwc6qj4s7flsxkj644nlre2nthu7lrrmkumhu3xddsrx9r6w <52a228d6edf316ec6812ac3c9fc0d696ab59fc7954d77e7be31eedcddf91335b@buzz.block.builderlab.xyz>
Co-authored-by: Taylor Ho <taylorkmho@gmail.com>
Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
AaronGoldsmith pushed a commit to AaronGoldsmith/buzz that referenced this pull request Aug 4, 2026
npub1h39jmnd4xkwvmcx5najarhdxjkysvd9x5w7vsg6xuwpr9y62whvsmt2ghj
Merge remote-tracking branch 'origin/main' into repos-list-all
202c54e 
* origin/main: (323 commits)
  feat(desktop): redesign the Huddle experience (block#4281)
  feat(mobile): bring channel menus to desktop parity (block#3940)
  feat(agents): model-tuning parity in global Agent Defaults editor (block#4578)
  Polish Share Compute settings (block#3735)
  fix(reactions): wrap long popover names (block#3834)
  fix(desktop): clarify inherited agent parallelism (block#4010)
  feat(desktop): make onboarding model defaults skippable (block#3968)
  ci: add guarded desktop release cache prewarm (block#4575)
  fix(mobile): recover stale relay sessions (block#4372)
  chore(release): release Buzz Desktop version 0.5.4 (block#4562)
  test(mobile): assert follow boundary semantics (block#4559)
  docs(release): align desktop handoff instructions (block#3988)
  fix: report agent usage per provider round, not once per turn (block#4545)
  fix(desktop): harden Windows installs against Defender block and orphaned Node (block#4382)
  feat(desktop): improve channel template discovery (block#4549)
  fix(desktop): save key backups to authorized path (block#4022)
  Add channel activity hover menu (block#3935)
  feat(desktop): show saved Run on settings when editing an agent (block#4539)
  fix(desktop): disambiguate provider API key labels and annotate mint key (block#4406)
  fix(desktop): make OpenAI key re-enterable after first save in card mint dialog (block#4140)
  ...

Co-authored-by: npub1h39jmnd4xkwvmcx5najarhdxjkysvd9x5w7vsg6xuwpr9y62whvsmt2ghj <bc4b2dcdb5359ccde0d49f65d1dda695890634a6a3bcc82346e38232934a75d9@buzz.block.builderlab.xyz>
Co-authored-by: Smarty <bc4b2dcdb5359ccde0d49f65d1dda695890634a6a3bcc82346e38232934a75d9@buzz.block.builderlab.xyz>
Signed-off-by: npub1h39jmnd4xkwvmcx5najarhdxjkysvd9x5w7vsg6xuwpr9y62whvsmt2ghj <bc4b2dcdb5359ccde0d49f65d1dda695890634a6a3bcc82346e38232934a75d9@buzz.block.builderlab.xyz>

# Conflicts:
#	crates/buzz-cli/src/commands/repos.rs
shellz-n-stuff added a commit to shellz-n-stuff/buzz that referenced this pull request Aug 4, 2026
@shellz-n-stuff
Merge remote-tracking branch 'origin/main' into codex/harden-shared-a…
d56523f 
…gent-instructions

* origin/main: (42 commits)
  feat(desktop): redesign the Huddle experience (block#4281)
  feat(mobile): bring channel menus to desktop parity (block#3940)
  feat(agents): model-tuning parity in global Agent Defaults editor (block#4578)
  Polish Share Compute settings (block#3735)
  fix(reactions): wrap long popover names (block#3834)
  fix(desktop): clarify inherited agent parallelism (block#4010)
  feat(desktop): make onboarding model defaults skippable (block#3968)
  ci: add guarded desktop release cache prewarm (block#4575)
  fix(mobile): recover stale relay sessions (block#4372)
  chore(release): release Buzz Desktop version 0.5.4 (block#4562)
  test(mobile): assert follow boundary semantics (block#4559)
  docs(release): align desktop handoff instructions (block#3988)
  fix: report agent usage per provider round, not once per turn (block#4545)
  fix(desktop): harden Windows installs against Defender block and orphaned Node (block#4382)
  feat(desktop): improve channel template discovery (block#4549)
  fix(desktop): save key backups to authorized path (block#4022)
  Add channel activity hover menu (block#3935)
  feat(desktop): show saved Run on settings when editing an agent (block#4539)
  fix(desktop): disambiguate provider API key labels and annotate mint key (block#4406)
  fix(desktop): make OpenAI key re-enterable after first save in card mint dialog (block#4140)
  ...

Signed-off-by: Alex Rosenzweig <arosenzweig@squareup.com>
@adrienlacombe adrienlacombe mentioned this pull request Aug 4, 2026
Open
tellaho added a commit that referenced this pull request Aug 4, 2026
npub1223z34hd7vtwc6qj4s7flsxkj644nlre2nthu7lrrmkumhu3xddsrx9r6w @tellaho
Merge remote-tracking branch 'origin/main' into tho/mobile-community-…
dab3ef8 
…theme-config

* origin/main: (81 commits)
  feat(mobile): sync per-group channel sorting (#4231)
  feat(mobile): add channel scroll navigation (#4239)
  feat(desktop): redesign the Huddle experience (#4281)
  feat(mobile): bring channel menus to desktop parity (#3940)
  feat(agents): model-tuning parity in global Agent Defaults editor (#4578)
  Polish Share Compute settings (#3735)
  fix(reactions): wrap long popover names (#3834)
  fix(desktop): clarify inherited agent parallelism (#4010)
  feat(desktop): make onboarding model defaults skippable (#3968)
  ci: add guarded desktop release cache prewarm (#4575)
  fix(mobile): recover stale relay sessions (#4372)
  chore(release): release Buzz Desktop version 0.5.4 (#4562)
  test(mobile): assert follow boundary semantics (#4559)
  docs(release): align desktop handoff instructions (#3988)
  fix: report agent usage per provider round, not once per turn (#4545)
  fix(desktop): harden Windows installs against Defender block and orphaned Node (#4382)
  feat(desktop): improve channel template discovery (#4549)
  fix(desktop): save key backups to authorized path (#4022)
  Add channel activity hover menu (#3935)
  feat(desktop): show saved Run on settings when editing an agent (#4539)
  ...

Signed-off-by: npub1223z34hd7vtwc6qj4s7flsxkj644nlre2nthu7lrrmkumhu3xddsrx9r6w <52a228d6edf316ec6812ac3c9fc0d696ab59fc7954d77e7be31eedcddf91335b@buzz.block.builderlab.xyz>
Co-authored-by: Taylor Ho <taylorkmho@gmail.com>
Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@wesbillman wesbillman wesbillman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tellaho @Chessing234 @wesbillman