test: use single-member in functional tests: feature_mnehf, feature_notifications, p2p_instantsend

[knst]

Issue being fixed or feature implemented

The ChainLock and InstantSend Notifications, P2P InstantSend and EHF feature tests only need the locks & ehf to happen, not a multi-member quorum.

What was done?

• fix: make mine_quorum_single_member usable right after setup
• fix: stall of single-member quorum due to mempool's sync
• use a single-member quorum in feature_mnehf
• use a single-member quorum in feature_notifications
• use a single-member quorum in p2p_instantsend
• moved testing of node's connection after restart to feature_llmq_connections

How Has This Been Tested?

CI run with tsan:
https://github.com/dashpay/dash/actions/runs/36907697165/job/110532135383?pr=7778
https://github.com/dashpay/dash/actions/runs/36752482052/job/110043834012

Test	develop (s)	PR (s)
feature_llmq_connections.py	142	157
feature_mnehf.py	102	74
feature_notifications.py	44	31
p2p_instantsend.py	100	56

Local run:

Test	develop (s)	PR (s)
feature_llmq_connections.py	80	88
feature_mnehf.py	49	41
feature_notifications.py	29	21
p2p_instantsend.py	81	42
ALL (accumulated)	239	192

Breaking Changes

N/A

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

[thepastaclaw]

✅ Final review complete — no blockers (commit e308b31)

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: c7ede566-151e-47df-a7eb-e12b0650a4cf

📥 Commits

Reviewing files that changed from the base of the PR and between a31fcf2 and e308b31.

📒 Files selected for processing (5)

• test/functional/feature_llmq_connections.py
• test/functional/feature_mnehf.py
• test/functional/feature_notifications.py
• test/functional/p2p_instantsend.py
• test/functional/test_framework/test_framework.py

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

---

Walkthrough

The functional tests now use smaller node and masternode setups with single-member quorum mining. The MNEHF test updates quorum selection and its window-boundary check. Post-restart peer verification and InstantSend coverage now run in the LLMQ connections test instead of the P2P InstantSend test.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Merge Risk: ⚪ Minimal · up to e308b

The quorum setup and relocated restart checks have no established merge-blocking defect. The relay safely accepts already-known transactions; merge after normal checks pass.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 4.55% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 22 functions across 5 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly identifies the main change: using single-member quorums in the listed functional tests. It omits related changes in feature_llmq_connections and the test framework, but it remains co…
Description check	✅ Passed	The description directly explains the single-member quorum changes, framework updates, moved restart coverage, and test results. It is clearly related to the changeset.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[thepastaclaw]

Final validation — Phase 1 + Phase 2

The PR efficiently reduces functional-test quorum overhead, but the MnEHF duplicate-signal case can construct a payload naming one quorum while signing it with another. The signing helper independently selects a quorum from the current chain, so the transaction may fail signature validation before the duplicate-bit behavior is exercised.

🔴 1 blocking

Review provenance

Source: reviewer 1: gemini-3.8-flash-high (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: dash-core-commit-history); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

• Triage: normal by gpt-6.1-sol (effort low) — This is a cross-cutting functional-test refactor affecting quorum setup, mempool synchronization, and test coverage across five files, but it does not change production consensus, networking, cryptography, funds, or storage behavior.
• Phase 1 reviewers: gemini-3.8-flash-high — general (completed, effort high); agent phase1-reviewer
• Phase 1 model: gemini-3.8-flash-high — antigravity quota: weekly 90% left, 5h 45% left
• Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
• Phase 2 reviewers: gpt-6.1-sol — general (completed, effort high); agent phase2-reviewer, gpt-6.1-sol — dash-core-commit-history (completed, effort high); agent phase2-reviewer

🤖 Prompt for all review comments with AI agents

These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.

In `test/functional/feature_mnehf.py`:
- [BLOCKING] test/functional/feature_mnehf.py:225: Sign the duplicate MnEHF transaction with the quorum named in its payload
  This call explicitly forces the payload's `quorumHash` to the original signal's quorum, but `create_mnehf()` still calls `get_recovered_sig(request_id, msgHash)` without passing that quorum. `get_recovered_sig()` independently runs `selectquorum` against the current chain and uses the selected quorum for signing. If selection has changed, the signature is produced by a different quorum than the one encoded in the payload. `CheckMNHFTx` verifies against the payload's quorum, so `send_tx()` can fail with an invalid MnEHF signature instead of testing duplicate-bit rejection. Make the signing helper accept and use the explicitly selected quorum, or otherwise reuse the original quorum's recovered signature.

[thepastaclaw]

🔴 Blocking: Sign the duplicate MnEHF transaction with the quorum named in its payload

This call explicitly forces the payload's quorumHash to the original signal's quorum, but create_mnehf() still calls get_recovered_sig(request_id, msgHash) without passing that quorum. get_recovered_sig() independently runs selectquorum against the current chain and uses the selected quorum for signing. If selection has changed, the signature is produced by a different quorum than the one encoded in the payload. CheckMNHFTx verifies against the payload's quorum, so send_tx() can fail with an invalid MnEHF signature instead of testing duplicate-bit rejection. Make the signing helper accept and use the explicitly selected quorum, or otherwise reuse the original quorum's recovered signature.

_{source: gpt-6.1-sol (phase2-reviewer: general)}

[knst]

The mismatch can't happen: the member has already voted on this request id
with the same msgHash, so quorum sign for the newly selected quorum is
refused ("already voted ... Not voting again", allowReSign=false) and
get_recovered_sig returns the existing recovered signature of the original
quorum, which is the one named in the payload.

That said, the pinned payload was byte-identical to the original signal, so
there is no reason to build and "sign" it again. Changed the duplicate step to
resend the original ehf_tx and dropped the quorumHash parameter from
create_mnehf.

[thepastaclaw]

Agreed. Reusing the original ehf_tx avoids attempting a second signature for the same request ID and preserves the original quorum hash and recovered signature, so this resolves the mismatch concern.

Marking this resolved.

[thepastaclaw]

Re-review after discussion — commit e308b31

Standing review was CHANGES_REQUESTED; this re-review is COMMENT: no blocking findings remain.

🔴 0 blocking | 🟡 0 suggestion(s) | 💬 0 nitpick(s)

No longer blocking:

• Sign the duplicate MnEHF transaction with the quorum named in its payload

Same commit as the standing review; the inline threads above carry the per-finding outcome. This follow-up exists only to correct the verdict.

Review provenance

Source: conversation lane gpt-6.1-sol (agent: conversation); no reviewer or verifier lanes ran for this follow-up

• Verdict moved because every blocking finding on this commit was withdrawn, resolved or deferred in the inline discussion; the code was not re-reviewed