Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Refactor object.d: Move __ArrayCast to rt - #2643

Merged
dlang-bot merged 1 commit into
dlang:masterfrom
JinShil:refactor_arraycast
Jun 19, 2019
Merged

dlang-bot merged 1 commit into
dlang:masterfrom
JinShil:refactor_arraycast

Conversation

@JinShil

@JinShil JinShil commented Jun 17, 2019

Copy link
Copy Markdown
Contributor

Followup to #2634

@n8sh

n8sh commented Jun 17, 2019

Copy link
Copy Markdown
Member

Is putting each function in a separate file the direction this is going? One file for __equals, one file for __ArrayCast?

@JinShil

JinShil commented Jun 17, 2019 •

Copy link
Copy Markdown
Contributor Author

Is putting each function in a separate file the direction this is going?

No. The idea is to leverage modules and packages as D's unit of encapsulation. Those functions/features/etc. that don't depend on each other should go into their own module.

When I attempt to move dup, __dopostblit, _trustedDup, etc., those would go together in one module, because there is a dependency between them.

Edit: It may turn out that there will basically be one public runtime hook per file, but that is not the motivation. The motivation is encapsulation.

@JinShil
JinShil marked this pull request as ready for review June 17, 2019 04:42
@dlang-bot

Copy link
Copy Markdown

Thanks for your pull request and interest in making D better, @JinShil! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2643"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants