Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Move compiler-support code in object.d to the bottom of the file with the others - #2775

Merged
dlang-bot merged 1 commit into
dlang:masterfrom
JinShil:move_hooks
Aug 30, 2019
Merged

dlang-bot merged 1 commit into
dlang:masterfrom
JinShil:move_hooks

Conversation

@JinShil

@JinShil JinShil commented Aug 30, 2019

Copy link
Copy Markdown
Contributor

Followup to #2647, #2644, #2643, #2634, #2763, #2765, #2766, #2769, #2772 , #2774

This is a continuation of work to clean up object.d.

This PR just moves the remaining individual compiler-support features to the bottom of the file to de-emphasize them and keep them separate from the code accessible to users.

@dlang-bot

Copy link
Copy Markdown

Thanks for your pull request and interest in making D better, @JinShil! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2775"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants