Move _d_assert_fail from object.d to core.internal.dassert.d - #2766
Conversation
|
Thanks for your pull request and interest in making D better, @JinShil! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + druntime#2766" |
|
All these object.d refactorings do seem to have a measurable effect on compilation times: However, the cost is very small - merely two milliseconds. |
|
For instruction count, I see the bump, but for real time, there seems to be a lot of noise, and I don't think it's possible to say one way or another. For example, there was a bump in real time for this PR, but all I did was delete code. |
|
Measuring CPU time is always going to be imprecise, however we can still see that the time is increasing (compare visually the left side and right side of the chart at that link). To find the cause why CPU time has increased, we can use a synthetic but exact metric which is generally directly correlated with it (in this case, # of instructions executed as reported by Callgrind). Using this method we can see that the execution time was increased by this & similar recent PRs. |
Followup to #2647, #2644, #2643, #2634, #2763, and #2765
This is a continuation of work to clean up object.d