test(node): Increase timeout in OnUncaughtException test scripts to fix flaky CI#21002
Merged
Conversation
…x flaky CI The 500ms timeout was too short - when network conditions cause the SDK's client.close() to take longer than 500ms (it has a 2000ms timeout), the watchdog fires first and the test fails with "I'm alive!" in stdout. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
nicohrubec
approved these changes
May 19, 2026
This was referenced May 20, 2026
JPeer264
added a commit
that referenced
this pull request
May 21, 2026
#21038) closes #20697 closes [JS-2367](https://linear.app/getsentry/issue/JS-2367/flaky-ci-node-22-integration-tests-suitespublic) closes #20791 closes [JS-2429](https://linear.app/getsentry/issue/JS-2429) closes #20804 closes [JS-2435](https://linear.app/getsentry/issue/JS-2435) Follow up to: #21002 This one basically does the same, but changes it for all tests with that and outsources this into its own test util helper. --- Claude text: Extract `expectProcessToExit()` helper to consolidate watchdog timeout logic. Uses 3000ms to account for SDK's 2000ms shutdown timeout + buffer, fixing race conditions that caused flaky CI failures. Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #20796
closes JS-2432
closes #20698
closes JS-2368
closes #20689
closes JS-2363
closes #20974
closes JS-2531
closes #20798
closes JS-2434
closes #20792
closes JS-2430
closes #20788
closes JS-2428
The 500ms timeout was too short - when network conditions cause the SDK's client.close() to take longer than 500ms (it has a 2000ms timeout), the watchdog fires first and the test fails with "I'm alive!" in stdout.
This can be reproduced with the following script: