test(compiler): enforce preview render parity#2166
Merged
jrusso1020 merged 1 commit intoJul 18, 2026
Conversation
This was referenced Jul 10, 2026
Collaborator
Author
This was referenced Jul 10, 2026
jrusso1020
force-pushed
the
07-10_test_compiler_enforce_preview_render_parity
branch
from
July 13, 2026 20:27
3e37058 to
8674f33
Compare
jrusso1020
force-pushed
the
07-10_refactor_studio_gate_sdk_operation_families
branch
from
July 13, 2026 20:27
d442be2 to
9cc75ad
Compare
jrusso1020
force-pushed
the
07-10_test_compiler_enforce_preview_render_parity
branch
from
July 13, 2026 20:33
8674f33 to
9149838
Compare
jrusso1020
force-pushed
the
07-10_refactor_studio_gate_sdk_operation_families
branch
2 times, most recently
from
July 13, 2026 22:09
8592418 to
f532570
Compare
jrusso1020
force-pushed
the
07-10_test_compiler_enforce_preview_render_parity
branch
2 times, most recently
from
July 13, 2026 22:18
7367bc9 to
a0e9003
Compare
jrusso1020
force-pushed
the
07-10_refactor_studio_gate_sdk_operation_families
branch
from
July 13, 2026 22:18
f532570 to
6277174
Compare
jrusso1020
force-pushed
the
07-10_test_compiler_enforce_preview_render_parity
branch
2 times, most recently
from
July 14, 2026 00:03
ec35495 to
a7cb697
Compare
jrusso1020
force-pushed
the
07-10_refactor_studio_gate_sdk_operation_families
branch
2 times, most recently
from
July 14, 2026 03:20
9625478 to
f9a0051
Compare
jrusso1020
force-pushed
the
07-10_test_compiler_enforce_preview_render_parity
branch
from
July 14, 2026 03:20
a7cb697 to
ec27019
Compare
jrusso1020
force-pushed
the
07-10_refactor_studio_gate_sdk_operation_families
branch
from
July 14, 2026 17:03
f9a0051 to
f4f46f9
Compare
jrusso1020
force-pushed
the
07-10_test_compiler_enforce_preview_render_parity
branch
from
July 14, 2026 17:03
ec27019 to
f2e9e31
Compare
jrusso1020
force-pushed
the
07-10_refactor_studio_gate_sdk_operation_families
branch
from
July 14, 2026 17:11
f4f46f9 to
fe9a6a8
Compare
jrusso1020
force-pushed
the
07-10_test_compiler_enforce_preview_render_parity
branch
2 times, most recently
from
July 14, 2026 17:35
a691499 to
f25e511
Compare
jrusso1020
force-pushed
the
07-10_refactor_studio_gate_sdk_operation_families
branch
from
July 14, 2026 17:57
232e3c7 to
de87827
Compare
jrusso1020
force-pushed
the
07-10_test_compiler_enforce_preview_render_parity
branch
from
July 14, 2026 17:57
f25e511 to
9aa0b74
Compare
jrusso1020
force-pushed
the
07-10_refactor_studio_gate_sdk_operation_families
branch
from
July 14, 2026 18:06
de87827 to
b8e0eb9
Compare
jrusso1020
force-pushed
the
07-10_test_compiler_enforce_preview_render_parity
branch
2 times, most recently
from
July 14, 2026 19:37
52688c3 to
58e16a2
Compare
jrusso1020
force-pushed
the
07-10_refactor_studio_gate_sdk_operation_families
branch
2 times, most recently
from
July 14, 2026 19:42
1e09810 to
7ab91ed
Compare
jrusso1020
force-pushed
the
07-10_test_compiler_enforce_preview_render_parity
branch
2 times, most recently
from
July 14, 2026 19:47
37f5dda to
e1e8f5b
Compare
jrusso1020
force-pushed
the
07-10_refactor_studio_gate_sdk_operation_families
branch
from
July 14, 2026 19:47
7ab91ed to
8591f27
Compare
miguel-heygen
approved these changes
Jul 18, 2026
miguel-heygen
left a comment
Collaborator
There was a problem hiding this comment.
Fresh exact-head review at f0956e594.
packages/core/src/compiler/htmlParityContract.ts:44normalizes legacy/current timing, canonicalizes nested variable JSON, collapses embedded and project-relative assets into the same local semantic class, and keeps stable identities for compositions, timed elements, and resources.packages/producer/src/services/htmlCompiler.parity.test.ts:30runs the same authored fixtures through the actual Core preview bundler and Producer render compiler before comparing structured contracts; this is a genuine cross-pipeline assertion, not a shared snapshot.packages/core/src/compiler/htmlParityContract.test.ts:4independently pins the extractor against literal timing, track, variable, and resource expectations, reducing the risk of both pipelines passing through a broken normalizer.
I read the complete four-file diff, traced both compiler entry points, checked existing feedback and threads, verified the exact merge base, and pulled exact-head required CI. No blocker found. The existing note about adding explicit non-empty guards to each Producer fixture is a worthwhile robustness follow-up, but the pinned Core extractor tests make it non-gating here.
Verdict: APPROVE
Reasoning: The corpus compares real preview and render outputs through a neutral, independently tested semantic contract, covers the stated drift classes, and all required exact-head checks are green.
— Magi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
Add a normalized preview/render semantic parity corpus.
Why
Preview and render compilation had accumulated one-sided fixes in timing, bootstrap, styles, URLs, and manifests.
How
Define a neutral parity contract and run shared fixtures through core preview and producer render compilation.
Test plan