refactor(repo): resolve changed-code audit#2174
Conversation
996c416 to
665006e
Compare
ba5d10b to
cb184e3
Compare
f57212b to
eea1424
Compare
cb184e3 to
437f2fa
Compare
eea1424 to
a66407f
Compare
0cd0d53 to
1f503e8
Compare
a66407f to
3f82ade
Compare
1f503e8 to
567d76c
Compare
195ebe8 to
7bc03fb
Compare
4614f85 to
4a63ab3
Compare
7bc03fb to
519e384
Compare
4a63ab3 to
ad7094b
Compare
4a63b75 to
5537a7f
Compare
ad7094b to
8095454
Compare
5537a7f to
47c96ed
Compare
8095454 to
03a10f4
Compare
47c96ed to
9595995
Compare
63add6a to
b17e180
Compare
a0c92bc to
aadfd4d
Compare
b17e180 to
97014ce
Compare
aadfd4d to
bc585c6
Compare
97014ce to
a4d798c
Compare
bc585c6 to
71575e2
Compare
miguel-heygen
left a comment
There was a problem hiding this comment.
Approved exact head ab8b50a. Audited: all 21 changed files and the complete incremental diff; trusting: none. Also read every current issue comment, review, REST comment, and GraphQL thread. The Cloud Run FPS extraction preserves validation, defaults, ordering, and command-specific errors; the shared auth fixture restores a safe superset of the prior env keys; the Studio persistence type is field-compatible; and the Fallow suppressions are category-scoped and documented around intentional lifecycle, migration, AST-walk, or test-corpus repetition. Exact-head required CI and the full applicable matrix are green. Non-blocking cleanup only: StudioRightPanelProps still redeclares the five fields inherited from StudioEditPersistenceProps, so the type centralization could be completed later without behavior impact. No blocking findings. — Magi
What
Resolve all changed-code findings introduced by the refactoring stack.
Why
A large safety-oriented stack should not add dead code, avoidable complexity, or duplicated test and helper logic.
How
Reuse the shared auth fixture, centralize the Cloud Run FPS helper and Studio persistence prop type, and add narrow documented suppressions only for intentional migration/test-corpus repetition.
Test plan