test(engine): isolate peer abort regression#2173
Merged
Merged
Conversation
This was referenced Jul 10, 2026
Collaborator
Author
2 tasks
jrusso1020
force-pushed
the
07-10-test-engine-isolate-peer-abort-regression
branch
from
July 13, 2026 20:33
f57212b to
eea1424
Compare
jrusso1020
force-pushed
the
07-10-refactor-cli-decompose-render-phases
branch
from
July 13, 2026 20:33
841ca28 to
99291ad
Compare
jrusso1020
force-pushed
the
07-10-test-engine-isolate-peer-abort-regression
branch
from
July 13, 2026 22:09
eea1424 to
a66407f
Compare
jrusso1020
force-pushed
the
07-10-refactor-cli-decompose-render-phases
branch
from
July 13, 2026 22:18
260558c to
f6dfed1
Compare
jrusso1020
force-pushed
the
07-10-test-engine-isolate-peer-abort-regression
branch
from
July 13, 2026 22:18
a66407f to
3f82ade
Compare
jrusso1020
force-pushed
the
07-10-refactor-cli-decompose-render-phases
branch
from
July 13, 2026 23:08
f6dfed1 to
50cf30c
Compare
jrusso1020
force-pushed
the
07-10-test-engine-isolate-peer-abort-regression
branch
from
July 13, 2026 23:08
3f82ade to
195ebe8
Compare
jrusso1020
force-pushed
the
07-10-refactor-cli-decompose-render-phases
branch
from
July 14, 2026 00:03
50cf30c to
a36d53c
Compare
jrusso1020
force-pushed
the
07-10-test-engine-isolate-peer-abort-regression
branch
2 times, most recently
from
July 14, 2026 03:20
7bc03fb to
519e384
Compare
jrusso1020
force-pushed
the
07-10-refactor-cli-decompose-render-phases
branch
2 times, most recently
from
July 14, 2026 17:03
23fae65 to
ffda4eb
Compare
jrusso1020
force-pushed
the
07-10-test-engine-isolate-peer-abort-regression
branch
from
July 14, 2026 17:03
519e384 to
4a63b75
Compare
jrusso1020
force-pushed
the
07-10-refactor-cli-decompose-render-phases
branch
from
July 14, 2026 17:11
ffda4eb to
b84837b
Compare
jrusso1020
force-pushed
the
07-10-test-engine-isolate-peer-abort-regression
branch
2 times, most recently
from
July 14, 2026 17:35
5537a7f to
47c96ed
Compare
jrusso1020
force-pushed
the
07-10-refactor-cli-decompose-render-phases
branch
from
July 14, 2026 17:35
b84837b to
35ae1d2
Compare
jrusso1020
force-pushed
the
07-10-test-engine-isolate-peer-abort-regression
branch
3 times, most recently
from
July 14, 2026 19:37
a0c92bc to
aadfd4d
Compare
jrusso1020
force-pushed
the
07-10-refactor-cli-decompose-render-phases
branch
from
July 14, 2026 19:37
05b117e to
b418569
Compare
jrusso1020
force-pushed
the
07-10-test-engine-isolate-peer-abort-regression
branch
from
July 14, 2026 19:42
aadfd4d to
bc585c6
Compare
jrusso1020
force-pushed
the
07-10-refactor-cli-decompose-render-phases
branch
from
July 14, 2026 19:42
b418569 to
741b993
Compare
jrusso1020
force-pushed
the
07-10-test-engine-isolate-peer-abort-regression
branch
from
July 14, 2026 19:47
bc585c6 to
71575e2
Compare
jrusso1020
force-pushed
the
07-10-refactor-cli-decompose-render-phases
branch
2 times, most recently
from
July 14, 2026 19:49
4ed9cff to
eb7cb8e
Compare
jrusso1020
force-pushed
the
07-10-test-engine-isolate-peer-abort-regression
branch
from
July 14, 2026 19:49
71575e2 to
2165a08
Compare
jrusso1020
force-pushed
the
07-10-refactor-cli-decompose-render-phases
branch
from
July 14, 2026 19:55
eb7cb8e to
e743638
Compare
miguel-heygen
approved these changes
Jul 20, 2026
miguel-heygen
left a comment
Collaborator
There was a problem hiding this comment.
Approved exact head a03d40e. Audited the complete one-file diff plus every current issue comment, review, REST comment, and GraphQL thread. The minimal frameCapture mock provides all seven runtime imports consumed by parallelCoordinator while leaving classifyCaptureFailure, CaptureFailure, fatality logic, peer cancellation, and cleanup on their production implementations. The regression still deterministically proves the first fatal authoring failure prevents frame capture and closes both sessions. Exact-head required CI and the complete applicable matrix are green. No blocking findings. — Magi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
Isolate the engine peer-abort regression test from unrelated production dependency loading.
Why
The test used importOriginal for a large module graph, causing full-matrix timeouts that obscured the cancellation behavior it was meant to protect.
How
Replace the partial importOriginal mock with a complete minimal dependency mock and keep the assertion focused on aborting peer workers after the first fatal classified failure.
Test plan