fix(server): reject invalid explicit Bitbucket repositories

[aravhawk]

Fixes #15193.

Problem

Entering a Bitbucket name such as myrepo could resolve the server working directory's repository instead, or fail with a generic VCS error.

Change

An explicit repository now goes through the existing locator validator before context, VCS, or HTTP lookup. An omitted repository still falls back to the current checkout. The repository service exposes only the fixed workspace/repository guidance for this error; other provider errors remain generic. The locator error also stops naming createRepository when it can come from lookup.

Scope and approval

This is a small, focused repair of the obvious failure confirmed in the issue triage, using the existing validation rule. It leaves parsing rules and the self-hosted routing work in #14593 unchanged.

Verification

Verified on macOS arm64 with Node 24.13.1, pnpm 11.10.0, and vp 1.0.0, rebased onto a1d9d72a. Running the new regressions with upstream production files produced 3 expected failures and 42 passes. Restoring the fix passed all 112 tests across the five suites below. They cover rejected inputs making no VCS/HTTP calls, explicit repository precedence, omitted-input fallback, and safe error messages.

vp test run apps/server/src/sourceControl/BitbucketApi.test.ts apps/server/src/sourceControl/BitbucketSourceControlProvider.test.ts apps/server/src/sourceControl/SourceControlRepositoryService.test.ts apps/server/src/pullRequest/BitbucketPullRequestApi.test.ts apps/server/src/pullRequest/BitbucketPullRequestProvider.test.ts
vp lint --report-unused-disable-directives apps/server/src/sourceControl/BitbucketApi.ts apps/server/src/sourceControl/BitbucketApi.test.ts apps/server/src/sourceControl/SourceControlRepositoryService.ts apps/server/src/sourceControl/SourceControlRepositoryService.test.ts
vp fmt --check apps/server/src/sourceControl/BitbucketApi.ts apps/server/src/sourceControl/BitbucketApi.test.ts apps/server/src/sourceControl/SourceControlRepositoryService.ts apps/server/src/sourceControl/SourceControlRepositoryService.test.ts
vp run --filter t3 typecheck
git diff --check

All passed. Tests exercise services and adapters with external dependencies stubbed. No live Bitbucket, browser, desktop, or mobile check was performed. Existing web and mobile error displays consume the shared error message; no client code changed.

Implemented with GPT-6.1 Sol in Codex; independently reviewed with GPT-6 Astra in Codex.

[macroscopeapp]

Approvability

Verdict: Approved at 1156d43

Macroscope's review found this PR approvable — This is a small, self-contained Bitbucket validation fix that prevents invalid explicit repositories from falling through to unrelated local-repository discovery. Existing valid and fallback paths remain intact, and focused tests cover the behavior and safe error propagation.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Important

Review skipped

We couldn't safely recover the incremental review. No full review was started, and the last reviewed checkpoint was preserved. Retry later, or explicitly request a full review by commenting @coderabbitai full review.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: d52123df-fec7-4246-968e-953aba442155

📥 Commits

Reviewing files that changed from the base of the PR and between a1d9d72 and 1156d43.

📒 Files selected for processing (4)

• apps/server/src/sourceControl/BitbucketApi.test.ts
• apps/server/src/sourceControl/BitbucketApi.ts
• apps/server/src/sourceControl/SourceControlRepositoryService.test.ts
• apps/server/src/sourceControl/SourceControlRepositoryService.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

---

📝 Walkthrough

Walkthrough

Bitbucket repository resolution now rejects malformed explicit repository values instead of falling back to context or Git remotes. Repository error mapping exposes the safe locator detail for matching Bitbucket provider errors.

Changes

Bitbucket repository errors

Layer / File(s)	Summary
Validate explicit repository values apps/server/src/sourceControl/BitbucketApi.ts, apps/server/src/sourceControl/BitbucketApi.test.ts	An invalid supplied repository now raises BitbucketRepositoryLocatorError before context or remote resolution. Tests cover invalid values, valid-value precedence, context use, and remote discovery.
Map Bitbucket locator errors apps/server/src/sourceControl/SourceControlRepositoryService.ts, apps/server/src/sourceControl/SourceControlRepositoryService.test.ts	Error mapping uses the locator error’s safe detail for matching Bitbucket provider errors. Tests check generic details for other causes and verify messages omit locator or credential text.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~15 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 1156d

Invalid explicit Bitbucket repository names are rejected, while supported fallback paths remain available. No actionable merge-blocking risk remains after normal checks.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 1156d

The fix prevents invalid explicit inputs from selecting an unintended repository and exposes only fixed guidance in error messages. No introduced security vulnerability was established. The handling of nested diagnostic causes in external responses remains unverified.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

• inferred — The changed guard narrows the reach of invalid explicit input: it can no longer select the checkout's repository through fallback or trigger the subsequent Bitbucket repository lookup. Successful explicit inputs and omitted-input discovery retain their existing selection paths.

Trust Boundaries and Controls

• observed — The displayed error detail comes from a constant selected by provider and locator-error guards, not from the rejected input or arbitrary underlying error text. Tests explicitly check credential-like input, locator lookalikes, and request failures without asserting complete cause sanitization.
• observed — The WebSocket transport authenticates the upgrade and supplies session scopes to RPC authorization. Repository lookup and publish retain their existing RPC handlers; this PR does not modify that authorization wiring.

Hardening Proposals

• proposed — Consider a transport-safe diagnostic representation for rejected repository values and a wire-level regression for nested causes. Cause retention predates this PR, while lookup can now produce the locator error; this proposal is not a verified disclosure finding.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 4 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: rejecting invalid explicit Bitbucket repository values.
Description check	✅ Passed	The description covers the problem, change, scope and approval rationale, and focused verification results. It also states what was not checked and identifies the implementation and review tools.
Linked Issues check	✅ Passed	Issue #15193 requires an invalid explicit Bitbucket repository to return the locator guidance instead of falling back to context or cwd remotes. BitbucketApi.resolveRepository now validates every su…
Out of Scope Changes check	✅ Passed	The diff changes Bitbucket repository resolution, safe error mapping, and tests for the behavior required by issue #15193. The locator wording change also supports errors raised during lookup. No unre…

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}