[ptr727]

Promotes develop to main for the 3.23 release.

This branch is main with develop merged in, replacing #1097, which conflicted. Each conflict was a hub reusable-workflow pin that Dependabot bumped on main to 2.0.1209 while develop holds 2.0.1251, and develop's side is taken. validate-task.yml is deleted, since develop runs the hub's validate task. The merged tree is identical to develop at 303ef98.

Verify and repair

• Fix Verify False Positive for Video Non-Monotonic DTS #1060: verify encodes video in the demuxer time base, which removes the false non-monotonic DTS on healthy VFR video.
• Stop Re-Encode for Mixed DTS and Add Minimum Tool Version Gate #1062: a non-monotonic DTS that only appears after decode stops after the remux tier rather than re-encoding. It also adds the minimum tool version gate at startup.
• Raise the Minimum FFmpeg Version to 8.0 #1096: the FFmpeg family minimum is 8.0, for FFmpeg and FFprobe alike, since closed caption detection uses FFprobe's -analyze_frames.

DeleteInvalidFiles safety

• Keep Skipped and Cancelled Files Out of DeleteInvalidFiles #1086: a skipped or cancelled file is never deleted.
• Treat an FfMpeg Verify That Did Not Run as a Tool Error #1089: an FfMpeg verify that did not run is a tool error, not a decode error.
• Keep a File When a Tool Did Not Run #1091: a file is kept when a tool did not run.
• Keep a File When a Signal Kills Its FfMpeg Verify #1093: a file is kept when a signal kills its FfMpeg verify.
• Keep a File Whose Timestamp Repair Stops on a Post-Decode DTS #1103: a file whose timestamp repair stops after the remux tier on a post-decode DTS is marked PostDecodeTimestamps and kept on every run.

Docker and scripts

• Rename the Shell Scripts to Lowercase-Hyphenated Names #1065: shell scripts are renamed to lowercase-hyphenated names, which changes the script paths inside the image.
• Fail Closed When the Nonroot Docker User Does Not Resolve #1067: the image fails closed when the nonroot user does not resolve.
• Correct the Docker Layout Entry on the Image User #1087: corrects the Docker layout entry on the image user.
• Bring the Renamed Shell Scripts to the Shell and Prose Style Rules #1102: the renamed shell scripts meet the prose rules, one comment sentence per line.

Governance and docs

• Resync With the Hub and Adopt the Hub Validate Task #1064: resync with the fleet hub, adopting the hub validate task.
• Add Process Command Logic Diagrams to ARCHITECTURE.md #1083: process command logic diagrams in ARCHITECTURE.md.

Dependencies

Dependabot group updates (actions-deps and nuget-deps).

Closes #939
Closes #1001
Closes #1061
Closes #1063
Closes #1066
Closes #1068
Closes #1084
Closes #1088
Closes #1090
Closes #1092
Closes #1099
Closes #1101

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Too many files!

This PR contains 104 files, which is 4 over the limit of 100.

To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch.

Upgrade to a paid plan to raise the limit.

This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: c3c1bf51-a4fc-4474-af21-2e4fc79790f9

Commits

Reviewing files that changed from the base of the PR and between dfb3678 and 3f47a33.

Files selected for processing: 104

• .editorconfig
• .gitattributes
• .github/copilot-instructions.md
• .github/skills/agent-conduct/SKILL.md
• .github/skills/audit-a-repo/SKILL.md
• .github/skills/backlog-burndown/SKILL.md
• .github/skills/branching-and-release-model/SKILL.md
• .github/skills/branching-and-release-model/references/branch-protection-and-promotion.md
• .github/skills/branching-and-release-model/references/release-publish-mechanics.md
• .github/skills/carried-instruction-file-guard/SKILL.md
• .github/skills/check-this-repo/SKILL.md
• .github/skills/comment-and-doc-style/SKILL.md
• .github/skills/comment-and-doc-style/references/carried-doc-references.md
• .github/skills/comment-and-doc-style/references/line-endings.md
• .github/skills/comment-and-doc-style/references/markdown-links.md
• .github/skills/copilot-instructions-keeper/SKILL.md
• .github/skills/dotnet-codestyle/SKILL.md
• .github/skills/dotnet-codestyle/references/conventions.md
• .github/skills/dotnet-codestyle/references/project-config.md
• .github/skills/dotnet-codestyle/references/testing.md
• .github/skills/drive-pr/SKILL.md
• .github/skills/fleet-code-review/SKILL.md
• .github/skills/git-commit-conventions/SKILL.md
• .github/skills/git-commit-conventions/references/history-rewrite.md
• .github/skills/local-strict-review/SKILL.md
• .github/skills/merge-and-release/SKILL.md
• .github/skills/pr-review-conduct/SKILL.md
• .github/skills/python-codestyle/SKILL.md
• .github/skills/python-codestyle/references/code-style.md
• .github/skills/python-codestyle/references/profiles.md
• .github/skills/python-codestyle/references/testing.md
• .github/skills/repo-worktree/SKILL.md
• .github/skills/resync-a-repo/SKILL.md
• .github/skills/session-handoff/SKILL.md
• .github/skills/shell-codestyle/SKILL.md
• .github/skills/skill-lifecycle/SKILL.md
• .github/skills/standup-a-repo/SKILL.md
• .github/skills/unattended-handoff/SKILL.md
• .github/skills/upstream-contribution-workflow/SKILL.md
• .github/skills/workflow-ci-contract/SKILL.md
• .github/skills/workflow-ci-contract/references/architecture.md
• .github/skills/workflow-ci-contract/references/d-guarantees.md
• .github/skills/workflow-ci-contract/references/test-methodology.md
• .github/workflows/merge-bot-pull-request.yml
• .github/workflows/publish-release.yml
• .github/workflows/test-pull-request.yml
• .github/workflows/validate-task.yml
• .gitignore
• .husky/pre-commit
• .markdownlint-cli2.jsonc
• .vscode/tasks.json
• AGENTS.md
• ARCHITECTURE.md
• AUDIT.md
• CODESTYLE.md
• Docker/Build.sh
• Docker/Dockerfile
• Docker/Test.sh
• Docker/Version.sh
• Docker/build.sh
• Docker/counters.sh
• Docker/install-debug-tools.sh
• Docker/test.sh
• Docker/version.sh
• GOVERNANCE.md
• HISTORY.md
• OPERATIONS.md
• PlexCleaner.slnx
• PlexCleaner/DtsInfo.cs
• PlexCleaner/FfMpegBuilder.cs
• PlexCleaner/FfMpegTool.cs
• PlexCleaner/FfProbeTool.cs
• PlexCleaner/MediaTool.cs
• PlexCleaner/Process.cs
• PlexCleaner/ProcessDriver.cs
• PlexCleaner/ProcessFile.cs
• PlexCleaner/SidecarFile.cs
• PlexCleaner/ToolErrorScope.cs
• PlexCleaner/Tools.cs
• PlexCleaner/VerifyResult.cs
• PlexCleanerTests/ArchitectureDiagramTests.cs
• PlexCleanerTests/DeleteFailedFileTests.cs
• PlexCleanerTests/DtsInfoTests.cs
• PlexCleanerTests/FfMpegVerifyCommandTests.cs
• PlexCleanerTests/PlexCleanerFixture.cs
• PlexCleanerTests/ToolErrorScopeTests.cs
• PlexCleanerTests/VerifyToolErrorTests.cs
• README.md
• RegressionTests/README.md
• RegressionTests/RegressionTest.sh
• RegressionTests/catalog_corpus.py
• RegressionTests/corpus_common.py
• RegressionTests/locate_issue.py
• RegressionTests/pyproject.toml
• RegressionTests/reduce_corpus.py
• RegressionTests/regression-test.sh
• RegressionTests/synthetic/synthesize.py
• RegressionTests/tests/test_audit_physical.py
• RegressionTests/tests/test_corpus_common.py
• RegressionTests/tests/test_locate_issue.py
• RegressionTests/tests/test_reduce_corpus.py
• WORKFLOW.md
• cspell.json
• version.json

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[qodo-free-for-open-source-projects]

PR Summary by Qodo

Promote PlexCleaner 3.23 verification and deletion safety fixes

🐞 Bug fix ✨ Enhancement 🧪 Tests 📝 Documentation ⚙️ Configuration changes 🕐 40+ Minutes

AI Description

• Promote fixes for false verification failures, frame-dropping repairs, and unsafe file deletion.
• Require FFmpeg 8.0 and expand media, tool-failure, and regression coverage.
• Update Docker scripts, adopt hub-hosted validation, and refresh release and governance
 documentation.

Diagram

graph TD
  R["Per-file processing"] --> V["FFmpeg verify"] --> C{"Verify result"} --> A["Packet analysis"] --> L["Repair ladder"] --> G{"Safe to delete?"} --> F["Media and sidecar"]
  C -->|clean| F
  C -->|tool error| G
  G -->|no| K["Keep unchanged"]

Loading

High-Level Assessment

The following are alternative approaches to this PR:

1. Split the promotion into smaller releases

• ➕ Narrower reviews and simpler regression attribution.
• ➖ Would not promote the tested develop tree intact and could separate interdependent safety fixes.

2. Keep repository-local validation

• ➕ Retains direct control over the validation workflow.
• ➖ Duplicates the hub task and its maintenance.

Recommendation: Promoting the intact develop tree preserves the release's tested combination of fixes, and hub-hosted validation removes an unnecessary local copy. Give particular attention to the deletion guards and changed CI triggers; they carry the greatest behavioral risk.

Files changed (96) +6130 / -2473

Enhancement (7) +614 / -32

build.shHarden Docker build script +34/-21

Harden Docker build script

• Uses fail-fast Bash, rejects unknown arguments, provides help, and quotes build arguments.

Docker/build.sh

install-debug-tools.shHarden debug-tool installation +24/-11

Harden debug-tool installation

• Adds fail-fast Bash and argument handling while retaining runtime-ID-based installation.

Docker/install-debug-tools.sh

test.shAdd non-root-capable image test script +108/-0

Add non-root-capable image test script

• Introduces the lowercase image test path, writes generated output under /tmp, and documents non-root execution.

Docker/test.sh

version.shAdd lowercase image version script +31/-0

Add lowercase image version script

• Prints OS, .NET, application, and media-tool versions with fail-fast argument handling.

Docker/version.sh

locate_issue.pyUpdate issue locator interface +2/-0

Update issue locator interface

• Makes a small command-interface adjustment to the issue locator.

RegressionTests/locate_issue.py

reduce_corpus.pyUpdate corpus reducer interface +5/-0

Update corpus reducer interface

• Makes a small command-interface adjustment to the corpus reducer.

RegressionTests/reduce_corpus.py

regression-test.shAdd lowercase regression harness +410/-0

Add lowercase regression harness

• Provides the renamed ZFS-clone and Docker-image regression harness with help and argument checks.

RegressionTests/regression-test.sh

Bug fix (11) +223 / -40

DtsInfo.csIdentify post-decode-only DTS failures +14/-0

Identify post-decode-only DTS failures

• Adds an audio/video packet-DTS check to distinguish demux-visible failures from those appearing after decode.

PlexCleaner/DtsInfo.cs

FfMpegBuilder.csExpose video encoder time-base option +5/-0

Expose video encoder time-base option

• Adds an FFmpeg builder option for the video encoder time base.

PlexCleaner/FfMpegBuilder.cs

FfMpegTool.csCorrect FFmpeg verification classification +23/-6

Correct FFmpeg verification classification

• Verifies video using the demuxer time base, returns ToolError when FFmpeg does not run, and records signal-like exits.

PlexCleaner/FfMpegTool.cs

FfProbeTool.csRecord FFprobe execution failures +2/-0

Record FFprobe execution failures

• Records cancelled or failed packet extraction in the file's tool-error scope.

PlexCleaner/FfProbeTool.cs

MediaTool.csGate tool versions and record failures +16/-0

Gate tool versions and record failures

• Defines an FFmpeg-family minimum of 8.0 and records failed, cancelled, or throwing tool executions.

PlexCleaner/MediaTool.cs

Process.csKeep skipped files out of deletion +5/-2

Keep skipped files out of deletion

• Tracks read-only media and sidecar skips so failed processing does not delete files that were never processed.

PlexCleaner/Process.cs

ProcessDriver.csScope tool errors to each file +1/-0

Scope tool errors to each file

• Starts a separate tool-error scope around each file-processing task.

PlexCleaner/ProcessDriver.cs

ProcessFile.csMake verification, repair, and deletion fail safely +91/-31

Make verification, repair, and deletion fail safely

• Preserves files and retryable state after tool errors, signals, or cancellation. Stops post-decode-only timestamp repair after remux and deletes sidecars only with their MKV files.

PlexCleaner/ProcessFile.cs

ToolErrorScope.csAdd per-file tool-failure accounting +46/-0

Add per-file tool-failure accounting

• Uses AsyncLocal to count tool executions that did not run and signal-ended FFmpeg verifications separately.

PlexCleaner/ToolErrorScope.cs

Tools.csReject unsupported installed tools at startup +17/-1

Reject unsupported installed tools at startup

• Checks discovered tool versions against their family minimum before processing media.

PlexCleaner/Tools.cs

VerifyResult.csDistinguish unchecked files from decode corruption +3/-0

Distinguish unchecked files from decode corruption

• Adds ToolError for verification that could not execute.

PlexCleaner/VerifyResult.cs

Refactor (2) +17 / -9

catalog_corpus.pyAdjust corpus catalog utility +1/-1

Adjust corpus catalog utility

• Makes a small consistency adjustment to the catalog script.

RegressionTests/catalog_corpus.py

corpus_common.pyNarrow corpus helper error handling +16/-8

Narrow corpus helper error handling

• Makes subprocess return-code handling explicit and replaces broad exception catches around metadata and run discovery.

RegressionTests/corpus_common.py

Tests (12) +1187 / -10

ArchitectureDiagramTests.csCheck process diagrams against code +152/-0

Check process diagrams against code

• Verifies documented pipeline order and method names against the implementation.

PlexCleanerTests/ArchitectureDiagramTests.cs

DeleteFailedFileTests.csTest deletion safeguards +95/-0

Test deletion safeguards

• Covers read-only skips and ensures deleting non-MKV media retains a sibling MKV sidecar.

PlexCleanerTests/DeleteFailedFileTests.cs

DtsInfoTests.csTest post-decode DTS classification +48/-0

Test post-decode DTS classification

• Covers missing analysis, absent video DTS, subtitle-only breaks, and demux-visible audio or video breaks.

PlexCleanerTests/DtsInfoTests.cs

FfMpegVerifyCommandTests.csTest verify arguments and version floor +82/-0

Test verify arguments and version floor

• Checks the demuxer video time-base argument, error flags, and FFmpeg/FFprobe 8.0 minimum.

PlexCleanerTests/FfMpegVerifyCommandTests.cs

PlexCleanerFixture.csExpose repository path to tests +6/-4

Expose repository path to tests

• Adds a repository-root path helper for architecture documentation tests.

PlexCleanerTests/PlexCleanerFixture.cs

ToolErrorScopeTests.csTest isolated tool-error scopes +102/-0

Test isolated tool-error scopes

• Covers per-file resets, concurrent scopes, thread-pool propagation, and separate signal accounting.

PlexCleanerTests/ToolErrorScopeTests.cs

VerifyToolErrorTests.csExercise tool and signal failure safety +352/-0

Exercise tool and signal failure safety

• Uses fake tools to test launch failures, signal exits, verification state, repair outcomes, and deletion protection.

PlexCleanerTests/VerifyToolErrorTests.cs

synthesize.pyGenerate targeted DTS regression media +98/-6

Generate targeted DTS regression media

• Adds healthy VFR, repeated-timestamp, and mixed audio/post-decode video fixtures.

RegressionTests/synthetic/synthesize.py

test_audit_physical.pyTest physical corpus audit helpers +22/-0

Test physical corpus audit helpers

• Adds unit coverage for physical corpus audit behavior.

RegressionTests/tests/test_audit_physical.py

test_corpus_common.pyTest shared corpus parsing helpers +151/-0

Test shared corpus parsing helpers

• Covers error normalization, log parsing, classification, run selection, and clip construction.

RegressionTests/tests/test_corpus_common.py

test_locate_issue.pyTest issue locator +35/-0

Test issue locator

• Adds unit coverage for issue-location behavior.

RegressionTests/tests/test_locate_issue.py

test_reduce_corpus.pyTest corpus reduction helpers +44/-0

Test corpus reduction helpers

• Adds unit coverage for corpus reduction behavior.

RegressionTests/tests/test_reduce_corpus.py

Documentation (54) +3963 / -2284

.editorconfigClarify line-ending policy +3/-3

Clarify line-ending policy

• Clarifies LF defaults and CRLF exceptions for checked-out files.

.editorconfig

.gitattributesClarify Git text normalization +4/-2

Clarify Git text normalization

• Explains normalization, checkout endings, and explicit pins for text-shaped binary data.

.gitattributes

copilot-instructions.mdRefresh Copilot review guidance +9/-9

Refresh Copilot review guidance

• Resynchronizes carried Copilot instructions with current fleet guidance.

.github/copilot-instructions.md

SKILL.mdRefresh agent conduct rules +54/-48

Refresh agent conduct rules

• Updates carried agent-conduct and governance guidance.

.github/skills/agent-conduct/SKILL.md

SKILL.mdRefresh repository audit procedure +16/-14

Refresh repository audit procedure

• Resynchronizes the carried repository-audit skill.

.github/skills/audit-a-repo/SKILL.md

SKILL.mdRevise backlog orchestration guidance +319/-257

Revise backlog orchestration guidance

• Updates worker grouping, handoff, review, and orchestration instructions.

.github/skills/backlog-burndown/SKILL.md

SKILL.mdRefresh branching and release rules +43/-39

Refresh branching and release rules

• Aligns the carried skill with current promotion and release practices.

.github/skills/branching-and-release-model/SKILL.md

branch-protection-and-promotion.mdRefresh promotion reference +32/-32

Refresh promotion reference

• Updates carried branch-protection and promotion guidance.

.github/skills/branching-and-release-model/references/branch-protection-and-promotion.md

release-publish-mechanics.mdRefresh publishing reference +67/-62

Refresh publishing reference

• Updates the release mechanics reference for current publishing rules.

.github/skills/branching-and-release-model/references/release-publish-mechanics.md

SKILL.mdRefresh carried-file guard guidance +8/-8

Refresh carried-file guard guidance

• Resynchronizes instructions for preventing drift in hub-carried files.

.github/skills/carried-instruction-file-guard/SKILL.md

SKILL.mdRefresh repository-check procedure +36/-21

Refresh repository-check procedure

• Updates the carried procedure for checking fleet requirements.

.github/skills/check-this-repo/SKILL.md

SKILL.mdExpand documentation style guidance +144/-113

Expand documentation style guidance

• Refreshes carried rules for comments, prose, links, and line endings.

.github/skills/comment-and-doc-style/SKILL.md

carried-doc-references.mdRefresh carried-document references +29/-29

Refresh carried-document references

• Updates guidance for references to hub-carried documentation.

.github/skills/comment-and-doc-style/references/carried-doc-references.md

line-endings.mdRefresh line-ending reference +63/-54

Refresh line-ending reference

• Clarifies normalization, checkout behavior, and line-ending exceptions.

.github/skills/comment-and-doc-style/references/line-endings.md

markdown-links.mdRefresh Markdown link guidance +14/-12

Refresh Markdown link guidance

• Resynchronizes carried Markdown link conventions.

.github/skills/comment-and-doc-style/references/markdown-links.md

SKILL.mdRefresh Copilot instruction maintenance +19/-18

Refresh Copilot instruction maintenance

• Updates the skill governing provider-specific Copilot instructions.

.github/skills/copilot-instructions-keeper/SKILL.md

SKILL.mdRefresh .NET coding guidance +24/-23

Refresh .NET coding guidance

• Resynchronizes carried .NET style and verification instructions.

.github/skills/dotnet-codestyle/SKILL.md

conventions.mdRefresh .NET conventions reference +7/-7

Refresh .NET conventions reference

• Updates supporting .NET conventions.

.github/skills/dotnet-codestyle/references/conventions.md

project-config.mdRefresh .NET project configuration reference +9/-2

Refresh .NET project configuration reference

• Updates carried project and analyzer configuration guidance.

.github/skills/dotnet-codestyle/references/project-config.md

testing.mdRefresh .NET testing reference +5/-5

Refresh .NET testing reference

• Resynchronizes test-project and test-runner guidance.

.github/skills/dotnet-codestyle/references/testing.md

SKILL.mdRefresh PR-driving procedure +148/-106

Refresh PR-driving procedure

• Clarifies how feature and promotion PRs proceed through review and authorized merges.

.github/skills/drive-pr/SKILL.md

SKILL.mdExpand fleet code-review guidance +52/-7

Expand fleet code-review guidance

• Adds design and trust-boundary criteria while limiting review execution to requested commands.

.github/skills/fleet-code-review/SKILL.md

SKILL.mdRefresh Git commit conventions +22/-46

Refresh Git commit conventions

• Resynchronizes carried staging, signing, and commit guidance.

.github/skills/git-commit-conventions/SKILL.md

history-rewrite.mdRefresh history-rewrite reference +5/-9

Refresh history-rewrite reference

• Updates guidance for controlled history rewrites.

.github/skills/git-commit-conventions/references/history-rewrite.md

SKILL.mdRefresh local review procedure +88/-48

Refresh local review procedure

• Updates strict-review instructions and evidence expectations.

.github/skills/local-strict-review/SKILL.md

SKILL.mdTighten promotion merge procedure +119/-137

Tighten promotion merge procedure

• Requires checking the live promotion head and merging with a matching-head guard.

.github/skills/merge-and-release/SKILL.md

SKILL.mdRevise PR review coverage rules +307/-160

Revise PR review coverage rules

• Expands head-SHA and file-coverage criteria, including local coverage for non-default branches.

.github/skills/pr-review-conduct/SKILL.md

SKILL.mdExpand Python profile rules +167/-61

Expand Python profile rules

• Defines per-directory profiles, test obligations, and script argument guidance.

.github/skills/python-codestyle/SKILL.md

code-style.mdRefresh Python code-style reference +33/-19

Refresh Python code-style reference

• Updates supporting Python code-style guidance.

.github/skills/python-codestyle/references/code-style.md

profiles.mdExpand Python profile reference +82/-47

Expand Python profile reference

• Clarifies directory-level profiles, dependencies, verification, and layout.

.github/skills/python-codestyle/references/profiles.md

testing.mdRefresh Python testing reference +3/-2

Refresh Python testing reference

• Updates tests and coverage guidance for Python directories.

.github/skills/python-codestyle/references/testing.md

SKILL.mdRefresh worktree isolation procedure +100/-66

Refresh worktree isolation procedure

• Updates carried guidance for task-specific worktrees and checkout safety.

.github/skills/repo-worktree/SKILL.md

SKILL.mdRefresh fleet resynchronization procedure +32/-24

Refresh fleet resynchronization procedure

• Aligns the resync skill with current hub audit steps.

.github/skills/resync-a-repo/SKILL.md

SKILL.mdMove handoffs to standing track issues +257/-196

Move handoffs to standing track issues

• Replaces successor issues with one open issue per track, archiving earlier rounds as comments.

.github/skills/session-handoff/SKILL.md

SKILL.mdExpand shell script safety guidance +60/-26

Expand shell script safety guidance

• Adds script argument and command-shim rules to shell verification guidance.

.github/skills/shell-codestyle/SKILL.md

SKILL.mdRefresh skill lifecycle guidance +41/-23

Refresh skill lifecycle guidance

• Updates instructions for maintaining and synchronizing fleet skills.

.github/skills/skill-lifecycle/SKILL.md

SKILL.mdRefresh repository standup procedure +22/-18

Refresh repository standup procedure

• Resynchronizes guidance for establishing the fleet instruction baseline.

.github/skills/standup-a-repo/SKILL.md

SKILL.mdRevise unattended handoff orchestration +255/-103

Revise unattended handoff orchestration

• Updates picker and worker procedures, promotion grants, and failed-dispatch handling.

.github/skills/unattended-handoff/SKILL.md

SKILL.mdRefresh upstream contribution procedure +66/-31

Refresh upstream contribution procedure

• Updates instructions for proposing fixes to the authoritative hub.

.github/skills/upstream-contribution-workflow/SKILL.md

SKILL.mdRefresh CI contract skill +6/-6

Refresh CI contract skill

• Aligns carried workflow guidance with the shared validation contract.

.github/skills/workflow-ci-contract/SKILL.md

architecture.mdRefresh workflow architecture reference +15/-15

Refresh workflow architecture reference

• Updates the reference for reusable workflow structure.

.github/skills/workflow-ci-contract/references/architecture.md

d-guarantees.mdRefresh CI guarantees reference +28/-27

Refresh CI guarantees reference

• Updates carried workflow guarantees.

.github/skills/workflow-ci-contract/references/d-guarantees.md

test-methodology.mdRefresh workflow test methodology +15/-14

Refresh workflow test methodology

• Updates how the CI contract is checked.

.github/skills/workflow-ci-contract/references/test-methodology.md

.markdownlint-cli2.jsoncClarify Markdown lint exclusions +9/-3

Clarify Markdown lint exclusions

• Explains why the root glob and local subtree ignore files are required.

.markdownlint-cli2.jsonc

AGENTS.mdRefresh agent bootstrap and handoff rules +42/-21

Refresh agent bootstrap and handoff rules

• Resynchronizes fleet instructions and changes session handoffs to a standing issue per track.

AGENTS.md

ARCHITECTURE.mdDocument process-command control flow +557/-20

Document process-command control flow

• Adds Mermaid diagrams for command dispatch, per-file processing, state refresh, repair, and suspect branches. Also documents tool-version gating.

ARCHITECTURE.md

AUDIT.mdRefresh audit guidance +1/-1

Refresh audit guidance

• Resynchronizes repository audit instructions with the hub.

AUDIT.md

CODESTYLE.mdExpand fleet coding and script rules +69/-14

Expand fleet coding and script rules

• Adds operational failure, structured-format parsing, command-line argument, and file-naming rules. Updates Python and shell verification guidance.

CODESTYLE.md

GOVERNANCE.mdResynchronize fleet governance +153/-118

Resynchronize fleet governance

• Refreshes repository safety, handoff, review, design, and release rules; much of the change clarifies existing prose.

GOVERNANCE.md

HISTORY.mdRecord 3.23 release behavior +47/-0

Record 3.23 release behavior

• Documents timestamp verification and repair fixes, the FFmpeg minimum, deletion safeguards, and renamed Docker scripts.

HISTORY.md

OPERATIONS.mdUpdate build and verification runbooks +22/-4

Update build and verification runbooks

• Documents hub validation, Python and shell checks, non-root image testing, and testing unreleased builds inside the image.

OPERATIONS.md

README.mdPublish 3.23 and non-root usage guidance +55/-18

Publish 3.23 and non-root usage guidance

• Summarizes the release, states the FFmpeg minimum, and updates Docker examples with configurable non-root IDs and permissions.

README.md

README.mdDocument renamed harness and DTS fixtures +20/-9

Document renamed harness and DTS fixtures

• Updates harness commands, Python test instructions, and synthetic timestamp examples.

RegressionTests/README.md

WORKFLOW.mdDocument PR CI and hub validation +160/-127

Document PR CI and hub validation

• Replaces push-CI and local-validation descriptions with PR-triggered validation, changed-path smoke builds, and pinned hub tasks.

WORKFLOW.md

Other (10) +126 / -98

merge-bot-pull-request.ymlUpdate merge-bot trigger and hub pin +5/-6

Update merge-bot trigger and hub pin

• Adds closed PR events and updates the SHA-pinned hub merge-bot task to 2.0.1251.

.github/workflows/merge-bot-pull-request.yml

publish-release.ymlAdopt hub validation for publishing +15/-18

Adopt hub validation for publishing

• Replaces local validation with the pinned hub task, declares the Python directory, and updates release-task pins and concurrency.

.github/workflows/publish-release.yml

test-pull-request.ymlSwitch CI to PR-triggered hub validation +56/-32

Switch CI to PR-triggered hub validation

• Validates PRs into main or develop through the hub task. Changed paths gate smoke builds; the required aggregate status still checks validation and path detection.

.github/workflows/test-pull-request.yml

pre-commitAnnotate Husky bootstrap sourcing +1/-0

Annotate Husky bootstrap sourcing

• Adds a ShellCheck source annotation for the generated Husky helper.

.husky/pre-commit

tasks.jsonUpdate local testing tasks +27/-13

Update local testing tasks

• Runs the Docker test as a non-root user, updates tool invocations, and adds a Python unittest coverage task.

.vscode/tasks.json

DockerfileUse renamed Docker scripts +10/-9

Use renamed Docker scripts

• References lowercase script paths in builder and runtime stages and includes architecture documentation for builder tests.

Docker/Dockerfile

PlexCleaner.slnxAlign solution entries with workflow and script moves +5/-5

Align solution entries with workflow and script moves

• Removes the local validator entry and updates Docker script paths.

PlexCleaner.slnx

pyproject.tomlAlign Python lint-only configuration +3/-10

Align Python lint-only configuration

• Sets the mypy file target and updates comments for the hub validator and current local commands.

RegressionTests/pyproject.toml

cspell.jsonRefresh spelling configuration +3/-4

Refresh spelling configuration

• Adjusts repository spelling configuration for updated documentation.

cspell.json

version.jsonAdvance release line to 3.23 +1/-1

Advance release line to 3.23

• Raises the Nerdbank.GitVersioning major.minor release line from 3.22 to 3.23.

version.json

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (1) 🎨 UX issues (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

1. Windows exit-255 failures skip cleanup 📎 Requirement gap ≡ Correctness

Description

The signal-exit predicate treats exit code 255 as a signal even on Windows because or 255 is
outside the platform guard. A Windows FFmpeg failure with that code increments SignalCount, so
DeleteFailedFile() refuses to delete the media and sidecar instead of applying normal failure
cleanup.

Code

PlexCleaner/FfMpegTool.cs[R170-171]

+        internal static bool IsSignalExit(int exitCode) =>
+            !OperatingSystem.IsWindows() && exitCode is (>= 129 and <= 159) or 255;

Evidence

The changed predicate applies the platform check only to the 129–159 range while or 255 remains
unconditional. The changed verification code records SignalCount when the predicate matches, and
the changed deletion guard refuses deletion whenever SignalCount is positive.

Define and apply signal-terminated FfMpeg verify behavior
PlexCleaner/FfMpegTool.cs[167-171]
PlexCleaner/FfMpegTool.cs[196-199]
PlexCleaner/ProcessFile.cs[1794-1799]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`IsSignalExit` classifies exit code 255 as a signal on Windows because the `or 255` pattern is outside the `!OperatingSystem.IsWindows()` guard. This records a signal for ordinary Windows FFmpeg failures and prevents `DeleteFailedFile()` from deleting files that are eligible for cleanup.
## Fix Focus Areas
- PlexCleaner/FfMpegTool.cs[170-171]
- PlexCleaner/FfMpegTool.cs[196-199]
- PlexCleaner/ProcessFile.cs[1794-1799]
## Recommended Fix
Group the complete exit-code pattern under the non-Windows condition so exit codes 129–159 and 255 are recognized as signal terminations only on non-Windows platforms. Add a Windows-specific test confirming exit code 255 is not classified as a signal and does not suppress normal failure cleanup.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

2. Playable files with a post-decode timestamp break get deleted ✓ Resolved

Description

RepairTimestampsAndSetState now calls `RepairAndReVerify(residualPostDecode ||
DtsInfo.IsPostDecodeOnly(dtsInfo))`, which returns false after the remux tier instead of trying the
re-encode. The failure then sets VerifyFailed/RepairFailed, VerifyAndRepair returns false, and
with DeleteInvalidFiles on, Process.ProcessFile passes the file to DeleteFailedFile. No tool
error, signal or cancel guard applies to this case, so a file that main re-encoded and kept is now
deleted, along with its sidecar.

Code

PlexCleaner/ProcessFile.cs[R2273-2276]

+        if (
+            TryLosslessTimestampRepair(dtsInfo, out bool residualPostDecode)
+            || RepairAndReVerify(residualPostDecode || DtsInfo.IsPostDecodeOnly(dtsInfo))
+        )

Evidence

The new remuxOnly branch in RepairAndReVerify (ProcessFile.cs 2114-2122) returns false for a
post-decode-only DTS. In RepairTimestampsAndSetState, the only early exits on failure are cancel,
a tool-count change, or a signal (2286-2294). Otherwise it marks VerifyFailed|RepairFailed and
returns false. Process.cs line 313 turns that into result = false, and lines 384-386 then call
DeleteFailedFile(). That method's guards (1794-1799) cover only tool errors, signals and cancel.
HISTORY.md says these files are now marked RepairFailed, but it does not say that
DeleteInvalidFiles then deletes them. Before this PR they were re-encoded and kept.

PlexCleaner/ProcessFile.cs[2266-2304]
PlexCleaner/ProcessFile.cs[2114-2122]
PlexCleaner/ProcessFile.cs[1791-1823]
PlexCleaner/Process.cs[310-320]
PlexCleaner/Process.cs[380-388]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
When the timestamp repair ladder stops after remux because the DTS failure is post-decode only, the file is marked VerifyFailed/RepairFailed and returns false. With `DeleteInvalidFiles` on, `Process.ProcessFile` then deletes the file and its sidecar. Before this change the file was re-encoded and kept, so a file with a benign post-decode timestamp repeat is now deleted.
## Fix Focus Areas
- PlexCleaner/ProcessFile.cs[2266-2304]
- PlexCleaner/ProcessFile.cs[1791-1823]
- PlexCleaner/ToolErrorScope.cs[1-46]
## Recommended Fix
Record that the ladder stopped on a deliberate post-decode-only skip. For example, add a per-file flag (or a counter in ToolErrorScope's session) and set it in `RepairAndReVerify` when `remuxOnly` causes the early return. Check that flag in `DeleteFailedFile()` so the file is kept and reported, the same way the signal and tool-error cases are. Add a DeleteFailedFile test for this case and mention the behaviour in HISTORY.md.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

Tip of the day

💡 Did you know, you can route each severity your way: inline, summary, both, or drop

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

[Copilot]

🟡 Changes recommended

A critical workflow bug can block fork pull requests, and four new shell scripts are missing required why-comments before enabling strict error handling.

3 open issues

• Skip the Docker smoke job for fork pull requests · New
• Explain why the media script uses strict shell mode · New
• Explain why the reporting script uses strict shell mode · New

What changed in this PR

This pull request promotes the 3.23 release from develop to main, combining verification and repair-safety fixes, safer invalid-file handling, Docker and regression-tooling updates, and fleet CI governance changes.

Changes:

• Uses demuxer time bases, adds FFmpeg 8.0 family gating, and classifies tool and signal failures safely.
• Prevents deletion when processing, verification, or required tools did not complete successfully.
• Adds DTS regression fixtures and .NET/Python test coverage.
• Renames and hardens Docker scripts, adopts hub-hosted validation, and resynchronizes documentation and skills.

This pull request requires changes. Outstanding findings include one critical fork-pull-request workflow issue, moderate subprocess encoding issues, and contract/style nits in shell scripts and Markdown links.

File	Description
version.json	Bumps the release version to 3.23.
RegressionTests/​tests/​test_reduce_corpus.py	Tests corpus-reduction helpers.
RegressionTests/​tests/​test_locate_issue.py	Tests issue-location helpers and verify arguments.
RegressionTests/​tests/​test_corpus_common.py	Tests parsing, classification, and clip helpers.
RegressionTests/​tests/​test_audit_physical.py	Tests physical error-shape extraction.
RegressionTests/​synthetic/​synthesize.py	Adds synthetic DTS and mixed-timestamp fixtures.
RegressionTests/​reduce_corpus.py	Makes subprocess status handling explicit.
RegressionTests/​README.md	Documents regression tests, synthetic fixtures, and current script paths.
RegressionTests/​pyproject.toml	Configures mypy coverage of the directory.
RegressionTests/​locate_issue.py	Aligns issue reproduction with demuxer-time-base verification.
RegressionTests/​corpus_common.py	Tightens subprocess handling and exception classification.
RegressionTests/​catalog_corpus.py	Uses set comprehension for catalog buckets.
PlexCleanerTests/​ToolErrorScopeTests.cs	Tests scoped tool-error tracking and isolation.
PlexCleanerTests/​PlexCleanerFixture.cs	Adds repository-root resolution for architecture tests.
PlexCleanerTests/​FfMpegVerifyCommandTests.cs	Tests FFmpeg minimum versions and verify command construction.
PlexCleanerTests/​DtsInfoTests.cs	Tests post-decode DTS classification.
PlexCleanerTests/​DeleteFailedFileTests.cs	Tests deletion safety and sidecar behavior.
PlexCleanerTests/​ArchitectureDiagramTests.cs	Keeps architecture diagrams aligned with processing code.
PlexCleaner/​VerifyResult.cs	Adds the ToolError verification result.
PlexCleaner/​Tools.cs	Enforces minimum tool versions at startup.
PlexCleaner/​ToolErrorScope.cs	Tracks per-file tool failures and signal exits.
PlexCleaner/​ProcessDriver.cs	Begins a tool-error scope for each processed file.
PlexCleaner/​Process.cs	Prevents deletion of skipped files.
PlexCleaner/​MediaTool.cs	Adds family minimum versions and records tool failures.
PlexCleaner/​FfProbeTool.cs	Records asynchronous FFprobe execution failures.
PlexCleaner/​FfMpegTool.cs	Updates verification time bases and signal classification.
PlexCleaner/​FfMpegBuilder.cs	Adds the video encoder-time-base option.
PlexCleaner/​DtsInfo.cs	Classifies failures visible only after decoding.
PlexCleaner.slnx	Removes the retired workflow and updates renamed scripts.
OPERATIONS.md	Documents current CI, Docker, and unreleased-build procedures.
HISTORY.md	Records the 3.23 fixes and operational changes.
Docker/​Version.sh	Removes the superseded script name.
Docker/​version.sh	Adds the lowercase version script with argument validation.
Docker/​Test.sh	Removes the superseded test script name.
Docker/​test.sh	Adds the lowercase test script and non-root output handling.
Docker/​install-debug-tools.sh	Adds argument validation and stricter shell execution.
Docker/​Dockerfile	Uses renamed scripts and copies architecture documentation for tests.
Docker/​build.sh	Adds argument validation and safer build argument quoting.
cspell.json	Updates the project dictionary for new terminology.
AUDIT.md	Uses the current hub audit invocation.
.vscode/​tasks.json	Updates Docker, Python, and editorconfig tasks.
.markdownlint-cli2.jsonc	Clarifies Markdown lint configuration comments.
.husky/​pre-commit	Adds shellcheck source metadata.
.gitignore	Ignores Python coverage outputs.
.github/​workflows/​validate-task.yml	Retires the repository-local validation workflow.
.github/​workflows/​test-pull-request.yml	Adopts hub validation and filtered smoke builds.
.github/​workflows/​publish-release.yml	Pins the current hub release workflow tasks.
.github/​workflows/​merge-bot-pull-request.yml	Updates merge-bot triggers and hub pinning.
.github/​skills/​workflow-ci-contract/​SKILL.md	Refreshes workflow-contract guidance.
.github/​skills/​standup-a-repo/​SKILL.md	Refreshes repository standup guidance.
.github/​skills/​shell-codestyle/​SKILL.md	Adds shell argument and structured-format guidance.
.github/​skills/​python-codestyle/​references/​testing.md	Updates Python testing and coverage guidance.
.github/​skills/​python-codestyle/​references/​code-style.md	Updates Python comments, typing, and subprocess guidance.
.github/​skills/​git-commit-conventions/​references/​history-rewrite.md	Clarifies history-rewrite identity rules.
.github/​skills/​fleet-code-review/​SKILL.md	Updates review and design guidance.
.github/​skills/​dotnet-codestyle/​SKILL.md	Refreshes .NET build and configuration guidance.
.github/​skills/​dotnet-codestyle/​references/​testing.md	Updates MTP and coverage guidance.
.github/​skills/​dotnet-codestyle/​references/​project-config.md	Clarifies conditional AOT configuration.
.github/​skills/​dotnet-codestyle/​references/​conventions.md	Refreshes C# convention wording.
.github/​skills/​copilot-instructions-keeper/​SKILL.md	Clarifies carried instruction-file handling.
.github/​skills/​comment-and-doc-style/​references/​markdown-links.md	Clarifies Markdown link conventions.
.github/​skills/​comment-and-doc-style/​references/​carried-doc-references.md	Clarifies carried-document reference rules.
.github/​skills/​check-this-repo/​SKILL.md	Updates repository and Skills-install checks.
.github/​skills/​carried-instruction-file-guard/​SKILL.md	Clarifies protection of local instruction content.
.github/​skills/​branching-and-release-model/​references/​branch-protection-and-promotion.md	Refreshes promotion and branch-protection guidance.
.gitattributes	Clarifies text normalization behavior.
.editorconfig	Clarifies line-ending comments.

_{Review effort: Lite}

[ptr727]

Answering Qodo's two comment-only findings.

1. "Windows exit-255 failures skip cleanup": declined with evidence, as in its thread. exitCode is (>= 129 and <= 159) or 255 is a single pattern, so the !IsWindows() && guard covers 255 as well, and Windows never counts an exit as a signal.
2. "Playable files with a post-decode timestamp break get deleted": fixed in Keep a File Whose Timestamp Repair Stops on a Post-Decode DTS #1103, now merged into this promotion. The remux-only stop marks the file PostDecodeTimestamps, and DeleteFailedFile() keeps such a file on every run.

[Copilot]

🟢 Approval recommended

No active review issues remain unresolved, so the change can proceed based on the completed review disposition.

No open issues 🎉

3 resolved since last review

• Skip the Docker smoke job for fork pull requests
• Explain why the reporting script uses strict shell mode
• Explain why the media script uses strict shell mode

_{Review effort: Lite}

[ptr727]

Coverage for head 3f47a33 rests on the promotion case. The head's tree equals develop's tree (5d3c399b6d3c003a3588e4bebe1db4bc41d87a57), so the merge adds no content of its own. Every change it carries had a recorded local strict pass and its own review on its feature pull request into develop, including #1102 and #1103 this round. Copilot's round on this head recommends approval with no findings.