Skip to content

State the Root Gating Condition in the python-codestyle Skill #3554

Closed

Description

@ptr727

.agents/skills/python-codestyle/SKILL.md says "The undeclared root, the default for a repo declaring none, is gated more loosely." That states the root as always gated when no Python directory is declared.

.github/actions/python-directories/python_directories.py resolve() returns ["."] only where a root pyproject.toml is tracked, and otherwise []. So a repository declaring no directory and tracking no root pyproject.toml has no Python directory gated at all. WORKFLOW.md D1.2 states the condition.

Failure: a reader of a repository with no root pyproject.toml takes the sentence literally and expects CI to gate its root.

Fix: put the sentence on the same condition, as the sibling sentence in .agents/skills/python-codestyle/references/profiles.md now does, then regenerate the skill copies.

Found by a local review pass on the promotion fix for #3492. That change's file claim did not cover this file.

Activity

  1. added
    pre-existingReview finding classed pre-existing per local-strict-review Disposing of Findings
    on Oct 28, 2026
  2. ptr727 commented on Oct 28, 2026

    @ptr727
    OwnerAuthor

    Backlog burndown round 3 claim, one group for #3548, #3550, #3552 and #3554. Branch: feature/3548-python-profile-followups. Predicted file set: .agents/skills/python-codestyle/SKILL.md, .agents/skills/python-codestyle/references/profiles.md (the "Adapt before propagating" text), spec/type-model.md and spec/project-types.json (their Python profile text only), plus regenerated copies under .github/skills/ and .claude-plugin/fleet-skills/ (skill files and .source-digests/ entries) for python-codestyle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    pre-existingReview finding classed pre-existing per local-strict-review Disposing of Findings

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions