Skip to content

Bring the Remaining Python Profile Text Onto the Per-Directory Rule - #3557

Merged
ptr727 merged 2 commits into
developfrom
feature/3548-python-profile-followups
Oct 28, 2026
Merged

ptr727 merged 2 commits into
developfrom
feature/3548-python-profile-followups

Conversation

@ptr727

@ptr727 ptr727 commented Oct 28, 2026

Copy link
Copy Markdown
Owner

Summary

The per-directory Python profile rule from #3549 and #3555 still met per-repository wording in four places. Each now states the rule: a profile belongs to a declared directory, not to the repository.

Deferrals, filed

Verification

  • spec/validate.py passes.
  • tests/test_spec_validate.py and tests/test_audit_helpers.py pass under unittest.
  • scripts/build_dist.py --check reports the distributions current.
  • scripts/prose_lint.py --diff origin/develop reports no violation, with --check sentence-length too.

Closes on promotion: #3548, #3550, #3552, #3554

🤖 Generated with Claude Code

ptr727 and others added 2 commits October 27, 2026 20:23
The python-codestyle skill and the spec now say a Python profile
belongs to a declared directory, not to the repository. The skill names
the build trait as a deliverable, declares a uv workspace once by its
root, and gates an undeclared root only where it tracks a root
pyproject.toml. The profiles reference calls the per-repo bundle a
toolchain. The type model and the python profileNote describe the
profile per directory.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Two profiles lead-in now names each Python directory, so it no
longer reads back to the root. The toolchain axes drop the
per-directory qualifier, since versioning can be a repository choice.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings October 28, 2026 03:27
@ptr727

ptr727 commented Oct 28, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 22d754d4d7294324e636e0d2c8f36c4d5af53f13, the content this pull request carries at that commit against develop, and it recorded 0 findings.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Promotion should await maintainer review because the documented Python profile model no longer matches the registry and validator contract, and the related issue is explicitly deferred.

No open issues 🎉

What changed in this PR

This pull request aligns Python profile guidance with the per-directory profile model, updates the specification text, and regenerates the distributed python-codestyle skills and source digest.

Changes:

  • Defines profiles, deliverables, toolchains, and CI guidance per declared Python directory.
  • Clarifies uv workspace-root exceptions and undeclared-root gating.
  • Updates the type model and machine-readable project metadata.
  • Regenerates distributed skill copies and refreshes the source digest.
File Description
spec/​type-model.md Documents Python profiles per declared directory.
spec/​project-types.json Updates Python profile metadata and workspace wording.
.github/​skills/​python-codestyle/​SKILL.md Regenerated GitHub skill guidance.
.github/​skills/​python-codestyle/​references/​profiles.md Regenerated profile reference guidance.
.claude-plugin/​fleet-skills/​skills/​python-codestyle/​SKILL.md Regenerated Claude skill guidance.
.claude-plugin/​fleet-skills/​skills/​python-codestyle/​references/​profiles.md Regenerated Claude profile reference guidance.
.claude-plugin/​fleet-skills/​.source-digests/​python-codestyle Updates the generated skill source digest.
.agents/​skills/​python-codestyle/​SKILL.md Updates the canonical Python profile and root-gating guidance.
.agents/​skills/​python-codestyle/​references/​profiles.md Updates canonical per-directory toolchain guidance.

Review effort: Lite

@ptr727

ptr727 commented Oct 28, 2026

Copy link
Copy Markdown
Owner Author

Answer to the headline of the Copilot round on 22d754d4 (review), which counted no finding (0) and flagged one item in its headline:

the documented Python profile model no longer matches the registry and validator contract, and the related issue is explicitly deferred.

spec/type-model.md:37, spec/project-types.json python.profileNote: Deferred to #3556.

The mismatch is real and is not this change's to close. The per-directory rule was already stated in CODESTYLE.md "Python" and references/profiles.md by #3549, and this change brings the spec prose onto it. The per-repository profiles.python value lives in registry/repos.json, spec/project-types.schema.json, and spec/validate.py, all outside this change's file bounds. #3556 records it with the two candidate shapes and names those files.

@codecov

codecov Bot commented Oct 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.50%. Comparing base (367bba0) to head (22d754d).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3557   +/-   ##
========================================
  Coverage    81.50%   81.50%           
========================================
  Files           26       26           
  Lines         9065     9065           
========================================
  Hits          7388     7388           
  Misses        1677     1677           
Flag Coverage Δ
python-3.13 81.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptr727
ptr727 merged commit adac2d5 into develop Oct 28, 2026
14 checks passed
@ptr727
ptr727 deleted the feature/3548-python-profile-followups branch October 28, 2026 03:39
ptr727 added a commit that referenced this pull request Oct 28, 2026
… AGENTS.md and WORKFLOW.md Sentence Length (#3562)

## Summary

Promotes `develop` to `main`, carrying round 3 of the resync-issue
burndown:

- #3557: the python-codestyle skill, `profiles.md` "Adapt before
propagating", `spec/type-model.md` and `spec/project-types.json` state
the per-directory Python profile rule. The skill names the root-gating
condition.
- #3558: the digest prints the run-log reading inside its Copilot
refusal block. The block's fixed sentence holds for quota, transient,
and file-count refusals.
- #3559: every sentence in `AGENTS.md` is 25 words or fewer, and all but
one in `.github/copilot-instructions.md`. The two remaining
`GOVERNANCE.md` sentences, and their copies, are shortened too.
- #3561: every sentence in `WORKFLOW.md` is 25 words or fewer. Guarantee
IDs, tables, and code are byte-identical.
- #3564: promotion fix for Copilot's two findings on this pull request.
The python-codestyle skill and the `python.profileNote` name the
undeclared-root default.
- #3565: Dependabot bumps `DavidAnson/markdownlint-cli2-action` from
24.2.0 to 25.0.0. It merged into `develop` while this pull request was
open.

The #3559 and #3561 slices continue the #3531 cleanup and do not close
it. Carried `AGENTS.md`, `WORKFLOW.md`, and Copilot-instructions text
changes wording, so each fleet repository's verbatim copy differs from
the hub until its next resync.

Fixes #3541
Fixes #3548
Fixes #3550
Fixes #3552
Fixes #3554

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants