Repository navigation
Name the Undeclared Root Default Beside the uv Workspace Exception - #3564
Merged
Merged
Conversation
The python-codestyle "Two profiles" paragraph and the spec's python profileNote said every Python directory is declared, except a uv workspace. The validator also gates an undeclared root where a root pyproject.toml is tracked, per WORKFLOW.md D1.2. Both texts now state that default, matching references/profiles.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Owner
Author
|
A recorded local strict-review pass covers head |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain, with the validator rule, specification, distributed Skill copies, and source digest updated together.
No open issues 🎉
What changed in this PR
This pull request clarifies the undeclared-root default for Python validation, updates the project specification, and regenerates the distributed Skill copies and source digest.
Changes:
- Documents that an undeclared repository root is gated only when it tracks a root
pyproject.toml. - Updates
python.profileNoteto match the documented validator behavior. - Regenerates the GitHub and Claude Skill distributions.
- Updates the source digest for the regenerated Skill.
| File | Description |
|---|---|
spec/project-types.json |
Adds the undeclared-root validation rule to the Python profile specification. |
.github/skills/python-codestyle/SKILL.md |
Regenerated GitHub Copilot Skill guidance. |
.claude-plugin/fleet-skills/skills/python-codestyle/SKILL.md |
Regenerated Claude Skill guidance. |
.claude-plugin/fleet-skills/.source-digests/python-codestyle |
Records the updated canonical Skill digest. |
.agents/skills/python-codestyle/SKILL.md |
Updates the canonical Python Skill with the undeclared-root gating rule. |
Review effort: Lite
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3564 +/- ##
========================================
Coverage 81.50% 81.50%
========================================
Files 26 26
Lines 9066 9066
========================================
Hits 7389 7389
Misses 1677 1677
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ptr727
added a commit
that referenced
this pull request
Oct 28, 2026
… AGENTS.md and WORKFLOW.md Sentence Length (#3562) ## Summary Promotes `develop` to `main`, carrying round 3 of the resync-issue burndown: - #3557: the python-codestyle skill, `profiles.md` "Adapt before propagating", `spec/type-model.md` and `spec/project-types.json` state the per-directory Python profile rule. The skill names the root-gating condition. - #3558: the digest prints the run-log reading inside its Copilot refusal block. The block's fixed sentence holds for quota, transient, and file-count refusals. - #3559: every sentence in `AGENTS.md` is 25 words or fewer, and all but one in `.github/copilot-instructions.md`. The two remaining `GOVERNANCE.md` sentences, and their copies, are shortened too. - #3561: every sentence in `WORKFLOW.md` is 25 words or fewer. Guarantee IDs, tables, and code are byte-identical. - #3564: promotion fix for Copilot's two findings on this pull request. The python-codestyle skill and the `python.profileNote` name the undeclared-root default. - #3565: Dependabot bumps `DavidAnson/markdownlint-cli2-action` from 24.2.0 to 25.0.0. It merged into `develop` while this pull request was open. The #3559 and #3561 slices continue the #3531 cleanup and do not close it. Carried `AGENTS.md`, `WORKFLOW.md`, and Copilot-instructions text changes wording, so each fleet repository's verbatim copy differs from the hub until its next resync. Fixes #3541 Fixes #3548 Fixes #3550 Fixes #3552 Fixes #3554 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promotion fix for threads
PRRT_kwDOQ5caqM6w--qpandPRRT_kwDOQ5caqM6w--q2on #3562.Both texts said every Python directory is declared in
python-directories, except a uv workspace. They left out the undeclared-root default. With no declaration, the validator gates the root only where a rootpyproject.tomlis tracked, perWORKFLOW.mdD1.2..agents/skills/python-codestyle/SKILL.md"Two profiles" paragraph now states that default beside the uv workspace exception.spec/project-types.jsonpython.profileNotestates it too.references/profiles.mdalready carries.scripts/build_dist.py.Verification
python3 spec/validate.pypasses.tests/test_spec_validate.py,tests/test_audit_helpers.py, andtests/test_build_dist.pypass.scripts/build_dist.py --checkreports the generated distributions current.Pre-existing findings, filed
CODESTYLE.md:92(pre-existing): the Python summary names only the uv workspace exception, not the undeclared-root default. Filed as Name the Undeclared Root Default in CODESTYLE.md Python #3563.Pre-existing findings, not filed
spec/project-types.json:38(pre-existing):python.profileNotecites "CODESTYLE.md Python 'Two profiles'", a heading only the python-codestyle Skill carries.catalog/snippets/pre-commit/README.md:11has the same pointer.Closes on promotion: #3548, #3552
🤖 Generated with Claude Code