Skip to content

Align backlog-burndown's Abandoned-Branch Delete with Its Is-Ancestor Check #3785

Closed

Description

@ptr727

.agents/skills/backlog-burndown/SKILL.md, "Cleanup Is the Orchestrator's", the abandoned-group removal: git worktree remove <exact-path>, then git branch -d <exact-branch>.

Defect

The safety check before that removal reads refs/remotes/origin/develop, after git fetch origin develop. A never-pushed branch has no upstream, so git branch -d judges it against the base clone's HEAD, normally local develop. That fetch does not advance local develop.

Failure

Constructed case: the base clone's local develop sits at commit A. origin/develop has moved on to B. A worker's branch feature/example was cut from B and carries no commit of its own. The is-ancestor check against origin/develop passes. git branch -d feature/example then refuses with "not fully merged", since B is not reachable from local develop. The group stops for the maintainer although nothing would be discarded. For a pushed branch with an upstream, -d checks the upstream, which equals the tip, so it adds nothing there either.

repo-worktree "Listing and Cleanup" already notes that -d judges a branch with no upstream against HEAD.

Done When

The abandoned-group removal deletes the local branch by a step whose own check agrees with the is-ancestor check the procedure already ran, or the procedure states why the refusal is wanted.

Found by the local strict review of feature/burn-3772.

Activity

  1. added
    pre-existingReview finding classed pre-existing per local-strict-review Disposing of Findings
    on Nov 1, 2026
  2. ptr727 commented on Nov 2, 2026

    @ptr727
    OwnerAuthor

    Released (2026-11-02): PR #3822 merged to develop and its branch is deleted, so this claim holds no files. The issue closes on promotion.

    Backlog burndown claim (away run 2026-11-02, round 2, group G2). Branch: burndown/3786-burndown-cleanup. Issues: #3786, #3785, #3772.

    Predicted file set:

    • .agents/skills/backlog-burndown/ and its generated trees (.github/skills/backlog-burndown/, .claude-plugin/fleet-skills/skills/backlog-burndown/, .claude-plugin/fleet-skills/.source-digests/backlog-burndown)
    • .agents/skills/git-commit-conventions/ and its generated trees (.github/skills/git-commit-conventions/, .claude-plugin/fleet-skills/skills/git-commit-conventions/, .claude-plugin/fleet-skills/.source-digests/git-commit-conventions)

    Out of bounds for this group: GOVERNANCE.md and .agents/skills/agent-conduct/ (group G3), host-setup/agent-safety/ (held in away mode), .agents/skills/repo-worktree/, .agents/skills/decision-triage/.

    Scope: develop only. The feature pull request carries Closes on promotion: for each issue it fully fixes.

    Adjudication update (2026-11-02): PR #3818 has merged and released GOVERNANCE.md. The claim grows by GOVERNANCE.md, limited to the one sentence in "Git and Commit Rules" that names the backlog-burndown abandon discard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    pre-existingReview finding classed pre-existing per local-strict-review Disposing of Findings

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions