Repository navigation
Explain the Workspace-Edit Default and Name the Aggregator's Expression Form - #3818
Merged
Merged
Conversation
…on Form Give both statements of the unknown-window default their reason, so a carrier's reviewer does not re-raise it. Have a repository shipping Python ignore .vscode/settings.json, which the Python Environments extension writes regardless of the workspace file, and add the entry to the hub's own .gitignore. Say the ruleset-bound aggregator name is the one a pull_request run posts, pointing to WORKFLOW.md D1.5 for the expression form. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ngs Rule Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… Comes From Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Owner
Author
|
A recorded local strict-review pass covers head |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed governance, ignore-rule, and synchronized skill-file changes have no documented active issues.
No open issues 🎉
What changed in this PR
This pull request clarifies governance guidance for workspace-edit defaults, Python-generated VS Code settings, and the required-check aggregator’s expression-based name. It also synchronizes the affected agent-conduct skill distributions and source digest.
Changes:
- Explains why unknown sessions in other VS Code windows default to no known session.
- Documents the Python extension’s generated
.vscode/settings.jsonand adds it to.gitignore. - Clarifies the aggregator’s
pull_requestexpression form and ruleset-bound status name. - Regenerates the authored and distributed
agent-conductskill files and source digest.
| File | Description |
|---|---|
GOVERNANCE.md |
Updates workspace-edit, Python settings, and aggregator naming guidance. |
.gitignore |
Ignores generated Python extension settings. |
.github/skills/agent-conduct/SKILL.md |
Synchronizes the GitHub Copilot skill distribution. |
.claude-plugin/fleet-skills/skills/agent-conduct/SKILL.md |
Synchronizes the Claude skill distribution. |
.claude-plugin/fleet-skills/.source-digests/agent-conduct |
Updates the generated skill source digest. |
.agents/skills/agent-conduct/SKILL.md |
Updates the authored agent-conduct skill content. |
Review effort: Lite
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3818 +/- ##
===========================================
+ Coverage 81.60% 82.96% +1.35%
===========================================
Files 26 29 +3
Lines 9070 9732 +662
===========================================
+ Hits 7402 8074 +672
+ Misses 1668 1658 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Nov 2, 2026
Closed
ptr727
added a commit
that referenced
this pull request
Nov 3, 2026
…rge on a Running Hosted Review, and Gate Skill Description Length (#3843) Promotes the changes merged into `develop` since promotion #3797 to `main`, the end of an away-mode backlog burndown. - [#3803](#3803) exempts the Roslyn embedded-language marker (`// lang=json`, `language=`) from the prose gate's comment rules as a tool directive. - [#3807](#3807) has `local_review.py record` take `--report`, the file the reviewer wrote, bind the pass to its sha256, and derive the finding count from it. `status` gains `reportPath`. - [#3809](#3809) holds `pr_review.py merge` while a hosted review is still running on the head, and routes a declined Qodo finding to a dismiss request. - [#3811](#3811) dates an anchored `intentRef` by the section its anchor names, and lets a `driftNote` acknowledge a verified intent advisory. - [#3816](#3816) moves the null GraphQL node check into the shared `gh_graphql` transport as `NullNodeError`. - [#3818](#3818) explains the workspace-edit default in `GOVERNANCE.md` and names the aggregator's expression form. - [#3822](#3822) moves the abandon discard to the `backlog-burndown` orchestrator, aligns the abandoned-branch delete, and holds a grown agent-safety set. - [#3823](#3823) scopes the Husky prose gate to staged paths and adds `--skip-generated` so a named file inside a generated tree is skipped. - [#3828](#3828) reads Copilot's `Open findings:` label, drops the duplicate `null_node`, and matches `scripts/README.md` to the Merge Gate. - [#3829](#3829) bumps the two stale hub caller snippet pins and documents the fallback's mixed-pair refusal. - [#3831](#3831) keeps an inherited `GIT_DIR` from rerooting the prose gate's subdirectory git reads. - [#3832](#3832) gives `backlog-burndown` a disposition for a worker's standalone clone and keeps the agent-safety hold past a park. - [#3835](#3835) makes `carry.py check-sections` refuse what `apply-sections` would, and name an open fence. - [#3836](#3836) pins the reusable-workflow stubs by placeholder and ticks the PlexCleaner gates item. - [#3838](#3838) has the `runtime-secrets` audit dimension detect a bare `secrets/` directory from the tracked files that name it. - [#3839](#3839) gates skill descriptions at the 1024-character limit and trims every one over it. - [#3846](#3846) fixes an adjacent doc, an in-file pre-existing defect, and an edge case on new code in the open pull request instead of filing an issue for each, and keeps filing for code that runs elsewhere. - [#3847](#3847) refuses skill frontmatter that parses to a list or a scalar, so the description length gate cannot be bypassed. Fixes #3770 Fixes #3699 Fixes #3705 Fixes #3789 Fixes #1819 Fixes #727 Fixes #3710 Fixes #3706 Fixes #3623 Fixes #3687 Fixes #3617 Fixes #3757 Fixes #3790 Fixes #3786 Fixes #3785 Fixes #3772 Fixes #1657 Fixes #3443 Fixes #3824 Fixes #3817 Fixes #3805 Fixes #1666 Fixes #3700 Fixes #3821 Fixes #3771 Fixes #3794 Fixes #3825 Fixes #3690 Fixes #1472 Fixes #3813 Fixes #3719 Fixes #1592 Fixes #3845 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small
GOVERNANCE.mdprose changes, each made the way the maintainer answered it, plus the.gitignoreentry one of them calls for.agent-conductincludes "Verification Discipline", soscripts/build_dist.pyregenerated it..vscode/settings.jsonin.gitignore. The reason given is that the Python extension installs the Python Environments extension, which writes settings there (it is inms-python.python'sextensionPack). The rule that settings live only in the.code-workspacefile stays. Its.vscode/clause now speaks of tracked files, so the generated file does not contradict it. The hub ships Python, so its own.gitignoregains the entry.name:suffixes" bullet now says the ruleset-bound name is the one apull_requestrun posts. It points toWORKFLOW.mdD1.5 for the expression form and says each string that expression yields ends in "job". The same-string sentence is scoped to thatpull_requestname too, since an expressionname:is not literally the context string.Not in this change
#3768 (Repository Layout) was assigned to this group, but
developalready has every item its decision lists. #1685 added them on 2026-09-18, before #1155 was split. Its.github/workflows/row already scopes the reusable task workflows to the hub, and theSTANDUP.md/RESYNC.md,.agents/, andhost-setup/rows are all there. That issue is left open with a comment giving the evidence, so this pull request does not close it.Verification
scripts/build_dist.py --check: generated distributions are current. Onlyagent-conductchanged.prose_lint.py . --diffagainst the merge base: clean.spec/validate.py: OK.tests/unittest suite: 3332 tests, OK (7 skipped).local-strict-review: three recorded passes at thefrontiertier. The first two raised findings and each was fixed or classed. The third ran over the final content.Pre-existing findings, not filed
GOVERNANCE.md"Verification Discipline", the workspace-edit bullet,pre-existing: "Where it cannot tell, it asks the maintainer" can be read as covering the unobservable other-window state. The default sentence just before it already settles that case, and the "Editor and Tasks" copy scopes its question to "whether the rule binds it". The sentence predates this change, which adds only the reason clause.A resync is owed to carriers, since the sections this changes are carried.
Closes on promotion: #3617, #3757, #3790
🤖 Generated with Claude Code