Repository navigation
Read Copilot's Open findings Label, Drop the Duplicate null_node, and Match the Scripts README to the Merge Gate - #3828
Conversation
… Match the Merge Gate Notes in the Scripts README Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…o Badge, and pending= Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… State the Rate-Limit Clearing Exactly Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
|
A recorded local strict-review pass covers head |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain, with the parser update covered by regression tests and the related documentation and cleanup changes addressed.
No open issues 🎉
What changed in this PR
This pull request updates Copilot findings parsing and Merge Gate documentation, removes an unused duplicate GraphQL helper, and adds regression coverage.
Changes:
- Recognizes
Open findings:in Copilot review output. - Adds parser test coverage for the new label spelling.
- Removes the duplicate
pr_review_rounds.null_nodehelper. - Aligns
scripts/README.mdwith current wait, merge, and Qodo behavior.
| File | Description |
|---|---|
tests/test_pr_review_copilot.py |
Adds coverage for Open findings: in supported findings-list contexts. |
scripts/reviewers/copilot.json |
Adds the new Copilot findings-label spelling to the parser vocabulary. |
scripts/README.md |
Documents current hosted-review, merge, pending-check, and Qodo remediation behavior. |
scripts/pr_review_rounds.py |
Removes the unused duplicate null_node helper. |
Review effort: Lite
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3828 +/- ##
===========================================
+ Coverage 81.60% 82.97% +1.36%
===========================================
Files 26 29 +3
Lines 9070 9741 +671
===========================================
+ Hits 7402 8083 +681
+ Misses 1668 1658 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…rge on a Running Hosted Review, and Gate Skill Description Length (#3843) Promotes the changes merged into `develop` since promotion #3797 to `main`, the end of an away-mode backlog burndown. - [#3803](#3803) exempts the Roslyn embedded-language marker (`// lang=json`, `language=`) from the prose gate's comment rules as a tool directive. - [#3807](#3807) has `local_review.py record` take `--report`, the file the reviewer wrote, bind the pass to its sha256, and derive the finding count from it. `status` gains `reportPath`. - [#3809](#3809) holds `pr_review.py merge` while a hosted review is still running on the head, and routes a declined Qodo finding to a dismiss request. - [#3811](#3811) dates an anchored `intentRef` by the section its anchor names, and lets a `driftNote` acknowledge a verified intent advisory. - [#3816](#3816) moves the null GraphQL node check into the shared `gh_graphql` transport as `NullNodeError`. - [#3818](#3818) explains the workspace-edit default in `GOVERNANCE.md` and names the aggregator's expression form. - [#3822](#3822) moves the abandon discard to the `backlog-burndown` orchestrator, aligns the abandoned-branch delete, and holds a grown agent-safety set. - [#3823](#3823) scopes the Husky prose gate to staged paths and adds `--skip-generated` so a named file inside a generated tree is skipped. - [#3828](#3828) reads Copilot's `Open findings:` label, drops the duplicate `null_node`, and matches `scripts/README.md` to the Merge Gate. - [#3829](#3829) bumps the two stale hub caller snippet pins and documents the fallback's mixed-pair refusal. - [#3831](#3831) keeps an inherited `GIT_DIR` from rerooting the prose gate's subdirectory git reads. - [#3832](#3832) gives `backlog-burndown` a disposition for a worker's standalone clone and keeps the agent-safety hold past a park. - [#3835](#3835) makes `carry.py check-sections` refuse what `apply-sections` would, and name an open fence. - [#3836](#3836) pins the reusable-workflow stubs by placeholder and ticks the PlexCleaner gates item. - [#3838](#3838) has the `runtime-secrets` audit dimension detect a bare `secrets/` directory from the tracked files that name it. - [#3839](#3839) gates skill descriptions at the 1024-character limit and trims every one over it. - [#3846](#3846) fixes an adjacent doc, an in-file pre-existing defect, and an edge case on new code in the open pull request instead of filing an issue for each, and keeps filing for code that runs elsewhere. - [#3847](#3847) refuses skill frontmatter that parses to a list or a scalar, so the description length gate cannot be bypassed. Fixes #3770 Fixes #3699 Fixes #3705 Fixes #3789 Fixes #1819 Fixes #727 Fixes #3710 Fixes #3706 Fixes #3623 Fixes #3687 Fixes #3617 Fixes #3757 Fixes #3790 Fixes #3786 Fixes #3785 Fixes #3772 Fixes #1657 Fixes #3443 Fixes #3824 Fixes #3817 Fixes #3805 Fixes #1666 Fixes #3700 Fixes #3821 Fixes #3771 Fixes #3794 Fixes #3825 Fixes #3690 Fixes #1472 Fixes #3813 Fixes #3719 Fixes #1592 Fixes #3845 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Read Copilot's
Open findings:label, drop the duplicatepr_review_rounds.null_node(callers usegh_graphql.null_node), and bring threescripts/README.mdpassages in line with the code on develop (hosted-reviewer hold inwaitexit 30,merge'sCHECKS_PENDINGrefusal withpending=, the Qodo dismiss remedy).Closes on promotion: #3824, #3817, #3805
Pre-existing findings, not filed:
limited_since: a queued check with no start time reads any past rate limit as newer (pre-existing, code outside this diff).Local strict review: attested below after the push.
🤖 Generated with Claude Code