[ptr727]

Summary

This changes backlog-burndown's "Cleanup Is the Orchestrator's" section, the re-verify bullet in its "Grouping and File Claims" section, and the abandon-discard exception that git-commit-conventions and GOVERNANCE.md "Git and Commit Rules" both state.

• Make backlog-burndown's Abandon-Discard Grant Reach a Claude Code Worker as the Maintainer's #3786: the orchestrator does the abandon discard, per the maintainer's answer on that issue.
  • A worker told to abandon its branch reports its worktree path and ends. It discards nothing.
  • The orchestrator waits until the worker has ended, per "Bounding the Wait on a Worker".
  • It then reads a live git worktree list --porcelain for a linked worktree whose branch line names the claimed branch, and runs git -C <path> reset --hard and git -C <path> clean -fd in that entry's own worktree path. Where no such entry exists, the group stops for the maintainer.
  • The matching exception in git-commit-conventions and the one sentence in GOVERNANCE.md now name the orchestrator instead of the worker. Nothing in agent-safety is edited.
• Align backlog-burndown's Abandoned-Branch Delete with Its Is-Ancestor Check #3785: the local branch delete now matches the is-ancestor check.
  • The orchestrator records the branch tip and runs the is-ancestor check against refs/remotes/origin/develop. Both happen before anything is removed.
  • The local branch is then deleted with git update-ref -d refs/heads/<branch> <tip>. That command refuses only if the branch has moved off the tip the check judged.
  • A git config --remove-section step drops the branch's tracking section, which git branch -d would have removed.
  • git branch -d judged a branch with no upstream against the base clone's HEAD. The fetch does not advance that HEAD, so a branch with no commits of its own could be refused even though deleting it discarded nothing.
• Apply backlog-burndown's Agent-Safety Hold When a Group's File Set Grows #3772: a file set that grows into host-setup/agent-safety/ gets the agent-safety hold.
  • When a worker reports that its files now reach into host-setup/agent-safety/, the orchestrator applies the "Ranking" hold as though it were ranking the issue now.
  • In an attended run, a group whose issue needing that edit has an approval recorded continues on a brief carrying the no-merge line.
  • Every other such group, and each one in an away-mode run, stops per "Raising a Blocked Question". An away run turns that stop into an ordinary park through the existing "Parking Instead of Asking" rule, so this adds no new parking path.

Closes on promotion: #3786, #3785, #3772

Verification

• uv run --script scripts/build_dist.py --check: generated skill distributions are current.
• The prose gate on the diff against origin/develop: no violations.
• scripts/repo_gate.py --check eol: 0 issues.
• spec/validate.py: OK.
• Local strict review: a recorded pass covers this head's content, with no findings open against this change. The pre-existing findings it raised are filed below.

Pre-existing findings, filed

• .agents/skills/backlog-burndown/SKILL.md "Cleanup Is the Orchestrator's", the discard path for a standalone clone (pre-existing). The base text already limited the discard to a linked worktree. Tracked in Give backlog-burndown a Path to a Dead or Abandoned Worker's Standalone Clone #3771.
• .agents/skills/backlog-burndown/SKILL.md "Ranking" (the resuming-group sentence) and the resume paragraph in "Parking Instead of Asking" state no precedence against "Ranking"'s away-mode agent-safety hold (pre-existing). A worker could already park on an agent-safety edit through "Needs the Maintainer" before this change. Filed as State That Releasing a Parked Group Never Lifts backlog-burndown's Away-Mode Agent-Safety Hold #3825.

🤖 Generated with Claude Code

[ptr727]

A recorded local strict-review pass covers head 11c370bf0d669b304c1e70000b1b4418ba186fbd, the content this pull request carries at that commit against develop, and it recorded 1 finding.

[coderabbitai]

Important

• Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

• Source mode: Auto
• Repository: ptr727/ProjectTemplate
• Branch: burndown/3786-burndown-cleanup
• File: .coderabbit.yaml
• Commit: 616ccf5
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: a4bd34fb-cb41-4ef9-9241-066aacfd5627

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[Copilot]

🟡 Changes recommended

Approval is blocked by active critical and moderate issues in the backlog-burndown cleanup and away-mode procedures, including stranded standalone clones, incorrectly continued approved growth during away runs, and premature worktree removal before guarded cleanup completes.

3 open issues

• Apply the away-mode hold before continuing approved growth · New
• Complete guarded cleanup before removing the worktree · New
• Clean up standalone clones using the reported path · New

What changed in this PR

This pull request moves abandoned-worktree cleanup to the orchestrator, aligns local branch deletion with its ancestry check, and applies agent-safety holds when claimed files expand into host-setup/agent-safety/. It also updates governance guidance and regenerated skill distributions.

Changes:

• Moves abandoned-worker discard responsibility to the orchestrator after worker termination.
• Replaces git branch -d with tip-checked git update-ref cleanup and tracking-section removal.
• Propagates agent-safety hold and cleanup-rule changes across canonical and generated skills.

Open findings:

• [P1][moderate, 2 votes] Standalone-clone cleanup is not handled; the reported path needs equivalent exact-branch and live-state checks.
• [P1][critical, 4 votes] Away-mode holds must apply before continuing when approved file-set growth reaches host-setup/agent-safety/.
• [P2][nit, 1 vote] Correct the missing article in the hold condition.
• [P2][moderate, 1 vote] Treat the branch name literally when querying branch configuration with --get-regexp.
• [P1][critical, 1 vote] Complete guarded remote cleanup before removing the local worktree, or provide rollback/retention handling for later refusals.

This pull request requires changes.

File	Description
GOVERNANCE.md	Updates the destructive-cleanup exception to name the orchestrator.
.github/​skills/​git-commit-conventions/​SKILL.md	Generated GitHub skill guidance for orchestrator-owned cleanup.
.github/​skills/​backlog-burndown/​SKILL.md	Generated GitHub backlog-burndown guidance for cleanup and agent-safety holds.
.claude-plugin/​fleet-skills/​skills/​git-commit-conventions/​SKILL.md	Generated Claude skill distribution for commit guidance.
.claude-plugin/​fleet-skills/​skills/​backlog-burndown/​SKILL.md	Generated Claude skill distribution for backlog-burndown guidance.
.claude-plugin/​fleet-skills/​.source-digests/​git-commit-conventions	Updated source digest for commit guidance.
.claude-plugin/​fleet-skills/​.source-digests/​backlog-burndown	Updated source digest for backlog-burndown guidance.
.agents/​skills/​git-commit-conventions/​SKILL.md	Canonical commit guidance for orchestrator-owned discard cleanup.
.agents/​skills/​backlog-burndown/​SKILL.md	Canonical cleanup, branch-deletion, and agent-safety hold rules.

_{Review effort: Lite}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.91%. Comparing base (b38e084) to head (616ccf5).
⚠️ Report is 75 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3822      +/-   ##
===========================================
+ Coverage    81.60%   82.91%   +1.30%     
===========================================
  Files           26       29       +3     
  Lines         9070     9750     +680     
===========================================
+ Hits          7402     8084     +682     
+ Misses        1668     1666       -2     

Flag	Coverage Δ
python-3.13	82.91% <ø> (+1.30%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ptr727]

A recorded local strict-review pass covers head 616ccf58b53cd93aadc755000bce617bd1108a77, the content this pull request carries at that commit against develop, and it recorded 0 findings.

[ptr727]

Answers to the review round on 11c370b: the 5 findings under its overview's "Open findings:" label, which the reader left unplaced. #3824 is filed so the reader picks up that label.

• .agents/skills/backlog-burndown/SKILL.md:280, "Away-mode holds must apply before continuing when approved file-set growth reaches host-setup/agent-safety/": Fixed in 0de60ca, tightened in 616ccf5. The same finding as the resolved thread.
• .agents/skills/backlog-burndown/SKILL.md:411, "Complete guarded remote cleanup before removing the local worktree": Disproven. Removal runs only after the is-ancestor and clean-tree checks hold, so a later refusal loses nothing. The thread reply has the evidence.
• .agents/skills/backlog-burndown/SKILL.md:399, "Standalone-clone cleanup is not handled": Deferred to Give backlog-burndown a Path to a Dead or Abandoned Worker's Standalone Clone #3771, which predates this change. The thread reply has the details.
• "Correct the missing article in the hold condition": No change needed. It is a wording preference that no repository rule supports, per fleet-code-review "Review the Change" item 5. That sentence was also rewritten in 0de60ca and 616ccf5.
• .agents/skills/backlog-burndown/SKILL.md:414, "Treat the branch name literally when querying branch configuration with --get-regexp": No change needed, per GOVERNANCE.md "Trust Boundaries and Hardening Effort".
  • The branch name is the orchestrator's own claimed branch, which is trusted input.
  • A metacharacter mismatch fails loudly rather than silently or destructively. --get-regexp would print another branch's section, and git config --remove-section branch.<exact-branch> would then refuse with "no such section". The procedure's "A refusal stops the group for the maintainer" covers that.
  • The removal only ever names the exact branch's own section, so no other branch's config can be removed.