[ptr727]

Summary

• gh_graphql.request() now raises NullNodeError (a GraphQLError) when any nodes list in the response holds a null. The check and null_node() live in the shared transport.
• pr_review.gh_graphql() keeps its query-only re-read around the new error and ends the run naming where the null sat. A mutation is never sent twice.
• Removed the per-site isinstance(n, dict) guards in pr_cleanup.py that the transport makes redundant. handoff.py's label-node read, which raised TypeError on a null node, now reports exit 2 through its existing GraphQLError handling.
• Tests: null node through the shared transport, the moved null_node helper, and handoff.labeled with a null label node.

pr_review.py shrinks by one line. pr_review_rounds.null_node is now unused by scripts and is left for a follow-up since that file is outside this change.

Closes on promotion: #3687

🤖 Generated with Claude Code

[coderabbitai]

Important

• Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

• Source mode: Auto
• Repository: ptr727/ProjectTemplate
• Branch: burndown/3687-graphql-null-node
• File: .coderabbit.yaml
• Commit: 77f3be9
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 920b5aff-13ca-4731-9927-833cf71d81f3

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[ptr727]

A recorded local strict-review pass covers head d3b3da64646aedd680570cd29300b3525d89175e, the content this pull request carries at that commit against develop, and it recorded 2 findings.

[Copilot]

🟡 Changes recommended

Unresolved findings remain, most notably a moderate issue where removing the null base-node guard in scripts/pr_cleanup.py sends those responses down an untested unread-reporting path for the bases, merged, and finished connections.

2 open issues

• Test null nodes in bases and merged connections · New
• Split test to match the assertions it covers · New

What changed in this PR

This PR moves the check for null items in GraphQL nodes lists into the shared transport, scripts/gh_graphql.py. Before, each caller had to guard against them, and handoff.py did not. Now request() raises NullNodeError, a subclass of GraphQLError, and pr_review.py keeps its query-only re-read. It also closes #3687.

Changes:

• gh_graphql.request() raises NullNodeError, which names the first connection holding a null. The null_node() helper moved here as well.
• pr_review.gh_graphql() still re-reads queries that hit a null, but never re-sends a mutation. A null that persists ends the run and names where it sat.
• The isinstance guards in pr_cleanup.py are removed. A null in handoff.py's label read now reports exit 2 instead of raising TypeError.

File	Description
tests/​test_pr_review.py	Drops the test for the old local null_node helper. The re-read and mutation tests stay.
tests/​test_handoff.py	Adds a test that a null label node is reported as an execution failure.
tests/​test_gh_graphql.py	Adds tests that request() raises NullNodeError with the right location, and that null_node() finds nulls.
scripts/​pr_review.py	Catches NullNodeError in the re-read path and drops the old helper import.
scripts/​pr_cleanup.py	Removes the per-site isinstance guards, since the transport now handles nulls.
scripts/​gh_graphql.py	Adds NullNodeError and the null_node() check that runs before request() returns.

_{Review effort: Lite}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.91%. Comparing base (b38e084) to head (77f3be9).
⚠️ Report is 73 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3816      +/-   ##
===========================================
+ Coverage    81.60%   82.91%   +1.30%     
===========================================
  Files           26       29       +3     
  Lines         9070     9750     +680     
===========================================
+ Hits          7402     8084     +682     
+ Misses        1668     1666       -2     

Flag	Coverage Δ
python-3.13	82.91% <100.00%> (+1.30%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ptr727]

A recorded local strict-review pass covers head 77f3be9fd17ccde9d287819cfeb01de9a495e847, the content this pull request carries at that commit against develop, and it recorded 2 findings.