[ptr727]

Summary

A hook in a linked worktree inherits GIT_DIR. Under GIT_DIR with no GIT_WORK_TREE, git takes the directory a command starts in as the work tree's top level. So a run naming a subdirectory, such as prose_lint.py sub, read git -C sub ls-files as though sub/ were the root, and the top level's ignores lapsed.

• The reads of the scanned tree now run under a new tree_env(). These are tracked_paths, untracked_paths, shallow_checkout, git_bytes, and the dead-path rule's once_tracked. tree_env() drops the location variables as git_env() does for repo_root and provenance. once_tracked reads the same tree through the same git -C, so it is the same class and moves with the rest.
• tree_env() keeps GIT_INDEX_FILE. Measured on git 2.47, git commit -a hands the hook index.lock, and git commit <paths> hands it next-index-*.lock. That index is what the commit records, and the checkout's own index is not, so dropping it would make the gate read the wrong one. A plain commit in the main worktree hands the hook a relative .git/index with GIT_DIR unset, which was already inherited and is unchanged.

Tests

The tests are built from the issue's constructed repro, with temporary repositories and synthetic content only.

• test_a_hook_in_a_linked_worktree_names_a_subdirectory: under GIT_DIR, an ignored file in the named subdirectory stays unread.
• test_each_scanned_tree_read_answers_for_the_directory_it_names: with GIT_DIR naming a different, shallow repository, each of the five reads answers for the directory it names. Reverting any one call site alone fails this case, checked site by site.
• test_a_commit_naming_paths_keeps_the_index_it_hands_its_hook: a real git commit <paths> in a linked worktree runs a pre-commit hook that lists a subdirectory. The listing holds the file the commit's index still tracks and the checkout's index dropped. It fails both when the whole environment is inherited and when GIT_INDEX_FILE is dropped with GIT_DIR. It is skipped off POSIX, as the textconv-driver case is, since the hook is written for a POSIX shell.

prose_lint.py grows by 14 lines and no ceiling moves.

Local review

Two recorded local-strict-review passes. The first raised one introduced finding, the real-hook case running unguarded on the Windows leg, which was fixed in f47ab60. The second raised none.

Pre-existing findings, not filed

• .github/actions/prose-gate/prose_lint.py GIT_LOCATION, consolidation: its list differs from spec/git_env.py's GIT_LOCATION_VARS, for example in GIT_SHALLOW_FILE and GIT_GRAFT_FILE. No hook sets the missing ones, and the gate cannot import spec/.

Closes on promotion: #3821

🤖 Generated with Claude Code

[ptr727]

A recorded local strict-review pass covers head f47ab6001af0bb9a3721aec4cd2ecfe6d864fb5b, the content this pull request carries at that commit against develop, and it recorded 0 findings.

[coderabbitai]

Important

• Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

• Source mode: Auto
• Repository: ptr727/ProjectTemplate
• Branch: burndown/3821-prose-gate-git-env
• File: .coderabbit.yaml
• Commit: f47ab60
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 8b7015ad-ef8e-4cd9-a077-30f26e0c3b51

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[Copilot]

🟢 Approval recommended

No active issues remain, and the reviewed changes stop an inherited GIT_DIR from altering the scanned-tree git reads while keeping GIT_INDEX_FILE, which commit hooks rely on.

No open issues 🎉

What changed in this PR

The prose gate runs git reads against a directory it is scanning. When a hook in a linked worktree runs it, git passes in GIT_DIR. Under that variable, git treats the directory a command starts in as the top of the work tree, so a subdirectory scan could ignore the real top-level ignore rules. This PR gives those reads their own environment that drops the location variables. It keeps GIT_INDEX_FILE, because a commit hands its hook that index, and the commit records it.

Changes:

• Adds tree_env(), which drops the location variables but keeps GIT_INDEX_FILE, and uses it for the five reads of the scanned tree.
• Adds three tests: one for a subdirectory under GIT_DIR, one that checks each of the five reads against a different shallow repository, and one that runs a real git commit <paths> with a pre-commit hook.

File	Description
tests/​test_prose_lint.py	Adds three regression tests covering the subdirectory case, the five scanned-tree reads, and the commit index handed to a hook.
.github/​actions/​prose-gate/​prose_lint.py	Adds tree_env() and applies it to the scanned-tree git reads, so an inherited GIT_DIR no longer changes their answers.

_{Review effort: Lite}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.91%. Comparing base (b38e084) to head (f47ab60).
⚠️ Report is 78 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3831      +/-   ##
===========================================
+ Coverage    81.60%   82.91%   +1.30%     
===========================================
  Files           26       29       +3     
  Lines         9070     9750     +680     
===========================================
+ Hits          7402     8084     +682     
+ Misses        1668     1666       -2     

Flag	Coverage Δ
python-3.13	82.91% <ø> (+1.30%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.