[ptr727]

Summary

Two Merge Gate gaps pr_review.py merge hit on PlexCleaner pull requests.

A hosted review still running holds the merge (#3789). merge squash-merged a feature pull request while CodeRabbit was still reviewing its head. That happened because an UNSTABLE merge state let an unrequired check stop holding the wait.

• check_nodes now records who posted each check. That is a StatusContext's creator login, newly read by the query, or a CheckRun's app slug.
• hosted_reviews_running names each CodeRabbit or Qodo check on the head still settling. It matches by the poster or by a context named for the reviewer. The reviewers come from OTHER_REVIEWERS. It skips a reviewer whose newest output is a rate limit posted or edited since the check began, so that state still clears. An older limit the reviewer has moved past does not. The held read now carries each comment's updatedAt for that.
• wait holds an attested head on such a check whatever the merge state reads. Its CHECKS_PENDING line then adds (reviewing: <name>).
• merge's fresh read refuses it as CHECKS_PENDING, which routes redrive. That covers a head wait does not poll and a review that starts after the gate read.
• A merge run inside the write scope that merged nothing and routes to redrive or the maintainer now prints pending= before next=. It names each check on the head that has neither passed nor failed, from a fresh read. So a pull request handed to the maintainer names what still runs.
• A hosted status that has not registered on the head yet is not held. That second factor from Hold pr_review.py merge While a CodeRabbit Review of the Head Is Still Running #3789 needs a design choice, filed as Hold pr_review.py merge for a Hosted Review Whose Status Has Not Registered Yet #3806.

Qodo findings are answered with a dismiss request (#2252). Per the maintainer's answer on #2252, qodo_open keeps reading Qodo's own badge.

• The digest's Qodo remedy text no longer says to answer in the conversation, which never adds the badge. It says Qodo marks a fixed finding Resolved itself. For a disproved one, the --ack comment's body mentions @<Qodo's login> and asks it to dismiss that finding by its number, with the reason. The number comes from the findings comment.
• pr-review-conduct Merge Gate item 3 and drive-pr step 4 say the same thing. drive-pr routes an UNTHREADED_FINDINGS line naming qodo_open to that answer rather than to a blocked merge.
• pr-review-conduct item 2 states the hosted-review hold.

The live check #2252 asks for is not part of this change. It confirms on a PlexCleaner pull request that a dismiss request adds the badge, which wording Qodo accepts, and which number it wants. So #2252 stays open.

scripts/README.md is held by another group in this round, so its pr_merge.py, wait, and findings paragraphs are not updated here. #3805 tracks that.

Line counts stay under every ceiling: pr_review.py 2171 of 2200, pr_review_answers.py 402 of 450, pr_review_checks.py 435 of 450, pr_merge.py 246 of 250.

Local-review finding outcomes

• introduced, listed on the opening push: limited_since dated a rate limit by the newest edit across every reviewer comment, so a summary comment edited as a review starts could clear the hold. Fixed in f38355e, which compares the edit time of the node rate_limited_by reads, with a test for that case.
• Copilot, [P1] Hold every unfinished hosted check: fixed in 7eb8ee6 and 75b4dd1. The hold now reads every shape short of a pass or a failure, so a hosted check queued past the pickup grace, waiting, or a stale record still holds. Its thread was already resolved when the fix landed.

Verification

• tests/test_pr_review.py (550), tests/test_pr_merge.py (70), tests/test_pr_review_copilot.py, tests/test_pr_review_size.py, tests/test_pr_cleanup.py, and tests/test_build_dist.py pass.
• New cases cover the poster each check carries and each way a hosted check matches. They also cover the rate-limit clear and an older limit that does not clear. They cover the hold on CLEAN, UNSTABLE, and HAS_HOOKS, and merge's CHECKS_PENDING refusal. The pending= line, its unread form, and its absence on an out-of-scope refusal are covered, and so is the Qodo dismiss remedy.
• ruff format and check, mypy, the prose gate, repo_gate.py --check eol, and build_dist.py --check are clean.

Closes on promotion: #3789

🤖 Generated with Claude Code

[ptr727]

A recorded local strict-review pass covers head fb9519a2ab74624ca917a9e6f2a940f7e7d9cc3e, the content this pull request carries at that commit against develop, and it recorded 1 finding.

[coderabbitai]

Important

• Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

• Source mode: Auto
• Repository: ptr727/ProjectTemplate
• Branch: burndown/2252-merge-gate-reviews
• File: .coderabbit.yaml
• Commit: 75b4dd1
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: efb1bd7f-78d4-4898-89c7-1c921bdab06a

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[ptr727]

A recorded local strict-review pass covers head f38355e305b7b6d014df954bdf130b6144568b55, the content this pull request carries at that commit against develop, and it recorded 1 finding.

[Copilot]

🟡 Changes recommended

Two critical issues can allow merges to proceed while the selected rate-limit review or hosted checks are still incomplete, so the gating logic must be corrected.

2 open issues

• Compare the selected rate-limit node's timestamp · New
• Hold all unfinished hosted checks · New

What changed in this PR

This PR strengthens Merge Gate handling for active CodeRabbit and Qodo reviews, adds pending-check diagnostics, and documents the Qodo dismissal-request workflow across skill distributions.

Changes:

• Tracks check posters and holds merges while hosted reviews remain unfinished.
• Reports pending checks during merge refusals.
• Updates Qodo finding remedies and synchronized skill guidance.
• Adds regression coverage for hosted reviews, rate limits, pending checks, and merge routing.

This pull request requires changes.

Review findings:

• scripts/pr_review_checks.py: [P1, critical, 4 votes] compare the selected rate-limit node’s timestamp; [P1, critical, 1 vote] hold every unfinished hosted check; [P2, moderate, 1 vote] evaluate hosted-review holds before the BLOCKED short circuit.
• scripts/pr_merge.py: [P1, moderate, 1 vote] handle GraphQLError during the pending read; [P2, moderate, 1 vote] treat truncated check rollups as unread.

File	Description
tests/​test_pr_review.py	Tests hosted-review detection, rate-limit handling, pending checks, and Qodo remedies.
tests/​test_pr_merge.py	Tests merge holds, pending diagnostics, and refusal routing.
scripts/​pr_review.py	Integrates hosted-review data into queries, wait handling, and reporting.
scripts/​pr_review_checks.py	Normalizes check posters and detects hosted reviews still settling.
scripts/​pr_review_answers.py	Adds hosted-review gate findings and Qodo dismissal guidance.
scripts/​pr_merge.py	Adds fresh pending-check reporting during merge refusal handling.
.github/​skills/​pr-review-conduct/​SKILL.md	Documents hosted-review holds and Qodo dismissal requests.
.github/​skills/​drive-pr/​SKILL.md	Routes hosted-review holds and Qodo findings through the driving workflow.
.claude-plugin/​fleet-skills/​skills/​pr-review-conduct/​SKILL.md	Generated Claude distribution of the review-conduct guidance.
.claude-plugin/​fleet-skills/​skills/​drive-pr/​SKILL.md	Generated Claude distribution of the drive guidance.
.claude-plugin/​fleet-skills/​.source-digests/​pr-review-conduct	Updates the generated review-conduct source digest.
.claude-plugin/​fleet-skills/​.source-digests/​drive-pr	Updates the generated drive source digest.
.agents/​skills/​pr-review-conduct/​SKILL.md	Updates the canonical review-conduct skill.
.agents/​skills/​drive-pr/​SKILL.md	Updates the canonical drive skill.

_{Review effort: Lite}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.83%. Comparing base (23c7d78) to head (75b4dd1).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3809      +/-   ##
===========================================
+ Coverage    82.72%   82.83%   +0.10%     
===========================================
  Files           29       29              
  Lines         9629     9686      +57     
===========================================
+ Hits          7966     8023      +57     
  Misses        1663     1663              

Flag	Coverage Δ
python-3.13	82.83% <100.00%> (+0.10%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ptr727]

A recorded local strict-review pass covers head 75b4dd13a52a7caefd01a96af4783a359901e3d8, the content this pull request carries at that commit against develop, and it recorded 0 findings.