Skip to content

Re-Audit HomeAutomation-Config on the Release Model - #1781

Merged
ptr727 merged 2 commits into
developfrom
reports/homeautomation-config-2026-09-24
Sep 24, 2026
Merged

ptr727 merged 2 commits into
developfrom
reports/homeautomation-config-2026-09-24

Conversation

@ptr727

@ptr727 ptr727 commented Sep 24, 2026

Copy link
Copy Markdown
Owner

Rewrites reports/homeautomation-config/audit.md, which still graded the repository on the operational model as of 2026-08-15.

This run reads main at 5a7b1b1, after the resync (ptr727/HomeAutomation-Config#434) and its promotion (#435). Run stamp: audit run 2026-09-24T20:41:24Z | hub 2c5802f.

  • Verdict: not operational. The mechanical run is clean. Two hand-judged linter-parity defects fail it. Notify/ has no CI gate (ptr727/HomeAutomation-Config#368), and no local hook is wired for parity.hooks (ptr727/HomeAutomation-Config#436). ptr727/HomeAutomation-Config#438 tracks every residual delta.
  • Drift: the four byte-identical intent advisories (An intent finding verified satisfied cannot be cleared, so a correct resync can never produce a clean run #727), the PSScriptAnalyzerSettings.psd1 path collision (Triage PSScriptAnalyzerSettings.psd1 as a Path Collision, the Way actionlint.yaml Already Is #1718), and the two callers without permissions: {} (ptr727/HomeAutomation-Config#437).
  • Proposed, not applied: the psd1 accepted entry, dropping HomeAutomation-Config from the .editorconfig-checker.json divergence entry now that its copy is canonical, and a maintainer decision on declaring python for this repository.
  • Escalated, not filed: repo-config/settings.json does not declare the default workflow token permission, so configure.sh check cannot see it.

An independent local review checked more than 30 of the report's file:line citations and both defect premises against the tree, and found nothing.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings September 24, 2026 21:05
@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 2457a843-0b9a-42bf-8990-fa64321e8a4a


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Several HomeAutomation-Config PR references use bare “#NNN” shorthand that is ambiguous in this repo’s reports and should be qualified for clarity/consistency.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Low severity

Open (1)
What changed in this PR

Updates the committed audit report for HomeAutomation-Config to reflect its reclassification from the operational workflow model to the release workflow model, including refreshed run metadata and re-evaluated dimension verdicts.

Changes:

  • Replaces the prior 2026-08-15 audit snapshot with a full 2026-09-24 rerun scoped to the release model and current rulesets.
  • Updates the “Develop Drift”, dimension table, and workflow assertions to match release-model expectations and current findings.
  • Expands/refreshes the narrative sections (defects, drift findings, escalations, and proposed spec/registry updates) for the new run.
File Description
reports/​homeautomation-config/​audit.md Rewrites the HomeAutomation-Config audit report to reflect the release-model re-audit and its updated findings.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread reports/homeautomation-config/audit.md Outdated
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings September 24, 2026 21:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The change is a documentation/report update only, and the revised report content is internally consistent and conforms to the repository’s prose gate constraints.

Review effort: Lite
Findings: None

Resolved since last review (1)

@ptr727
ptr727 merged commit ecdabb6 into develop Sep 24, 2026
9 checks passed
@ptr727
ptr727 deleted the reports/homeautomation-config-2026-09-24 branch September 24, 2026 21:24
@ptr727

ptr727 commented Sep 24, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Pull request is closed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

ptr727 added a commit that referenced this pull request Sep 24, 2026
…1784)

Promotes the rewritten HomeAutomation-Config audit report, which now
grades that repository on the release workflow model, and three
corrections to it that Copilot raised on this PR.

## What reaches main

- **Report (#1781):** `reports/homeautomation-config/audit.md` is re-run
against HomeAutomation-Config's `main` after its resync and promotion.
- **Verdict:** not operational. The mechanical run is clean, and two
hand-judged `linter-parity` defects fail it.
- **Drift:** the byte-identical intent advisories (#727), the
`PSScriptAnalyzerSettings.psd1` path collision (#1718), and two callers
without `permissions: {}`.
- **Escalation (#1785):** the workflow-token escalation now points at
its issue, hub #1783, rather than saying it is not yet filed.
- **Reference (#1786):** "promoted in #1768" is now qualified as hub
#1768.
- **Intent advisories (#1787):** the report now says what the advisory
measures, each file's `intentRef` document rather than the hub's own
copy. That is why a byte-identical file still gets flagged.

No hub issue closes with this promotion. #727, #1718, and #1783 stay
open.

## Review state

- **Merge:** merged to `develop` as ecdabb6 (#1781), 21917a0 (#1785),
e4fc02a (#1786), and b7fb7a4 (#1787).
- **Copilot:** four rounds on this PR, the last on head b7fb7a4 with
nothing new. Its one thread was fixed and resolved. Both
previously-missed findings are answered in the conversation, each with
its fixing commit.
- **CodeRabbit:** reviewed head ecdabb6 with no actionable comments,
then was rate-limited for the three one-line fix PRs. Copilot reviewed
each of those on its own head with no findings.
- **Local strict review:** a recorded pass on each fix PR's pushed head.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants