Repository navigation
Qualify the Hub Promotion Reference in the HomeAutomation-Config Audit - #1786
Conversation
|
@coderabbitai review |
|
Warning Review limit reachedNext included review available in 43 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The change is a straightforward wording clarification that improves reference clarity without affecting any behavior or policy statements.
Review effort: Lite
Findings: None
What changed in this PR
This PR clarifies that the referenced promotion pull request number is from the hub repository (ProjectTemplate) rather than HomeAutomation-Config, by qualifying #1768 as hub #1768 in the HomeAutomation-Config audit report introduction.
Changes:
- Update the audit report opening paragraph to disambiguate the hub promotion PR reference by changing
promoted in #1768topromoted in hub #1768.
| File | Description |
|---|---|
| reports/homeautomation-config/audit.md | Disambiguates the hub promotion PR reference in the report opening paragraph. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…1784) Promotes the rewritten HomeAutomation-Config audit report, which now grades that repository on the release workflow model, and three corrections to it that Copilot raised on this PR. ## What reaches main - **Report (#1781):** `reports/homeautomation-config/audit.md` is re-run against HomeAutomation-Config's `main` after its resync and promotion. - **Verdict:** not operational. The mechanical run is clean, and two hand-judged `linter-parity` defects fail it. - **Drift:** the byte-identical intent advisories (#727), the `PSScriptAnalyzerSettings.psd1` path collision (#1718), and two callers without `permissions: {}`. - **Escalation (#1785):** the workflow-token escalation now points at its issue, hub #1783, rather than saying it is not yet filed. - **Reference (#1786):** "promoted in #1768" is now qualified as hub #1768. - **Intent advisories (#1787):** the report now says what the advisory measures, each file's `intentRef` document rather than the hub's own copy. That is why a byte-identical file still gets flagged. No hub issue closes with this promotion. #727, #1718, and #1783 stay open. ## Review state - **Merge:** merged to `develop` as ecdabb6 (#1781), 21917a0 (#1785), e4fc02a (#1786), and b7fb7a4 (#1787). - **Copilot:** four rounds on this PR, the last on head b7fb7a4 with nothing new. Its one thread was fixed and resolved. Both previously-missed findings are answered in the conversation, each with its fixing commit. - **CodeRabbit:** reviewed head ecdabb6 with no actionable comments, then was rate-limited for the three one-line fix PRs. Copilot reviewed each of those on its own head with no findings. - **Local strict review:** a recorded pass on each fix PR's pushed head. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
The HomeAutomation-Config audit report's opening said "(hub #1766, promoted in #1768)". #1768 is the hub's own promotion PR, but without the qualifier it reads like a HomeAutomation-Config number. It now says "hub #1768". A sweep of the report found no other hub reference missing the qualifier.
Raised by Copilot as a previously-missed finding on promotion PR #1784. A fix can't be pushed to the promotion PR itself, so it lands here first.
🤖 Generated with Claude Code