Repository navigation
Say What the HomeAutomation-Config Intent Advisories Measure - #1787
Conversation
The report said the four intent advisories fire because the hub's canonical changed after the repository's copy. The files are byte-identical to the hub's own copies, and the advisory measures each against its intentRef document instead, which a config file can never match, so its identity skip cannot clear it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
@coderabbitai review |
|
Warning Review limit reachedNext included review available in 34 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The change is a documentation-only correction and its updated explanation matches the implemented audit logic (intent staleness uses intentRef via intent_canonical_rel() and check_intent_staleness()).
Review effort: Lite
Findings: None
What changed in this PR
Updates the HomeAutomation-Config audit report to accurately explain why the four intent advisories fire, clarifying that the audit’s intent-staleness check compares each carried file against its intentRef document (for staleness), not against the hub’s copy of the carried file.
Changes:
- Correct the Drift Findings explanation for the four intent advisories to reflect the
intentRef-based comparand used byintent_canonical_rel()andcheck_intent_staleness(). - Clarify why the content-identity skip cannot clear these advisories for config files whose
intentRefpoints atGOVERNANCE.md/WORKFLOW.md.
| File | Description |
|---|---|
| reports/homeautomation-config/audit.md | Fixes the narrative explanation of intent advisories to match the audit engine’s actual comparand (intentRef document). |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…1784) Promotes the rewritten HomeAutomation-Config audit report, which now grades that repository on the release workflow model, and three corrections to it that Copilot raised on this PR. ## What reaches main - **Report (#1781):** `reports/homeautomation-config/audit.md` is re-run against HomeAutomation-Config's `main` after its resync and promotion. - **Verdict:** not operational. The mechanical run is clean, and two hand-judged `linter-parity` defects fail it. - **Drift:** the byte-identical intent advisories (#727), the `PSScriptAnalyzerSettings.psd1` path collision (#1718), and two callers without `permissions: {}`. - **Escalation (#1785):** the workflow-token escalation now points at its issue, hub #1783, rather than saying it is not yet filed. - **Reference (#1786):** "promoted in #1768" is now qualified as hub #1768. - **Intent advisories (#1787):** the report now says what the advisory measures, each file's `intentRef` document rather than the hub's own copy. That is why a byte-identical file still gets flagged. No hub issue closes with this promotion. #727, #1718, and #1783 stay open. ## Review state - **Merge:** merged to `develop` as ecdabb6 (#1781), 21917a0 (#1785), e4fc02a (#1786), and b7fb7a4 (#1787). - **Copilot:** four rounds on this PR, the last on head b7fb7a4 with nothing new. Its one thread was fixed and resolved. Both previously-missed findings are answered in the conversation, each with its fixing commit. - **CodeRabbit:** reviewed head ecdabb6 with no actionable comments, then was rate-limited for the three one-line fix PRs. Copilot reviewed each of those on its own head with no findings. - **Local strict review:** a recorded pass on each fix PR's pushed head. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
The HomeAutomation-Config audit report said its four intent advisories fire because the hub's canonical changed after the repository's copy did. It called the files byte-identical to that canonical. Copilot pointed out, on promotion PR #1784, that the engine skips a byte-identical copy, so both claims can't be true.
The files are byte-identical to the hub's own copies at
2c5802f, which I checked by hashing all four on each side. The explanation was the wrong part.intent_canonical_relinspec/audit.pymeasures each file against itsintentRefdocument,GOVERNANCE.mdorWORKFLOW.md(spec/files.json:18-25), rather than against the hub's copy. A config file can never match that document, so the identity skip can't clear it. Line 65 now says that. The clear-only-by-an-unneeded-commit gap stays hub #727, and no new issue is needed.A sweep of the report's other "byte-identical"/"canonical" uses (lines 35, 69, 84) found each one true as written, because none of them explains the advisory's mechanism.
🤖 Generated with Claude Code